From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC14E45AB0; Sat, 5 Oct 2024 00:16:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA5D2402E6; Sat, 5 Oct 2024 00:16:13 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id BCEFF4029A for ; Sat, 5 Oct 2024 00:16:11 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20b8be13cb1so27809225ad.1 for ; Fri, 04 Oct 2024 15:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728080171; x=1728684971; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0xHaVK/IQ/p8a2azgWLH+PiS75GScymz9pLy0EMsZ44=; b=Q3SwkWYsk1hlRsLWcl04cAOyhfLBJ4pEIOZY7tIelzzggZKNWvmnV1dea8H2X/IyaX LMfLombjszkwQYWbZdmXzeU+PEC4pdUGVlopDaKSB1yRoAQP02ng3+ug5i3/TJVHVZRC lRkqCVxxxOkQSyfwGKP5AhrQtxVFrNO81ZS+dizcaCZ5KtTT/V4ab1sW2VQDfcxGe8UV +lM73nN9mYJPNEhHTQaRK0hF8WaI2R8tjvDMWP32IUKh/8ojsxx43IT1nF/JR8xqIvX8 c3HIRkgwhZRAteVL/gQmc6tjSRQkM9ieyAfQ7uOrKP06JN4ABEvOLXDKEwM8+57oP1Xj ucBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728080171; x=1728684971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0xHaVK/IQ/p8a2azgWLH+PiS75GScymz9pLy0EMsZ44=; b=WT88wzKd//XldDJszBccIrv47/cvFrE1gX0itOzzZGkuFLVfFRQYa49spQ6Ah4ce8L bR6FRgLvnDxsDiNadyFXv9tLHqSNZyYCFx6v+/VQCJuEZvIdCwArorJq0AxiWz6aW96Q 4UIQGFHZqoHDyvaZwsIWzeXNy6UP/TMN9pQ5MNGbhIpdpZye690qC9XxHxm96LWv6sYu qaQ3NOBRZpRe0TgvXWivpXHj3+XbfMze7mmBqj1XH9jhyPh1UHynk/jikfjwgVEl6x91 BUX+5ypfMfSseafFsgKSfZaCBlMmf3NLG+0sKH3sSujhh2FC56JkJ29CZorSm9dYNfzY gLNg== X-Forwarded-Encrypted: i=1; AJvYcCVYQGrScoSjNjS9CosvY/34hQNn5+Tfhs4zdzZughhpq+9Bf9vaPODYKTJQkU8as64bI/M=@dpdk.org X-Gm-Message-State: AOJu0YwaH5QgKwo3TQPapUEpRnoX/DSICuGKmyWqcOdMvHNalz/d189I B+/l44fhq8H08UrNNtlNWslLSpXuUEvBWd416wftm9BiQKGuvNIUWsZi/RV1Ej8= X-Google-Smtp-Source: AGHT+IHA9fTi+9Y2fDCzS+nWRxa8MzgtBV/nIs7OG+0VqROx5mC9OrSHat7GPvW0pzsjLJuopaWcFA== X-Received: by 2002:a17:902:e881:b0:20b:861a:25c7 with SMTP id d9443c01a7336-20bff188ac9mr52729125ad.54.1728080170907; Fri, 04 Oct 2024 15:16:10 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c138d068bsm3270465ad.96.2024.10.04.15.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 15:16:10 -0700 (PDT) Date: Fri, 4 Oct 2024 15:16:08 -0700 From: Stephen Hemminger To: John Romein Cc: Slava Ovsiienko , Aaron Conole , "dev@dpdk.org" , Raslan Darawsheh , Elena Agostini , Dmitry Kozlyuk , Matan Azrad , Ori Kam , Suanming Mou Subject: Re: [PATCH v2] common/mlx5: Optimize mlx5 mempool get extmem Message-ID: <20241004151608.478a2859@hermes.local> In-Reply-To: <05b8ccc9-a159-4141-b323-924f7ec15baf@astron.nl> References: <20231010143800.102459-1-aconole@redhat.com> <05b8ccc9-a159-4141-b323-924f7ec15baf@astron.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 1 Nov 2023 22:21:16 +0100 John Romein wrote: > Dear Slava, >=20 > Thank you for looking at the patch.=C2=A0 With the original code, I saw t= hat=20 > the application spent literally hours in this function during program=20 > start up, if tens of gigabytes of GPU memory are registered.=C2=A0 This w= as=20 > due to qsort being invoked for every new added item (to keep the list=20 > sorted).=C2=A0 So I tried to write equivalent code that sorts the list on= ly=20 > once, after all items were added.=C2=A0 At least for our application, thi= s=20 > works well and is /much/ faster, as the complexity decreased from n^2=20 > log(n) to n log(n).=C2=A0 But I must admit that I have no idea /what/ is= =20 > being sorted, or why; I only understand this isolated piece of code (or=20 > at least I think so).=C2=A0 So if you think there are better ways to=20 > initialize the list, then I am sure you will be absolutely right.=C2=A0 B= ut I=20 > will not be able to implement this, as I do not understand the full=20 > context of the code. >=20 > Kind Regards,=C2=A0 John Looks like the problem remains but patch has been sitting around for 11 mon= ths. Was this resolved?