From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72D8445AB0; Sat, 5 Oct 2024 00:21:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05F9A402E6; Sat, 5 Oct 2024 00:21:28 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 653974029A for ; Sat, 5 Oct 2024 00:21:26 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20b4a0940e3so24535615ad.0 for ; Fri, 04 Oct 2024 15:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728080485; x=1728685285; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=QPN/Ynq4/iWBNrUiAQcEMST+THyokh/R4M0b5wXzHlg=; b=kkRqGVjhD4qVDjd7xb9X/FNMBgeQBLYyNqGUy9TRgI1eTQ8G+0C5DuxhNdzwt6VrWw NjXXjx01dRy1UrTyc7ZVf2pCKNU95dwxU2PUnTdrrPxTg4rgNVbxOdP62PSB9d430sQs LtRhAml9HYVmVilsJJdl5zZYB8N6/gbmHAc5YqenTZSU6Yjr2pd4CWtn4CUep75NzyTy 67AyoQ951AQq0sk0Ues7igXkevG27BMScTj2wEw0+myLho2kHi4rFXjVABzPuJJqi3tq GFXkf/DlkHlf7V3U8/pQMlYeiJi2NGlqdO4V8Gv3g+3KFiQ+bZ8mVMPrde6krchBl4nL LggQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728080485; x=1728685285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QPN/Ynq4/iWBNrUiAQcEMST+THyokh/R4M0b5wXzHlg=; b=OBMA7HgR3kTf0wfW0v5Y2UdnqOiU/3rxIY8MRlTEtNLKzYQrYM4wtdWbzpv2n5QDoX PstN5K+3J/ozMPyGpKBQVii8lF0bt9yTeYOrM5UOdoeON3Q6RmG/6Mm1Jg1cWjPIOtSL OsmG1LdeCCJL/1EpByCyfU/ZjGn8teyjH+7INcxBiV5uYNeRzTFLDYw5h/AuZc4ZIBbk aX0fGbzDlI+13JMIo/LdmQ8LAi5OBnECHW2xtr1AC6hAIaewW++iLGSv5OsLmxGUFBvR gN8M3DXNdjfcDBm0tOcsN8+oEc0IH2Q4zA3y8jF6+gp6wOk+DqeYU5HSU573ZjLL1e8w sZtw== X-Gm-Message-State: AOJu0YwZzcukIHqQ2wAls162Q9xTdpVAEgdmgLrZo/RmPSI0KzGoF2BR AicyqylLcQy8ip+iX+tp93rNYXO9zmXgbp6Szf0aSvAkmkNnzO2prnF/7X5b4YQ= X-Google-Smtp-Source: AGHT+IGCUpZ4ZOUVW0IfCTc/S/dkM30N5jocr20ciLFkJQkqa5PrxhuUbl9dcDEmDWVikZzSXPVGRQ== X-Received: by 2002:a17:903:18e:b0:20b:7dda:1fd7 with SMTP id d9443c01a7336-20bff03c34bmr68388755ad.48.1728080485469; Fri, 04 Oct 2024 15:21:25 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c138b1395sm3292285ad.3.2024.10.04.15.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 15:21:25 -0700 (PDT) Date: Fri, 4 Oct 2024 15:21:23 -0700 From: Stephen Hemminger To: Shani Peretz Cc: , , , Dariusz Sosnowski , Thomas Monjalon , Chenbo Xia , Nipun Gupta , Tyler Retzlaff Subject: Re: [PATCH] eal/common: fix inconsistent representation of PCI numbers Message-ID: <20241004152123.2b5e2cfd@hermes.local> In-Reply-To: <20240701200117.6349-1-shperetz@nvidia.com> References: <20240701200117.6349-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 1 Jul 2024 23:01:17 +0300 Shani Peretz wrote: > +/** > + * General device name comparison. Will compare by using the specific bus > + * compare function or by comparing the names directly. > + * > + * @param dev > + * Device handle. > + * @param name > + * Name to compare against. > + * @return > + * 0 if the device matches the name. Nonzero otherwise. > + */ > +__rte_experimental > +int > +rte_cmp_dev_name(const struct rte_device *dev, const void *name); Why is this not rte_internal instead of experimental? Why is the name arguement void * instead of char *? And there are other questions in the mail thread. That is why it has not gotten accepted.