From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3154C45AAF; Fri, 4 Oct 2024 17:54:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4759442EBC; Fri, 4 Oct 2024 17:51:32 +0200 (CEST) Received: from egress-ip42a.ess.de.barracuda.com (egress-ip42a.ess.de.barracuda.com [18.185.115.201]) by mails.dpdk.org (Postfix) with ESMTP id 2A04F4281D for ; Fri, 4 Oct 2024 17:51:27 +0200 (CEST) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02lp2111.outbound.protection.outlook.com [104.47.11.111]) by mx-outbound8-201.eu-central-1a.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 04 Oct 2024 15:51:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xLm7QRcfi0yxQmq4RmoBDit+Ha7xDiuLm31Tq5Os+6b/YnKXHdEdDKmAZBDzB9OTy8nwHwQshccGfTNM3ftUBMM4ymgjalVPBxayujdM6cmctWnME9OlQUs+EeHx98eMYS41YQH/PF0mnAOWBysC+0N7Oqs0q3JGm/kk86OpMYNi667SG4PmDH2+0m7rTFYfFVmf4WaBup1TmI5Xw7oOJkcy+MZy1E4g+neX2MOsjyNKU+H/yRlfxsibXz0eKSvB+ralw1aT+BnkXZiy+SJQAHrmgWfCRNXkbIkdq7ZzwXjho3aKLx51PcCI/KZ6vFrp+pImYg8SfYCqsS7GPrwN6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=76Z5PdSX5ahAcGWPUhzBAP2hMQNbeRKcAltgsSf2l7w=; b=LqKa79lJcxSWegP/J1CTmEAQFGYNbptVLoHL7K4cmC7W+2AW2rS237zGi/t5FPkl9SVu9kqArhp6gIpUldJsmMsf/gudN94ojlp3Ngk9WMYQeajfwLHfMTd2JJ923UtnOSFoTcuDYTc2941rCMj5pL4tnhj9oOQXPZ5wqEwl+y6ZrJyaqNHabxptuHZiEB7FRYJsJNIVyb2MTJAbvpWmd0vLDiBBvt1guG9c7Muhw9pGCD17kE9NIL/Rq6vl4SYseUOz58QTcbxUyX2Gcq31pnBtsiIdxyAuBlNXy0ZrjPhY06V5gfLIUcv5MUr8xx+4o8U5Ya4u/ePYcJTtpIxfug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 178.72.21.4) smtp.rcpttodomain=dpdk.org smtp.mailfrom=napatech.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=napatech.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=76Z5PdSX5ahAcGWPUhzBAP2hMQNbeRKcAltgsSf2l7w=; b=b5DaJd8gLH8tNczAYSHXK/GuzYaWhX/emSmfFE2zFDA6uFM2ylZs4c3TslcaQp5f/KWv2Tv2b6LpsIRiZ2MElofhlZ/XpapyWw8bS6QTag5DRS+yT4IP178zX4eYeB6JfqXZCKQ1B+7GS6nq5Zp08bsb+8hY9Sb7XKNAMG3hpo0= Received: from AM0PR10CA0103.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::20) by PAXP190MB1767.EURP190.PROD.OUTLOOK.COM (2603:10a6:102:282::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.16; Fri, 4 Oct 2024 15:36:03 +0000 Received: from AM2PEPF0001C715.eurprd05.prod.outlook.com (2603:10a6:208:e6:cafe::f8) by AM0PR10CA0103.outlook.office365.com (2603:10a6:208:e6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.18 via Frontend Transport; Fri, 4 Oct 2024 15:36:03 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 178.72.21.4) smtp.mailfrom=napatech.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=napatech.com; Received-SPF: Fail (protection.outlook.com: domain of napatech.com does not designate 178.72.21.4 as permitted sender) receiver=protection.outlook.com; client-ip=178.72.21.4; helo=localhost.localdomain; Received: from localhost.localdomain (178.72.21.4) by AM2PEPF0001C715.mail.protection.outlook.com (10.167.16.185) with Microsoft SMTP Server id 15.20.7918.13 via Frontend Transport; Fri, 4 Oct 2024 15:36:03 +0000 From: Serhii Iliushyk To: dev@dpdk.org Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com, Oleksandr Kolomeiets Subject: [PATCH v1 4/5] net/ntnic: remove extra calling of the API for release port Date: Fri, 4 Oct 2024 17:34:22 +0200 Message-ID: <20241004153551.267935-5-sil-plv@napatech.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20241004153551.267935-1-sil-plv@napatech.com> References: <20241004153551.267935-1-sil-plv@napatech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM2PEPF0001C715:EE_|PAXP190MB1767:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: fecedb05-ddde-48f5-3350-08dce48a41bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?qbxG62cZq4G09gBJTNQ/orEEhKqpBJb2AQH76puQ+gLIHLFg29ROm9RYGc9I?= =?us-ascii?Q?frHpOWQAJCG4RZcjSsoPw9nfEGAZj/5GHUtlKuDVf2jhRXEkIOeGSf+E0J0x?= =?us-ascii?Q?/GiNE9Qyt+LZ8VmE59BTOx3e5AXKUt3SJZD+PnzE/bmO8dHFJDuwBa1cRYAi?= =?us-ascii?Q?yHhQzd5gr6onTp3XaYCL3sEuZceMRK7GmMBsSakGsW3s19y+sLLxnd/wN+RW?= =?us-ascii?Q?k496oFGCweKyuyJBmQ109XCL6AqGRz87fLLrXPYRrdVij1l7bYU+X1QlOrfP?= =?us-ascii?Q?8kRtZsgIphxsG3DyIeVQmz/XTrjkt4eP2wcCSEzBfZfDS3DUwNE55HA3KwTC?= =?us-ascii?Q?E6JfPWU8C1SZhGSebjGe/tUsUkqguVu6t1i99pP9Jgs5cX5+qIUT386v85ZF?= =?us-ascii?Q?3Oio9nB6r8YpLEeQgba6stAlVk+CdOUQYUpAuQkSncR1I5MZqrwG7DOZr9H1?= =?us-ascii?Q?v0GzrYdBV9bPkMvtHBDzwm1UBryg/TVKdSVPfFYFdyVCjWqBMSB40/Y06bcA?= =?us-ascii?Q?AogU2llJMNJnIJD9wNd5jp8UKXjZugyY8WNJS9qUEccuxPMhAVmTWm36uhm2?= =?us-ascii?Q?PrfaZFIpLwIMDYDZrxjXSAfmTcK8MBT9WMQc0KgDkm/fbZLu6vPaNCSP3ayo?= =?us-ascii?Q?sWURpbXMVMbpO7atcrxooaT3XtvhoGL39Hvyz6kPjgt+Bxa1ysT4F0kjydC6?= =?us-ascii?Q?GKvWuezHrM4BodHiy4K3iNADE3ej33qtJi/Yd+T27T0VyPIECiwSPqzjkRRI?= =?us-ascii?Q?dmHzohb67jsG6l4QL7BFAV197Y5Kfh1BUWgA515MaYNNBytRYHXASKmEhCm8?= =?us-ascii?Q?Gqihs4l+OGffRaRT8+miKhIqY3Hu7DVSyd8Ww/qLIB1qIDYizJ/lgwPSL1bk?= =?us-ascii?Q?DkQJvnB2vzk7tasqnL3FDOwosWwolD+rDvoTlBRosVi/jq2N1HQuJID/0QLe?= =?us-ascii?Q?s0jc/oSfmk6O11gP59BeqqqpSK15hLUe3sPu6nD619RKUh1Di3tyL8atGc0Z?= =?us-ascii?Q?7N+PfIkHuKcWAFvllFdQDWsHeeKNcpdqd1OKai3s60M3HjDfC1aUTcqJ56H7?= =?us-ascii?Q?LWZpah1LDS92z+khKB81PZO2afg81fwBfUMeoJsZXbaa00DfrUByeqLzMDqg?= =?us-ascii?Q?U74bjLq2v3Vu70eBB3+B2Yeir9BPjxdnYgOYMkMz0cImJQgd+AKUAe4nvrRj?= =?us-ascii?Q?e5XhgrTKa4OFhtsv/gVKrQChcjI3hmhx3aP0Br7rKPheEeNwOVMZzDwqyNEr?= =?us-ascii?Q?gPd5Hk0ia0MoWqJhTou2BLQ1+kIfUDzeoMnYLH4hY0ba5p4wqsi4XT0RyF21?= =?us-ascii?Q?Vzwke0Y6vRiRda3qFY0SVKXQPj907EWNCtOTF45V/R96jpc4wf8hgS6FEESM?= =?us-ascii?Q?kU5sywU=3D?= X-Forefront-Antispam-Report: CIP:178.72.21.4; CTRY:DK; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:localhost.localdomain; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: w6VQ9mQ3R/ckKE38K1kiZkvG51fBfAAY1J7/Qa+yIPtns3oSaUPFkgZW012jz9n24LG66QLkIZu/I6y6n8npYcPXeQp25CxDrGjXptPML+vghlDoYwFnKH//3tZEgFF/CldFVLb/akDS4N8MMGTKlOBFVlJv3BD8huT6pKuN3jDsJvXpjWrTGzDNhZVO+0JFZHg+w/8tS0PeE1psKdc1cE53NHhUG2SV7KkZJeulPfrrtu1LLS+IjbHTbZAnnqJqv7qAzp4uf5rQd34FTrdV6dl6jwA2zrtl10Y9iQW3N0mKOaKPkPInabQpansamhffAhG8SlvcB7yU/UOgOzGZxeJS8EnOwP1UzVSWCGu7lenxGtgQfb7RtoCY80LW1zbCsHpuXYpwzenb1ZV2pD7c01xDM7Pr1sAY4H7xDytolMjsB8j/wMWq7GVpbLN6Hl5olZyTuv5MGxguPlNHJ2Bx9nM1K4PRWg3zpOILB1eBbsAoNfY2FbFc7rNcEbNS3iHqmBrrpMWGIVlPT+5vI3cOEOanPWBEwWBM0aZPjusSoUC8v0DvjxzxQvvd4VaEvwi/VGSJv/gD3FaPCMHJU33ONm9faPrV0YaCCobx342GdLmC3IRB8iuR3Bc5WCFGFecjOajidmUpH5pljP0BXLALiQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2024 15:36:03.7053 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fecedb05-ddde-48f5-3350-08dce48a41bc X-MS-Exchange-CrossTenant-Id: c4540d0b-728a-4233-9da5-9ea30c7ec3ed X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c4540d0b-728a-4233-9da5-9ea30c7ec3ed; Ip=[178.72.21.4]; Helo=[localhost.localdomain] X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF0001C715.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP190MB1767 X-OriginatorOrg: napatech.com X-BESS-ID: 1728057086-302249-12641-33886-1 X-BESS-VER: 2019.1_20240924.1654 X-BESS-Apparent-Source-IP: 104.47.11.111 X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVhaWJkBGBlAs1TzV0MLUONE8xc Qy2SzVMDk1zSTVwMjAwtTcxMLMMFWpNhYAwxXAvUAAAAA= X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.259494 [from cloudscan21-181.eu-central-1b.ess.aws.cudaops.com] Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS113687 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Oleksandr Kolomeiets During rte_eth_dev_close execution, eth_dev_close function exported by ntnic is called, followed by a call to rte_eth_dev_release_port. Since there is no possible returns between the calls, calling rte_eth_dev_release_port from eth_dev_close is redundant and error-prone. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/ntnic_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c index f351469d0a..52ca8f2844 100644 --- a/drivers/net/ntnic/ntnic_ethdev.c +++ b/drivers/net/ntnic/ntnic_ethdev.c @@ -383,7 +383,6 @@ eth_dev_close(struct rte_eth_dev *eth_dev) internals->p_drv = NULL; - rte_eth_dev_release_port(eth_dev); if (p_drv) { /* decrease initialized ethernet devices */ p_drv->n_eth_dev_init_count--; -- 2.45.0