From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86E6045AAF; Fri, 4 Oct 2024 18:26:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A33F42F0B; Fri, 4 Oct 2024 18:25:26 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 3768042EE8 for ; Fri, 4 Oct 2024 18:25:23 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 494E9B82021820; Fri, 4 Oct 2024 09:25:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=c 13fXHZ34rN77eGwc3DyZ9CkfZsQ5H5szzRQWEy+4jE=; b=L68OsFu8HNeh/K+l6 YngTCRvtN0CQuA3g9lVso2UvgBHlensZiKeXf2D7BM3Z8AtX6+sPNw+SyGH5Lb6B UoAhEHrD2i1NqahUJyzfwwkBOzR0q2VKzc3Lx1ghUAkY1CzEFxP7rvHBhKa/V48p oQjjicz24oqtFW4Q6V2c6E0b86U11atsflgKmHi0oSBT6mP3Ina8h9l1NpaGzpG9 4o4axXvhXJJxPrX5UPitkLDVv8mZ+tH4Ca+AAYLL0R03yUZE+4mrP9vhE8V6QrPJ ez+vFIlja7sPQV9wZFpn6J9avK1CQZrPxI7tHOq8o6Y1R9CYUxkj0Q+WflIQJS+v i8xYg== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 42204tj99m-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Oct 2024 09:25:22 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 4 Oct 2024 09:25:11 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Fri, 4 Oct 2024 09:25:11 -0700 Received: from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com [10.28.164.106]) by maili.marvell.com (Postfix) with ESMTP id 90D9F3F7081; Fri, 4 Oct 2024 09:25:07 -0700 (PDT) From: To: , , , , , , , , CC: , Pavan Nikhilesh Subject: [PATCH v5 3/6] eventdev: add event preschedule hint Date: Fri, 4 Oct 2024 21:54:48 +0530 Message-ID: <20241004162451.6842-4-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241004162451.6842-1-pbhagavatula@marvell.com> References: <20241001131901.7920-1-pbhagavatula@marvell.com> <20241004162451.6842-1-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: s-rxs6wH9awzR4gCmq357l8FqIpuU0yl X-Proofpoint-GUID: s-rxs6wH9awzR4gCmq357l8FqIpuU0yl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Add a new eventdev API to provide a hint to the eventdev PMD to pre-schedule the next event into the event port, without releasing the current flow context. Event device that support this feature advertises the capability using the RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT capability flag. Application can invoke `rte_event_port_preschedule` to hint the PMD, if event device does not support this feature it is treated as a no-op. Signed-off-by: Pavan Nikhilesh --- doc/guides/prog_guide/eventdev/eventdev.rst | 9 ++++ doc/guides/rel_notes/release_24_11.rst | 3 +- lib/eventdev/eventdev_pmd.h | 2 + lib/eventdev/eventdev_private.c | 21 ++++++++- lib/eventdev/eventdev_trace_points.c | 3 ++ lib/eventdev/rte_eventdev.h | 50 +++++++++++++++++++++ lib/eventdev/rte_eventdev_core.h | 8 +++- lib/eventdev/rte_eventdev_trace_fp.h | 8 ++++ lib/eventdev/version.map | 2 + 9 files changed, 102 insertions(+), 4 deletions(-) diff --git a/doc/guides/prog_guide/eventdev/eventdev.rst b/doc/guides/prog_guide/eventdev/eventdev.rst index 26e77166d5..56d62d260a 100644 --- a/doc/guides/prog_guide/eventdev/eventdev.rst +++ b/doc/guides/prog_guide/eventdev/eventdev.rst @@ -395,6 +395,15 @@ will be a no-op in that case. // Disable pre-scheduling if thread is about to be scheduled out and issue dequeue() to drain // pending events. +Application may provide a hint to the eventdev PMD to pre-schedule the next event without +releasing the current flow context. Event device that support this feature advertises +the capability via the ``RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT`` flag. +If pre-scheduling is already enabled at a event device or event port level or if the +capability is not supported then the hint is ignored. + +.. code-block:: c + + rte_event_port_preschedule(dev_id, port_id, RTE_EVENT_PRESCHEDULE); Starting the EventDev ~~~~~~~~~~~~~~~~~~~~~ diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst index cae594096c..3a41263b8b 100644 --- a/doc/guides/rel_notes/release_24_11.rst +++ b/doc/guides/rel_notes/release_24_11.rst @@ -64,7 +64,8 @@ New Features level pre-scheduling type. * Added ``rte_event_port_preschedule_modify`` to modify pre-scheduling type on a given event port. - + * Added ``rte_event_port_preschedule`` to allow applications provide explicit + pre-schedule hints to event ports. Removed Items ------------- diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h index 9ea23aa6cd..0bee2347ef 100644 --- a/lib/eventdev/eventdev_pmd.h +++ b/lib/eventdev/eventdev_pmd.h @@ -186,6 +186,8 @@ struct __rte_cache_aligned rte_eventdev { /**< Pointer to PMD Event switch profile function. */ event_preschedule_modify_t preschedule_modify; /**< Pointer to PMD Event port pre-schedule type modify function. */ + event_preschedule_t preschedule; + /**< Pointer to PMD Event port pre-schedule function. */ uint64_t reserved_64s[3]; /**< Reserved for future fields */ void *reserved_ptrs[3]; /**< Reserved for future fields */ diff --git a/lib/eventdev/eventdev_private.c b/lib/eventdev/eventdev_private.c index cc5963b31b..b628f4a69e 100644 --- a/lib/eventdev/eventdev_private.c +++ b/lib/eventdev/eventdev_private.c @@ -111,6 +111,19 @@ dummy_event_port_preschedule_modify_hint( return -ENOTSUP; } +static void +dummy_event_port_preschedule(__rte_unused void *port, + __rte_unused enum rte_event_dev_preschedule_type preschedule) +{ + RTE_EDEV_LOG_ERR("pre-schedule requested for unconfigured event device"); +} + +static void +dummy_event_port_preschedule_hint(__rte_unused void *port, + __rte_unused enum rte_event_dev_preschedule_type preschedule) +{ +} + void event_dev_fp_ops_reset(struct rte_event_fp_ops *fp_op) { @@ -124,12 +137,12 @@ event_dev_fp_ops_reset(struct rte_event_fp_ops *fp_op) .dequeue_burst = dummy_event_dequeue_burst, .maintain = dummy_event_maintain, .txa_enqueue = dummy_event_tx_adapter_enqueue, - .txa_enqueue_same_dest = - dummy_event_tx_adapter_enqueue_same_dest, + .txa_enqueue_same_dest = dummy_event_tx_adapter_enqueue_same_dest, .ca_enqueue = dummy_event_crypto_adapter_enqueue, .dma_enqueue = dummy_event_dma_adapter_enqueue, .profile_switch = dummy_event_port_profile_switch, .preschedule_modify = dummy_event_port_preschedule_modify, + .preschedule = dummy_event_port_preschedule, .data = dummy_data, }; @@ -153,8 +166,12 @@ event_dev_fp_ops_set(struct rte_event_fp_ops *fp_op, fp_op->dma_enqueue = dev->dma_enqueue; fp_op->profile_switch = dev->profile_switch; fp_op->preschedule_modify = dev->preschedule_modify; + fp_op->preschedule = dev->preschedule; fp_op->data = dev->data->ports; if (fp_op->preschedule_modify == NULL) fp_op->preschedule_modify = dummy_event_port_preschedule_modify_hint; + + if (fp_op->preschedule == NULL) + fp_op->preschedule = dummy_event_port_preschedule_hint; } diff --git a/lib/eventdev/eventdev_trace_points.c b/lib/eventdev/eventdev_trace_points.c index e41674123c..e7af1591f7 100644 --- a/lib/eventdev/eventdev_trace_points.c +++ b/lib/eventdev/eventdev_trace_points.c @@ -52,6 +52,9 @@ RTE_TRACE_POINT_REGISTER(rte_eventdev_trace_port_profile_switch, RTE_TRACE_POINT_REGISTER(rte_eventdev_trace_port_preschedule_modify, lib.eventdev.port.preschedule.modify) +RTE_TRACE_POINT_REGISTER(rte_eventdev_trace_port_preschedule, + lib.eventdev.port.preschedule) + /* Eventdev Rx adapter trace points */ RTE_TRACE_POINT_REGISTER(rte_eventdev_trace_eth_rx_adapter_create, lib.eventdev.rx.adapter.create) diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h index d7920bfba0..ffce2ee0d9 100644 --- a/lib/eventdev/rte_eventdev.h +++ b/lib/eventdev/rte_eventdev.h @@ -480,6 +480,15 @@ struct rte_event; * @see rte_event_port_preschedule_modify() */ +#define RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT (1ULL << 19) +/**< Event device supports explicit prescheduling. + * + * When this flag is set, the application can issue preschedule request on + * a event port. + * + * @see rte_event_port_preschedule() + */ + /* Event device priority levels */ #define RTE_EVENT_DEV_PRIORITY_HIGHEST 0 /**< Highest priority level for events and queues. @@ -2983,6 +2992,47 @@ rte_event_port_preschedule_modify(uint8_t dev_id, uint8_t port_id, return fp_ops->preschedule_modify(port, type); } +/** + * Provide a hint to the event device to pre-schedule events to event port . + * + * Hint the event device to pre-schedule events to the event port. + * The call doesn't not guarantee that the events will be pre-scheduleed. + * The call doesn't release the flow context currently held by the event port. + * The event device should support RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT capability. + * + * When pre-scheduling is enabled at an event device/port level or if + * the capability is not supported, then the hint is ignored. + * + * Subsequent calls to rte_event_dequeue_burst() will dequeue the pre-schedule + * events but pre-schedule operation is not issued again. + * + * @param dev_id + * The identifier of the device. + * @param port_id + * The identifier of the event port. + * @param type + * The pre-schedule type to use on the event port. + */ +static inline void +rte_event_port_preschedule(uint8_t dev_id, uint8_t port_id, + enum rte_event_dev_preschedule_type type) +{ + const struct rte_event_fp_ops *fp_ops; + void *port; + + fp_ops = &rte_event_fp_ops[dev_id]; + port = fp_ops->data[port_id]; + +#ifdef RTE_LIBRTE_EVENTDEV_DEBUG + if (dev_id >= RTE_EVENT_MAX_DEVS || port_id >= RTE_EVENT_MAX_PORTS_PER_DEV) + return; + if (port == NULL) + return; +#endif + rte_eventdev_trace_port_preschedule(dev_id, port_id, type); + + fp_ops->preschedule(port, type); +} #ifdef __cplusplus } #endif diff --git a/lib/eventdev/rte_eventdev_core.h b/lib/eventdev/rte_eventdev_core.h index 5f4c25b1c5..2706d5e6c8 100644 --- a/lib/eventdev/rte_eventdev_core.h +++ b/lib/eventdev/rte_eventdev_core.h @@ -53,6 +53,10 @@ typedef int (*event_preschedule_modify_t)(void *port, enum rte_event_dev_preschedule_type preschedule_type); /**< @internal Modify pre-schedule type on the event port. */ +typedef void (*event_preschedule_t)(void *port, + enum rte_event_dev_preschedule_type preschedule_type); +/**< @internal Issue pre-schedule on an event port. */ + struct __rte_cache_aligned rte_event_fp_ops { void **data; /**< points to array of internal port data pointers */ @@ -82,7 +86,9 @@ struct __rte_cache_aligned rte_event_fp_ops { /**< PMD Event switch profile function. */ event_preschedule_modify_t preschedule_modify; /**< PMD Event port pre-schedule switch. */ - uintptr_t reserved[3]; + event_preschedule_t preschedule; + /**< PMD Event port pre-schedule. */ + uintptr_t reserved[2]; }; extern struct rte_event_fp_ops rte_event_fp_ops[RTE_EVENT_MAX_DEVS]; diff --git a/lib/eventdev/rte_eventdev_trace_fp.h b/lib/eventdev/rte_eventdev_trace_fp.h index 78baed94de..8290f8a248 100644 --- a/lib/eventdev/rte_eventdev_trace_fp.h +++ b/lib/eventdev/rte_eventdev_trace_fp.h @@ -63,6 +63,14 @@ RTE_TRACE_POINT_FP( rte_trace_point_emit_int(type); ) +RTE_TRACE_POINT_FP( + rte_eventdev_trace_port_preschedule, + RTE_TRACE_POINT_ARGS(uint8_t dev_id, uint8_t port_id, int type), + rte_trace_point_emit_u8(dev_id); + rte_trace_point_emit_u8(port_id); + rte_trace_point_emit_int(type); +) + RTE_TRACE_POINT_FP( rte_eventdev_trace_eth_tx_adapter_enqueue, RTE_TRACE_POINT_ARGS(uint8_t dev_id, uint8_t port_id, void *ev_table, diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map index b6d63ba576..42a5867aba 100644 --- a/lib/eventdev/version.map +++ b/lib/eventdev/version.map @@ -151,6 +151,8 @@ EXPERIMENTAL { # added in 24.11 rte_event_port_preschedule_modify; __rte_eventdev_trace_port_preschedule_modify; + rte_event_port_preschedule; + __rte_eventdev_trace_port_preschedule; }; INTERNAL { -- 2.25.1