From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F25E945A81; Sat, 5 Oct 2024 18:11:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79879402DF; Sat, 5 Oct 2024 18:11:40 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 50550402C8 for ; Sat, 5 Oct 2024 18:11:38 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-71dfccba177so57466b3a.0 for ; Sat, 05 Oct 2024 09:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728144697; x=1728749497; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=v4q4v1mfeiFetLjzRSY+3rJPt3/UNlNK8Cyfg/rmna4=; b=nPf9po5ruc5/pKNx7bWfZNfLnoBMozvBadzrMqb5kdvk1UNWdmJQV0XvO4oHl6uXNv 2hRq2qCL75llXxDPkkvrm4JudY4YoaGTQe2DoJLSvAb8oOwOgb2XSGR0x0J1NetyP667 +5OrFrSAp0Ztvw4PaPjNaLBAHFX4mIdVYxRywTEcNiYDd4FcEmc0wO5oWPyd0KaIcq+I GolTPnwslMtq+xZZ73OwsRAJeQC5lWwAkVITLCU30NBDNKVyZmU1tTpT2MTpWGftB69p ZDYG6KwU+3H60u6F7hoNxLFlDGzyMmmThS/+Re4d2TG6IievTXoT7p8cH+SXKiZOY0u/ lJig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728144697; x=1728749497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v4q4v1mfeiFetLjzRSY+3rJPt3/UNlNK8Cyfg/rmna4=; b=OjrVoXCDFSWuNqYnrs+Ye4Kc3x+fP829NJ1JhWJ+lB5u90CBhuoP+R34Qb6dB6Q3sL nukS4MmhYEKooV166KZw391VSQYdw3gTwJ+xPCM45UGXTpoMoscVvqdUUYposfNNJxD7 xk0sFkGpylziK2pu9ufMgg54r7WxpXWuCFB5/hMEipwq4Z2RSMUVOuuuMXEYQNBXbWeC 3d0MY4Aw2VBJA7aVSOwliA+sATFGB/l4W1a48zDUDEpYcmIFKsvzYMDEGsvX/9iFDHJa 5Pl7z7EN41JAm+eCaut/EWfxhWy3pTt+C0oN2Z11oxbNrzrTsRwz/1mSXMQaq+xNuh+X NWjQ== X-Forwarded-Encrypted: i=1; AJvYcCU/P2wxxnKFdfutawfbdj8C3EouodxeQyZOc3+QCiBZBvrnLO+5wkkml0kQqd8GnNjAl8E=@dpdk.org X-Gm-Message-State: AOJu0YzJWr62c+bIO2jsdHikH7zVQrAR3PU9lwQPlWxC0CsOJu7EDsu2 znuWXijG0dO4LDw5iKiOjReyrCeFfpnuVVM6k3IgeCrTumbUiUy08fwQp9kjddU= X-Google-Smtp-Source: AGHT+IHWvjM4FemCzjjY/L/vOs3jpNlbmzyIZ8l3Hxgmd3UvaNERoOWs+Gu4gF/sO0e1AjVHpoatgw== X-Received: by 2002:a05:6a20:4391:b0:1d5:1250:44b4 with SMTP id adf61e73a8af0-1d6e039001emr9628890637.24.1728144697262; Sat, 05 Oct 2024 09:11:37 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9f682c801sm1902804a12.39.2024.10.05.09.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2024 09:11:37 -0700 (PDT) Date: Sat, 5 Oct 2024 09:11:35 -0700 From: Stephen Hemminger To: Cc: , , , , , , , , , Subject: Re: [PATCH v7 1/6] eventdev: introduce event pre-scheduling Message-ID: <20241005091135.37b0ee46@hermes.local> In-Reply-To: <20241005080001.8681-2-pbhagavatula@marvell.com> References: <20241005072600.7962-1-pbhagavatula@marvell.com> <20241005080001.8681-1-pbhagavatula@marvell.com> <20241005080001.8681-2-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 5 Oct 2024 13:29:56 +0530 wrote: > +static int > +preschedule_test(enum rte_event_dev_preschedule_type preschedule_type, const char *preschedule_name) > +{ > +#define NB_EVENTS 1024 > + uint64_t start, total; > + struct rte_event ev; > + int rc, cnt; > + > + ev.event_type = RTE_EVENT_TYPE_CPU; > + ev.queue_id = 0; > + ev.op = RTE_EVENT_OP_NEW; > + ev.u64 = 0xBADF00D0; > + > + for (cnt = 0; cnt < NB_EVENTS; cnt++) { > + ev.flow_id = cnt; > + rc = rte_event_enqueue_burst(TEST_DEV_ID, 0, &ev, 1); > + TEST_ASSERT(rc == 1, "Failed to enqueue event"); > + } > + > + RTE_SET_USED(preschedule_type); If you respin this patch. My preference is to use the __rte_unused attribute in the function declaration rather RTE_SET_USED(), mainly because it makes it more obvious in the start of the function.