From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5E64F45AD9;
	Mon,  7 Oct 2024 23:25:38 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 25A634060C;
	Mon,  7 Oct 2024 23:25:38 +0200 (CEST)
Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com
 [209.85.214.169])
 by mails.dpdk.org (Postfix) with ESMTP id 1EB2B400D7
 for <dev@dpdk.org>; Mon,  7 Oct 2024 23:25:37 +0200 (CEST)
Received: by mail-pl1-f169.google.com with SMTP id
 d9443c01a7336-20bcae5e482so42906805ad.0
 for <dev@dpdk.org>; Mon, 07 Oct 2024 14:25:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728336336;
 x=1728941136; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=9GB0+T+qugPaJfYC7uJ0HS/gX6Dip4bGac/BYbhPVHk=;
 b=PBoF0ddzRYIZ1+Dqii04JswlxYn0oegvfYjEo0JJaF3CuT0GrLkXkf37WDsqhmbZsH
 9fK1jms5EGczYw8u6cm2rQN+rcoyRVKzzMRkEvvdhEKiTVZyBJ80g5Z6nCHPP8NuwuVW
 X290e6HXAVlCxBhDFxesBVRyzaDfH91RvQXVHIyUyyrn/Fvftw+WeGscHLh/yA/awlkN
 OijdKqxXc0sSVkn8uJOO/jZfkO3k5auRLljoU9NOpdblJhaRldL+U1JfnLQQeE9ps7pl
 2o/dWA4jKCvITck+G3REq2JcV3wpmmBM3xPuzC6gi5xibSPJW54We5TmzmYmExAG5CJk
 3NYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1728336336; x=1728941136;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=9GB0+T+qugPaJfYC7uJ0HS/gX6Dip4bGac/BYbhPVHk=;
 b=MGan34UGZClNs+hTzwpLIuSEtkd2gAwJoaDSEDhHTgQqZPpk0VcX7vZyUqkyQxe5dJ
 bgax33Iw7sbFMX6xRttjDNeQxS1rDUyHmyjlqm42qV+u/PVAQVTOP0/DDZ6RA4GQQWs/
 vgD/xihvl607Rlte3l1L/IP5Ujkp4tSzGezAGb+8WkqWK1YNFDVd80SDuzvl4Dx6E9kB
 9bwQS9U69oy5TrtJ+7VebwHozGBSmgmOHgFFdiRR7m99pWte72CCIFZd9JUeJiHIfp6g
 FmhWO4tW+fOmHfttx4aK2Rt1C6h/SOdyi2XnPpeEfXbjniBJBci6ZAOnqzk/GeArFxx3
 OGvg==
X-Gm-Message-State: AOJu0YzjSjhoCgGavYHAaH/mDfBi3sxgWjZSvFDDsEogv4E8ACos4Mlb
 7y74jHV07NxR6OyRRKMGrPI3C3gmbOqXtjUIpHiGA1jBpzuVMxftNAA1ANOnfBA=
X-Google-Smtp-Source: AGHT+IG+DOWuHjyV66highhwnpjN5vv+hbh10skQkx+yd/OBGGWRSWkAoa2I/E/x2ZlM6LXit0QN7Q==
X-Received: by 2002:a17:903:185:b0:205:841d:122d with SMTP id
 d9443c01a7336-20bfe193471mr192727415ad.26.1728336334638; 
 Mon, 07 Oct 2024 14:25:34 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-20c13968ddasm43517395ad.214.2024.10.07.14.25.33
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 07 Oct 2024 14:25:34 -0700 (PDT)
Date: Mon, 7 Oct 2024 14:25:32 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Howard Wang <howard_wang@realsil.com.cn>
Cc: <dev@dpdk.org>, <pro_nic_dpdk@realtek.com>
Subject: Re: [PATCH v2] r8125: add r8125 ethernet poll mode driver
Message-ID: <20241007142532.3048e218@hermes.local>
In-Reply-To: <20240612095145.5760-1-howard_wang@realsil.com.cn>
References: <20240612095145.5760-1-howard_wang@realsil.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, 12 Jun 2024 17:51:45 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:

> r8125 is for Realtek 2.5 Gigabit Ethernet NICs.
> 
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
> ---

To echo what Ferruh mentioned.
 1. Break the driver into more easily reviewed pieces.
 2. Run checkpatch, there are lots of style problems still in both drivers.

There is a new driver writers guideline document that might help you.