From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7568F45AD9; Mon, 7 Oct 2024 23:28:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 074214060C; Mon, 7 Oct 2024 23:28:57 +0200 (CEST) Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by mails.dpdk.org (Postfix) with ESMTP id 097E3400D7 for <dev@dpdk.org>; Mon, 7 Oct 2024 23:28:55 +0200 (CEST) Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6cb2e5d0104so35665116d6.3 for <dev@dpdk.org>; Mon, 07 Oct 2024 14:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728336534; x=1728941334; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=b7soiXjlY42RaSOSjUBU2qsoJyTk/t1BlzrxtSG0HT4=; b=RdAkV7OxDdgdh+IIsJ8/eLYWoJ3ttYmc3dYk2NSyswepUerjamvd0pc01NG0IPexsU EZrTebHwJXHYvq2k9CnFnX/MPDceXX7Bj8nOJNoU4WW4OdhENuE5nfj5NEu+vdUu4NSC YvJ5LQgdgmB9H0nONccArqquryjACd0Efo4Tex/IT8DD/uwb4jo4lQCav5WEH3jUhN0v 49c0yoqMM6G1CjVCLoF7BHQPVkF1QWcrW8rBkKsqAiJa8gz9DVMKVC1gHCHwK8DlpSB/ /EugmDwo8+8/wrDHPKUnzZgGtqlKZvbpsrF++GBjJZOZ0gJDiNyXstK1X3cEqqoQPFpn 39ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728336534; x=1728941334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b7soiXjlY42RaSOSjUBU2qsoJyTk/t1BlzrxtSG0HT4=; b=R1+IsF5Sb2Ord+4wznlx5yffB1dtQ0KqN4ypHqhtXlze3kflno7jwVFovTC9Oxzuym 3LbfRBC23aJ2hf+lIVPSSQI+GvzJyW/o7YodrAnTUbq+RipwRlpO47wFZSnYbX0+VtO7 F+EE126BCJq6Ec/8ebILHkO8OYrLLvtZseLbBcW5ZyrEPIQIPLZ1k5Gbu4nRBSh1X3tp uRJr1BoS3mpuFd3k0kHBfQVIb0kk9Xiq+XIkCi7iZD+uCZh2P/quVwCK5I+QSKF2PnAk pmH+VqfF+hsupLBH6PiqGEVo432KSDvW6+BsHzSs28QBZGDU5vmIC65kqmqFmb6Bi/Rk qF4w== X-Forwarded-Encrypted: i=1; AJvYcCVOCsWq49cAU7S3UpD2ypBXYdKjB0Bwumvd4wD260F2fcEo0JhXHKjsNPF87LKb9JmO2vc=@dpdk.org X-Gm-Message-State: AOJu0YwdlWb+FmG0Ec4KY/OE9fp2OGxDcDr4Buy0swM10TRGkmHpsxQh d0flpW0O0h8PRRx1X7nozDj0pzdsp8UCFyqqI1BhbuUMZoG4PktTls3H7Az0wwM= X-Google-Smtp-Source: AGHT+IGIpd/5CGjmFL8YN5GdlsYNBQSIYq7tyEvI3i9KQU+v1RWQdIedyPp+aZsCAntDXpS4sKNCSQ== X-Received: by 2002:a05:6214:5709:b0:6cb:46ce:744a with SMTP id 6a1803df08f44-6cb9a4fa3b0mr171416886d6.48.1728336534279; Mon, 07 Oct 2024 14:28:54 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba4772e70sm29205176d6.133.2024.10.07.14.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 14:28:54 -0700 (PDT) Date: Mon, 7 Oct 2024 14:28:50 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Vipin Varghese <vipin.varghese@amd.com> Cc: <ferruh.yigit@amd.com>, <dev@dpdk.org> Subject: Re: [RFC 0/2] introduce LLC aware functions Message-ID: <20241007142850.4852a1fa@hermes.local> In-Reply-To: <20240827151014.201-1-vipin.varghese@amd.com> References: <20240827151014.201-1-vipin.varghese@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, 27 Aug 2024 20:40:12 +0530 Vipin Varghese <vipin.varghese@amd.com> wrote: > As core density continues to increase, chiplet-based > core packing has become a key trend. In AMD SoC EPYC > architectures, core complexes within the same chiplet > share a Last-Level Cache (LLC). By packing logical cores > within the same LLC, we can enhance pipeline processing > stages due to reduced latency and improved data locality. > > To leverage these benefits, DPDK libraries and examples > can utilize localized lcores. This approach ensures more > consistent latencies by minimizing the dispersion of lcores > across different chiplet complexes and enhances packet > processing by ensuring that data for subsequent pipeline > stages is likely to reside within the LLC. > > < Function: Purpose > > --------------------- > - rte_get_llc_first_lcores: Retrieves all the first lcores in the shared LLC. > - rte_get_llc_lcore: Retrieves all lcores that share the LLC. > - rte_get_llc_n_lcore: Retrieves the first n or skips the first n lcores in the shared LLC. > > < MACRO: Purpose > > ------------------ > RTE_LCORE_FOREACH_LLC_FIRST: iterates through all first lcore from each LLC. > RTE_LCORE_FOREACH_LLC_FIRST_WORKER: iterates through all first worker lcore from each LLC. > RTE_LCORE_FOREACH_LLC_WORKER: iterates lcores from LLC based on hint (lcore id). > RTE_LCORE_FOREACH_LLC_SKIP_FIRST_WORKER: iterates lcores from LLC while skipping first worker. > RTE_LCORE_FOREACH_LLC_FIRST_N_WORKER: iterates through `n` lcores from each LLC. > RTE_LCORE_FOREACH_LLC_SKIP_N_WORKER: skip first `n` lcores, then iterates through reaming lcores in each LLC. > > Vipin Varghese (2): > eal: add llc aware functions > eal/lcore: add llc aware for each macro > > lib/eal/common/eal_common_lcore.c | 279 ++++++++++++++++++++++++++++-- > lib/eal/include/rte_lcore.h | 89 ++++++++++ When are you going to send a new version? Need: - new functions need to be marked experimental - has to build cleanly on all platforms. - need functional tests - address all the other review comments