From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9422745AE8; Tue, 8 Oct 2024 23:09:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CF2B406B7; Tue, 8 Oct 2024 23:09:15 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id BE8F140668 for ; Tue, 8 Oct 2024 23:09:13 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20b5fb2e89dso48677245ad.1 for ; Tue, 08 Oct 2024 14:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728421753; x=1729026553; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Q5rh5e183XIpzOEkvWLnUi6I+VTUGwMHOjPwRE8gf0A=; b=NxIrj6W5MTk7OVWQD56H4McLv0jK234Ifid8IZtyL3pPPtlMDy3Wefp5VS+gGhFOeY QQUTLNfoTsKgQVvqiXwVMp3aMLJcTp1qfFr9vQ5YUz4ehcGB1kq12BkI3vOGBSvtJp7o 9+WdSTc2vZKjZK7sBKYaAFs9roufq9J7Pa29TzwZe6VQYYcOrjjTV1vY1gOfsj3C7BMf ZUanPiXcc0W+6OUzcJ74J1MI+wOK6vCbvQ0k4ZrIzEZOgDjaTsLqA/GgYUW9obiJRCsT gojjE8ZSQInoZ2G9Ovy6xvaKV0KH0i9Y7Nda/SH6u0d3syv5wBm8IVNUAXw6TcK0gsBt 8CtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728421753; x=1729026553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q5rh5e183XIpzOEkvWLnUi6I+VTUGwMHOjPwRE8gf0A=; b=uaLVIsE1vFu+BkTHOe4sg31L7X8mhG7H9YgGcJxLK5vLl5if/rL731RC7Rk12GjAZi 846SYE1EBfRN+CDT4HJJyEdYZc+m+w83LdkY8wPgiFFOD6LE16FdmCW9C+Ayja2V/wX4 6q7IB0xzxjwxZIdYNz40or+5IlmvpfHsLLKdc0R9dEM9th5uA3zDJ5YtV30hufQLwfSn twoQAh928mz3r4dJZqxgVwbQFzJy5a2yQQM6uSTDVDM1Pe0Tv//2f94NW1hxguuskDfZ eATy+muO8KMDUw2d+HpZ75cZgHiAth+AYdN5avREvwkE8iMUqBrhO7/C98GYVFJtfUe2 T8BA== X-Gm-Message-State: AOJu0YwPDAuRv4tCqtUXln7408Wn/9JUig2vGsj4Pv42/MS/tnklQUJH 0fFcU5g2RbQD2gp5XqoATqBKlHumde2J+E2vyhyKz17+Kza2+A4GTZZCbA4PMrc= X-Google-Smtp-Source: AGHT+IGeDrg4fvhncVQUqOBjHqnfSlRdrra3v0amAhUngqSoYC9bI5N2t9eSCCJjjpeXNAseKmBz7w== X-Received: by 2002:a17:902:e892:b0:20c:62e1:6361 with SMTP id d9443c01a7336-20c6374101cmr4756155ad.25.1728421752814; Tue, 08 Oct 2024 14:09:12 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c138b1395sm59629025ad.3.2024.10.08.14.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 14:09:12 -0700 (PDT) Date: Tue, 8 Oct 2024 14:09:10 -0700 From: Stephen Hemminger To: "Kusztal, ArkadiuszX" Cc: "dev@dpdk.org" , "gakhil@marvell.com" , "Dooley, Brian" Subject: Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op Message-ID: <20241008140910.1cd601e7@hermes.local> In-Reply-To: References: <20241008062845.11071-1-arkadiuszx.kusztal@intel.com> <20241008181433.57591-1-arkadiuszx.kusztal@intel.com> <20241008181433.57591-3-arkadiuszx.kusztal@intel.com> <20241008134626.282bf9f3@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 8 Oct 2024 21:00:50 +0000 "Kusztal, ArkadiuszX" wrote: > Hi Stephen, > > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Tuesday, October 8, 2024 10:46 PM > > To: Kusztal, ArkadiuszX > > Cc: dev@dpdk.org; gakhil@marvell.com; Dooley, Brian > > > > Subject: Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op > > > > On Tue, 8 Oct 2024 19:14:31 +0100 > > Arkadiusz Kusztal wrote: > > > > > + RTE_CRYPTO_SM2_PARTIAL, > > > + /**< > > > + * PMD does not support the full process of the > > > + * SM2 encryption/decryption, but the elliptic > > > + * curve part only > > > > Couldn't this just be: > > /**< PMD only supports elliptic curve */ > > SM2 encryption involves several steps: random number generation, hashing, some trivial xor's etc, and calculation of elliptic curve points, what I meant here is that only this EC calculation will be performed. > But when I read it now, I probably may need to add some more clarity to it. My point is what developers write tends to be overly wordy and redundant. Comments and documentation should be as succinct as possible.