From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BAE545AA2; Tue, 8 Oct 2024 23:26:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BA8B406B7; Tue, 8 Oct 2024 23:26:40 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 66C1D40656 for ; Tue, 8 Oct 2024 23:26:38 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20b8be13cb1so65633535ad.1 for ; Tue, 08 Oct 2024 14:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728422797; x=1729027597; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qgllJkJbFvYHVeeS7K8oaLbGL1E3sUVN4yQaO3NR5b4=; b=T5OhPK7vZvpKdkXUul5NF1eEzaaKzhOezQsfr32cBNYktrjDXGP6WqF4dKCtiJvc/Q HUwOKn/WYHvyxxFGwMHW5/s6Bxp6ULQzkudYW3veIjSGSmfoVo583u7ClWIcJah1Iibb WS6MCXEP84hKUmy5Xl7aXD4wp487qPUgXtjq94NZdVlUj7aXJu0za3eHLTm9EcJxl9x/ 6UTweXVkzeP0DH2nE3CSP4rYF8y4VuSvw4KFIRyvWe/ltcgLsKNMLwD3Z5qQpEn+ZVNp EPnQY5GlfZTphHmLPqLgVQ5I/DVKq73GxfYZ5ynkGtr1gwKhXSmndiYPg24TPqzJpMjM 9sPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728422797; x=1729027597; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qgllJkJbFvYHVeeS7K8oaLbGL1E3sUVN4yQaO3NR5b4=; b=n2ht3mh1EernqyqIVV7Q5A5mQ1QDRTWTy654l6DDklJgXBb+c5Jv0mTPaS9nvQP/wU mw/xHfCovPBEUNBgmoq7w7geTIw+wUV7Xl6USTGpGecw+VfjlhZrKoZYKF7HNQfAXhzp oAuLeciQnT7tpq3Wv45vJ1ZZuhbsbBRMoWW+lEeyuv+MO9Q4PemgYL77P+9AXQ25hsAu i5yrGSnxgHnkXyuxxmegqVIjPwLib9W4/X6Z68OFFvruqpBsjIMgnFPmhb3r3fVDahtE zuBQ2v2TGJqmDOXoKfUf8ODigxiacibaCLUbX1SfclEXbWgxQCz4Om1Jzd8NTRCLYVH8 s0yg== X-Gm-Message-State: AOJu0YwMNEXPsMDfaO3hxdGpulI0MI1ynW5E0EzNPUmdLNo2e9x3n7bu Q8CrLqg7n/FrJP2TJIkSj1gbl+Hou3b8V1tUYwgwDhMAxpyfxBJ91OM1StCGJLc= X-Google-Smtp-Source: AGHT+IHMderkq9YWNrI2JnnkY0M5BE7i/g/s+x+rEWhOjgvjstAm6LFnMo0L8hQ6MfpaUSI818MLJA== X-Received: by 2002:a17:902:d2c6:b0:20b:bd8d:427c with SMTP id d9443c01a7336-20c6377b26emr6181575ad.23.1728422797463; Tue, 08 Oct 2024 14:26:37 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c13969461sm59330755ad.219.2024.10.08.14.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 14:26:37 -0700 (PDT) Date: Tue, 8 Oct 2024 14:26:35 -0700 From: Stephen Hemminger To: Vladimir Medvedkin Cc: dev@dpdk.org, rjarry@redhat.com, mb@smartsharesystems.com, david.marchand@redhat.com Subject: Re: [PATCH v2] fib: network byte order IPv4 lookup Message-ID: <20241008142635.44ab256b@hermes.local> In-Reply-To: <20241008171605.378069-1-vladimir.medvedkin@intel.com> References: <20241008171605.378069-1-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 8 Oct 2024 17:16:05 +0000 Vladimir Medvedkin wrote: > Previously when running rte_fib_lookup IPv4 addresses must have been in > host byte order. >=20 > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on > fib create, which will allow to have IPv4 in network byte order on > lookup. >=20 > Signed-off-by: Vladimir Medvedkin > --- github build failed with this. FAILED: lib/76b5a35@@rte_fib at sta/fib_dir24_8.c.o=20 ccache gcc -Ilib/76b5a35@@rte_fib at sta -Ilib -I../lib -Ilib/fib -I../lib/= fib -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -= Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I.= ./lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../l= ib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/telemetry/= ../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry= -Ilib/rib -I../lib/rib -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/= ring -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Win= valid-pch -Wextra -Werror -std=3Dc11 -O2 -g -include rte_config.h -Wcast-qu= al -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-de= clarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wp= ointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wn= o-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initi= alizers -Wno-zero-length-bounds -Wno-pointer-to-int-cast -D_GNU_SOURCE -m32= -fPIC -march=3Dcorei7 -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API = -Wno-format-truncation -DRTE_LOG_DEFAULT_LOGTYPE=3Dlib.fib -MD -MQ 'lib/76b= 5a35@@rte_fib at sta/fib_dir24_8.c.o' -MF 'lib/76b5a35@@rte_fib at sta/fib_= dir24_8.c.o.d' -o 'lib/76b5a35@@rte_fib at sta/fib_dir24_8.c.o' -c ../lib/f= ib/dir24_8.c ../lib/fib/dir24_8.c: In function =E2=80=98get_vector_fn=E2=80=99: ../lib/fib/dir24_8.c:71:54: error: unused parameter =E2=80=98be_addr=E2=80= =99 [-Werror=3Dunused-parameter] 71 | get_vector_fn(enum rte_fib_dir24_8_nh_sz nh_sz, bool be_addr) | =20