From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B39ED45AE2; Tue, 8 Oct 2024 17:43:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 852144025C; Tue, 8 Oct 2024 17:43:14 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 4E5D24021E for <dev@dpdk.org>; Tue, 8 Oct 2024 17:43:13 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-71e05198d1dso1533679b3a.1 for <dev@dpdk.org>; Tue, 08 Oct 2024 08:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728402192; x=1729006992; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=guXUJngPxRiMq+9XDck0fak/GfkuXkRmg+xVNME8lyU=; b=Qgq5ve+8nme1cZwcXUCuw3KsRHJ8FsFU8DY4NkNeDxlklXWgqnIYZC6VKGfvdq4gU8 yXqNE5WnTMotIhBQipDF+KK9ups90xpfMv+bSwlH96Q3jAIDjyC5ft9Ebxgk9FoKbigQ lwElUxJyk1szRkbV+ncWybKem8gGCXjQJmDN/yAIX/lDV7w/0rowDQREVUA6WaHoFQsv GBTgj6s+GZN8uvLvfXfbobHxFOHpAMknxaTUJZ2NLtyv9ODbK2Gvg8NXHSgl50+TQW8m h96QGLgP8oj8NT0HjSo0WKZkM6FaYz11zYg8oGskclNOcgz9JdCvNhTP3vafqwcUbGOc Zwyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728402192; x=1729006992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=guXUJngPxRiMq+9XDck0fak/GfkuXkRmg+xVNME8lyU=; b=bCWzeiDu26+ZFgt7BTC0rcrkOXWd58ysXVJV0I5Rmm3XcpgvyELUnoA7auiX/BAz6z JaPLaRV1UlLkzYzz48PGTfWoMDb/2RiKBORsdFRabwkSguP+TAsCJu1qUa/qMnt2B3Ju LZheAe8XhXHqggBVCOPgCcENd/pRyza7I8joU8to+plfFXMTDJQF8Ufd+BEoRpQ6iC7q HGoSkpP4lvfVOekWPh0/hBJIH8e3kGR0h5gTRGcUyNdfUN6KV/ljJ6qUVUYa+0jyI5qN RjGwIUUFbrf3o0xqO+JfqVzg6Q6uKiDRFWQx3z7bK2CCQfd+QaXLh1uCaMp9t0+s2UJj 5SzA== X-Gm-Message-State: AOJu0Yz7szsaU4nHavFWhOua6LaR5z4cnrTvhsbjhqesHROEkZ90va6O DMqztGjDWoI3y63McxCEPcvVM4AiyS2C+5KrWkqAWlUm8xfu8hBvKeWKrBouxoyrljF7iyuiA36 vKBRErw== X-Google-Smtp-Source: AGHT+IHPm5kAIdwu3RhInxzPNPUIbdJ8xi9l1FgwpfRu6tm4U4D/yUrIw97oCpIlPF97Faa2oX45dQ== X-Received: by 2002:a05:6a00:3d46:b0:70d:265a:eec6 with SMTP id d2e1a72fcca58-71de23e2d8amr25254343b3a.13.1728402192330; Tue, 08 Oct 2024 08:43:12 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0ccf01dsm6293527b3a.70.2024.10.08.08.43.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 08:43:12 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Subject: [PATCH v8 00/17] Add function attributes to uncover allocation bugs Date: Tue, 8 Oct 2024 08:41:30 -0700 Message-ID: <20241008154301.66192-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240927204742.546164-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Recent versions of GCC have some additional function attributes that can help with DPDK performance and stability. The alloc_align attribute tells the compiler what the alignment of the allocation will be, and the optimizer can use this to produce better code (especially memcpy and structure copies). The malloc attribute tells compiler that object is not overlapping and potentially aliasing. It also as an additional variant in GCC 11 or later that allows for detecting all sorts of common errors like calling free() on memory allocated with rte_malloc(). In order to use the malloc attribute the free function prototype needs to be moved before the allocator/create function prototype so that the malloc attribute can refer to it. This uncovered at least 16 pre-existing bugs in DPDK, these should go to stable. This patch set is structured with: - fix any new warnings that were discovered - add macros for enable the macros - enable the attributes The same attributes could be added to lots more functions in DPDK, but this patch set focuses on the key ones, and where problems exist in current code base. v8 - rebase and cleanup the macros Stephen Hemminger (17): memzone: fix use after free in tracing cryptodev/bcmfs: fix mis-matched free dma/ixd: fix incorrect free function in cleanup event/cnxk: fix pointer mismatch in cleanup examples/vhost: fix free function mismatch net/cnxk: fix use-after-free bpf: fix free mismatch if convert fails net/e1000: fix use-after-free net/sfc: fix use-after-free warning messages net/cpfl: fix free of nonheap object net/nfp: fix duplicate call to rte_free raw/ifpga/base: fix use after free common/qat: fix use after free drivers/ifpga: fix free function mismatch baseband/la12xx: prevent use after free common/idpf: fix use after free due eal: add function attributes for allocation functions doc/guides/rel_notes/release_24_11.rst | 8 +++ drivers/baseband/la12xx/bbdev_la12xx.c | 1 + drivers/common/idpf/base/idpf_osdep.h | 10 +++- drivers/common/idpf/idpf_common_device.c | 3 +- drivers/common/qat/qat_device.c | 6 +-- drivers/crypto/bcmfs/bcmfs_device.c | 4 +- drivers/dma/idxd/idxd_pci.c | 2 +- drivers/event/cnxk/cnxk_eventdev.c | 4 +- drivers/net/cnxk/cnxk_ethdev_sec.c | 2 +- drivers/net/cpfl/cpfl_flow_parser.c | 1 - drivers/net/e1000/igb_ethdev.c | 4 +- drivers/net/nfp/flower/nfp_flower_flow.c | 1 - drivers/net/sfc/sfc_flow_rss.c | 4 +- drivers/net/sfc/sfc_mae.c | 23 ++++----- drivers/raw/ifpga/base/opae_intel_max10.c | 11 ++++- drivers/raw/ifpga/ifpga_rawdev.c | 8 +-- examples/vhost_blk/vhost_blk.c | 2 +- lib/bpf/bpf_convert.c | 2 +- lib/eal/common/eal_common_memzone.c | 3 +- lib/eal/include/rte_common.h | 34 +++++++++++++ lib/eal/include/rte_malloc.h | 59 ++++++++++++++--------- 21 files changed, 126 insertions(+), 66 deletions(-) -- 2.45.2