From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B704645AE2; Tue, 8 Oct 2024 17:44:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4436940E48; Tue, 8 Oct 2024 17:43:29 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 95EEB40BA5 for ; Tue, 8 Oct 2024 17:43:21 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-71dec1cf48fso3492276b3a.0 for ; Tue, 08 Oct 2024 08:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728402201; x=1729007001; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Eic6BVDwTvlRyCaygh6PjhzUg841CjLidZBg58UU5PI=; b=iJ1r51PfE9Q+yYIDpY3Njl89AnZ46HznJtDIMPzJQG7X+kkAJ0KJ0vb0wUb6GO11l4 8S31+mKT6vN0HxiaFpsLbBl8ZvIXSTqunY4qNLFVEZjBHD3tSyhcCuMJN+NQEni5kTBR 6bK5YeSNhyYQm7AEZEQ9Xd4KJmi/KGEKvYCy1ftYPb9Wo6wlhQg+DS8EjeAl1nqmhR+e 1ERA7tjFt9GtDUwdGR/KsAkjWU83RYBLsC7ld3tPq2VpZK1B4FPx3SagIemtBevBqgm1 FlWkQZG2Lam4xuoNXtbsWDhFgPHSMz6Ch7R++PGnn/GSoKReF3sK0ULlBRA13u4yjRp5 86MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728402201; x=1729007001; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Eic6BVDwTvlRyCaygh6PjhzUg841CjLidZBg58UU5PI=; b=ugKXdiuUmhgckKXk6IQDXYoysbSgNo1+r9+HoILAn5gjUgIQVjbZhDAzgdhBCrbbdr fp5lin8XO5zQRDNQH1kodCt6QyeW8+mcTL8wxFLM7sBten1TWX5c91++OSEsbizRiPB6 IP8JXg80CKE3V/UyZuGJl23ezbeIqfMG1mPdwR1gtM8pHKUGjUEyzOPWeeupSQXE8SvU zbH6Rsutf2kncFa0EZukUEWUV5+99oKsdWKLeLCYimzZXOF972DydnSvKQ0pb4SSgb3B hJYRgiw0B5+XVYhAFGN/CpUmWdDshripUqDmOesTdSW5GRwCxuptvlw6LAMZ7QWtQe7O kySw== X-Gm-Message-State: AOJu0YxITA6DAMv1VdKNBaJm8Q7FlXMM1EeQ9VRY8DFtg3/VlhlMUAUP XbwebJVJ9BMz2TL7b7rDJOiMtM0NSYUtg4fm5/8qHMa8C8qSOB4x9WfaeD1GfnTBvG31TFJLvWu RfsA6jQ== X-Google-Smtp-Source: AGHT+IGVJwLTNwjR8p8O+D57RU7CBwqGSxXyxaZz/8R/HhOJdq9a5lA0OrBQ8Uk932f9Hoat9ytMow== X-Received: by 2002:a05:6a20:e605:b0:1cf:6953:2872 with SMTP id adf61e73a8af0-1d6dfafccf8mr22434425637.48.1728402200787; Tue, 08 Oct 2024 08:43:20 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0ccf01dsm6293527b3a.70.2024.10.08.08.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 08:43:20 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , wenjing.qiao@intel.com, stable@dpdk.org, Qi Zhang Subject: [PATCH v8 10/17] net/cpfl: fix free of nonheap object Date: Tue, 8 Oct 2024 08:41:40 -0700 Message-ID: <20241008154301.66192-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241008154301.66192-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20241008154301.66192-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org With proper annotation, GCC discovers that this driver is calling rte_free() on an object that was not allocated (it is part of array in another object). In function ‘cpfl_flow_js_mr_layout’, inlined from ‘cpfl_flow_js_mr_action’ at ../drivers/net/cpfl/cpfl_flow_parser.c:848:9, inlined from ‘cpfl_flow_js_mod_rule’ at ../drivers/net/cpfl/cpfl_flow_parser.c:908:9, inlined from ‘cpfl_parser_init’ at ../drivers/net/cpfl/cpfl_flow_parser.c:932:8, inlined from ‘cpfl_parser_create’ at ../drivers/net/cpfl/cpfl_flow_parser.c:959:8: ../drivers/net/cpfl/cpfl_flow_parser.c:740:9: warning: ‘rte_free’ called on pointer ‘*parser.modifications’ with nonzero offset [28, 15479062120396] [-Wfree-nonheap-object] 740 | rte_free(js_mod->layout); | ^~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 6cc97c9971d7 ("net/cpfl: build action mapping rules from JSON") Cc: wenjing.qiao@intel.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_flow_parser.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_flow_parser.c b/drivers/net/cpfl/cpfl_flow_parser.c index 011229a470..303e979015 100644 --- a/drivers/net/cpfl/cpfl_flow_parser.c +++ b/drivers/net/cpfl/cpfl_flow_parser.c @@ -737,7 +737,6 @@ cpfl_flow_js_mr_layout(json_t *ob_layouts, struct cpfl_flow_js_mr_action_mod *js return 0; err: - rte_free(js_mod->layout); return -EINVAL; } -- 2.45.2