From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v3 09/10] net/virtio: use global AVX-512 variables
Date: Tue, 8 Oct 2024 17:52:57 +0100 [thread overview]
Message-ID: <20241008165258.2802099-10-bruce.richardson@intel.com> (raw)
In-Reply-To: <20241008165258.2802099-1-bruce.richardson@intel.com>
Replace per-driver checks for AVX-512 with the standard variables from
config/x86.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/virtio/meson.build | 32 +++++++++++++++-----------------
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build
index ef016c1566..02742da5c2 100644
--- a/drivers/net/virtio/meson.build
+++ b/drivers/net/virtio/meson.build
@@ -24,23 +24,21 @@ sources += files(
deps += ['kvargs', 'bus_pci']
if arch_subdir == 'x86'
- if not machine_args.contains('-mno-avx512f')
- if cc.has_argument('-mavx512f') and cc.has_argument('-mavx512vl') and cc.has_argument('-mavx512bw')
- cflags += ['-DCC_AVX512_SUPPORT']
- virtio_avx512_lib = static_library('virtio_avx512_lib',
- 'virtio_rxtx_packed.c',
- dependencies: [static_rte_ethdev,
- static_rte_kvargs, static_rte_bus_pci],
- include_directories: includes,
- c_args: [cflags, '-mavx512f', '-mavx512bw', '-mavx512vl'])
- objs += virtio_avx512_lib.extract_objects('virtio_rxtx_packed.c')
- if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))
- cflags += '-DVIRTIO_GCC_UNROLL_PRAGMA'
- elif (toolchain == 'clang' and cc.version().version_compare('>=3.7.0'))
- cflags += '-DVIRTIO_CLANG_UNROLL_PRAGMA'
- elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0'))
- cflags += '-DVIRTIO_ICC_UNROLL_PRAGMA'
- endif
+ if cc_has_avx512
+ cflags += ['-DCC_AVX512_SUPPORT']
+ virtio_avx512_lib = static_library('virtio_avx512_lib',
+ 'virtio_rxtx_packed.c',
+ dependencies: [static_rte_ethdev,
+ static_rte_kvargs, static_rte_bus_pci],
+ include_directories: includes,
+ c_args: cflags + cc_avx512_flags)
+ objs += virtio_avx512_lib.extract_objects('virtio_rxtx_packed.c')
+ if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))
+ cflags += '-DVIRTIO_GCC_UNROLL_PRAGMA'
+ elif (toolchain == 'clang' and cc.version().version_compare('>=3.7.0'))
+ cflags += '-DVIRTIO_CLANG_UNROLL_PRAGMA'
+ elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0'))
+ cflags += '-DVIRTIO_ICC_UNROLL_PRAGMA'
endif
endif
sources += files('virtio_rxtx_simple_sse.c')
--
2.43.0
next prev parent reply other threads:[~2024-10-08 16:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 17:50 [PATCH v1 0/8] centralize AVX-512 feature detection Bruce Richardson
2024-09-30 17:50 ` [PATCH v1 1/8] config/x86: add global defines for checking AVX-512 Bruce Richardson
2024-09-30 17:50 ` [PATCH v1 2/8] event/dlb2: use global AVX-512 variables Bruce Richardson
2024-09-30 17:50 ` [PATCH v1 3/8] common/idpf: " Bruce Richardson
2024-09-30 17:50 ` [PATCH v1 4/8] net/cpfl: " Bruce Richardson
2024-09-30 17:50 ` [PATCH v1 5/8] net/i40e: " Bruce Richardson
2024-09-30 17:50 ` [PATCH v1 6/8] net/iavf: " Bruce Richardson
2024-09-30 17:50 ` [PATCH v1 7/8] net/ice: " Bruce Richardson
2024-09-30 17:50 ` [PATCH v1 8/8] net/idpf: " Bruce Richardson
2024-10-01 11:17 ` [PATCH v2 0/8] centralize AVX-512 feature detection Bruce Richardson
2024-10-01 11:17 ` [PATCH v2 1/8] config/x86: add global defines for checking AVX-512 Bruce Richardson
2024-10-01 11:17 ` [PATCH v2 2/8] event/dlb2: use global AVX-512 variables Bruce Richardson
2024-10-01 11:17 ` [PATCH v2 3/8] common/idpf: " Bruce Richardson
2024-10-01 11:17 ` [PATCH v2 4/8] net/cpfl: " Bruce Richardson
2024-10-01 11:17 ` [PATCH v2 5/8] net/i40e: " Bruce Richardson
2024-10-01 11:17 ` [PATCH v2 6/8] net/iavf: " Bruce Richardson
2024-10-01 11:18 ` [PATCH v2 7/8] net/ice: " Bruce Richardson
2024-10-01 11:18 ` [PATCH v2 8/8] net/idpf: " Bruce Richardson
2024-10-08 8:49 ` [PATCH v2 0/8] centralize AVX-512 feature detection David Marchand
2024-10-08 10:02 ` Bruce Richardson
2024-10-08 11:33 ` David Marchand
2024-10-08 11:35 ` Bruce Richardson
2024-10-08 16:52 ` [PATCH v3 00/10] " Bruce Richardson
2024-10-08 16:52 ` [PATCH v3 01/10] config/x86: add global defines for checking AVX-512 Bruce Richardson
2024-10-08 16:52 ` [PATCH v3 02/10] event/dlb2: use global AVX-512 variables Bruce Richardson
2024-10-08 16:52 ` [PATCH v3 03/10] common/idpf: " Bruce Richardson
2024-10-08 16:52 ` [PATCH v3 04/10] net/cpfl: " Bruce Richardson
2024-10-08 16:52 ` [PATCH v3 05/10] net/i40e: " Bruce Richardson
2024-10-08 16:52 ` [PATCH v3 06/10] net/iavf: " Bruce Richardson
2024-10-08 16:52 ` [PATCH v3 07/10] net/ice: " Bruce Richardson
2024-10-08 16:52 ` [PATCH v3 08/10] net/idpf: " Bruce Richardson
2024-10-08 16:52 ` Bruce Richardson [this message]
2024-10-08 16:52 ` [PATCH v3 10/10] net: " Bruce Richardson
2024-10-09 9:05 ` [PATCH v3 00/10] centralize AVX-512 feature detection David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008165258.2802099-10-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).