From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 004D745AF5; Wed, 9 Oct 2024 20:31:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 784804025D; Wed, 9 Oct 2024 20:31:30 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 36BD04014F for ; Wed, 9 Oct 2024 20:31:29 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71de776bc69so106548b3a.1 for ; Wed, 09 Oct 2024 11:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728498688; x=1729103488; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=q0mXpXQYi08vsS5ByD7ykp2fv1SYCc9WTlwb2gR233U=; b=IjmePrcv7J6A2stojc/6bBVmgjOvuns1m08hqDkGJfvZIq/r7s2qW8NTtATWh7kQnQ q5tlZaZdz1Nt65J4WrvdRmuMSKziEcHNdPi77aKIp1cZQ2qusUBlaoc1V7Bn9w46aMMy AWZ1KGLOiTdTfB1mOsy205wBy0QKsKv1kQfLLXkzf6x24EbBueOEtLOfKdHa6nAfI2Tv gup+UeZ0aRm99Ivw94OGOAQpY2/P9zpcDf7xHZo8tan6yhcQte3JPZaUR+PdHGRALpIp dWJfNFyc3iUNyMwLRsSqLRXw9JY1WiNci8sYTZZwSpk/vvt04zPkfmq+Yn/GsrTz4nIz yW7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728498688; x=1729103488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q0mXpXQYi08vsS5ByD7ykp2fv1SYCc9WTlwb2gR233U=; b=qRaPeBsay7HnE/KFzWg093WMkUVgKxE3ul5pyBRAV6A/2pbmBIq1bbEIfbfrYtuiBr UxRjrBofCX3Oa2f6LjGMtP+2MgoaM50dwTchQ+cUjuR/us0Lt/5WoTJuC4BtEBiRp/Ol PEouFI7s0RdhvFkCh6XaD24+3IxSJMWrr92n79YbAqfUC+OH/x5eVGtVZn8CEZbbwTYt Bd0Ws5E8+qHHLNWWn0Hdrs1u1m9xlBup3b8QJsx13XmV4PMw7A+KqTJ+8h2QOZOayyIt DYY373JvF4D6IWd/S2Vc8Ae39aPTo56DURgbs1dixc8VMeZ9tVeM4xp8uzwaqxxgFLfN Y6TQ== X-Gm-Message-State: AOJu0YwZmrucJGYeLCa//+bt8KDsNyaeIzKpdq6il/XQFF7X4/mzpmGe D0tJ4SH525E3gyX/RlwIexRm5Q05LsZ0IIF9yeCSAssO5FrcILcAUKBESe0K0zk= X-Google-Smtp-Source: AGHT+IFZGfoWJRStKBHIHOI73WWZTVcywkzOhBOs1W1LmDVQzOzKX80DO3zpn70Qz3RROb42Ojh+nw== X-Received: by 2002:a05:6a00:2d98:b0:71e:19a:c48b with SMTP id d2e1a72fcca58-71e1dbb803fmr5649383b3a.22.1728498688097; Wed, 09 Oct 2024 11:31:28 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0cbc9a3sm8086582b3a.20.2024.10.09.11.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 11:31:27 -0700 (PDT) Date: Wed, 9 Oct 2024 11:31:23 -0700 From: Stephen Hemminger To: Vladimir Medvedkin Cc: dev@dpdk.org, rjarry@redhat.com, mb@smartsharesystems.com, david.marchand@redhat.com Subject: Re: [PATCH v2] fib: network byte order IPv4 lookup Message-ID: <20241009113123.098f4f23@hermes.local> In-Reply-To: <20241008171605.378069-1-vladimir.medvedkin@intel.com> References: <20241008171605.378069-1-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 8 Oct 2024 17:16:05 +0000 Vladimir Medvedkin wrote: > Previously when running rte_fib_lookup IPv4 addresses must have been in > host byte order. >=20 > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on > fib create, which will allow to have IPv4 in network byte order on > lookup. >=20 > Signed-off-by: Vladimir Medvedkin Need to address David's comment see the build failures. Build URL: https://github.com/ovsrobot/dpdk/actions/runs/11240928255 Build Logs: -----------------------Summary of failed steps----------------------- "ubuntu-22.04-gcc-static-i386" failed at step Build and test "ubuntu-22.04-gcc-shared-aarch64" failed at step Build and test "ubuntu-22.04-gcc-ppc64le" failed at step Build and test "ubuntu-22.04-gcc-riscv64" failed at step Build and test ----------------------End summary of failed steps-------------------- -------------------------------BEGIN LOGS---------------------------- ###########################################################################= ######### #### [Begin job log] "ubuntu-22.04-gcc-static-i386" at step Build and test ###########################################################################= ######### [423/3186] Compiling C object 'lib/76b5a35@@rte_fib at sta/fib_rte_fib.c.o'. [424/3186] Compiling C object 'lib/76b5a35@@rte_pdcp at sta/pdcp_pdcp_ctrl_= pdu.c.o'. [425/3186] Compiling C object 'lib/76b5a35@@rte_pdcp at sta/pdcp_pdcp_reord= er.c.o'. [426/3186] Generating ipsec.sym_chk with a meson_exe.py custom command. [427/3186] Linking target lib/librte_ipsec.so.25.0. [428/3186] Compiling C object 'lib/76b5a35@@rte_pdcp at sta/pdcp_rte_pdcp.c= .o'. [429/3186] Generating symbol file 'lib/76b5a35@@rte_ipsec at sha/librte_ips= ec.so.25.0.symbols'. [430/3186] Compiling C object 'lib/76b5a35@@rte_fib at sta/fib_rte_fib6.c.o= '. [431/3186] Compiling C object 'lib/76b5a35@@rte_port at sta/port_port_log.c= .o'. [432/3186] Compiling C object 'lib/76b5a35@@rte_fib at sta/fib_trie.c.o'. [433/3186] Compiling C object 'lib/76b5a35@@rte_fib at sta/fib_dir24_8.c.o'. FAILED: lib/76b5a35@@rte_fib at sta/fib_dir24_8.c.o=20 ccache gcc -Ilib/76b5a35@@rte_fib at sta -Ilib -I../lib -Ilib/fib -I../lib/= fib -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -= Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I.= ./lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../l= ib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/telemetry/= ../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry= -Ilib/rib -I../lib/rib -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/= ring -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Win= valid-pch -Wextra -Werror -std=3Dc11 -O2 -g -include rte_config.h -Wcast-qu= al -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-de= clarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wp= ointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wn= o-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initi= alizers -Wno-zero-length-bounds -Wno-pointer-to-int-cast -D_GNU_SOURCE -m32= -fPIC -march=3Dcorei7 -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API = -Wno-format-truncation -DRTE_LOG_DEFAULT_LOGTYPE=3Dlib.fib -MD -MQ 'lib/76b= 5a35@@rte_fib at sta/fib_dir24_8.c.o' -MF 'lib/76b5a35@@rte_fib at sta/fib_= dir24_8.c.o.d' -o 'lib/76b5a35@@rte_fib at sta/fib_dir24_8.c.o' -c ../lib/f= ib/dir24_8.c ../lib/fib/dir24_8.c: In function =E2=80=98get_vector_fn=E2=80=99: ../lib/fib/dir24_8.c:71:54: error: unused parameter =E2=80=98be_addr=E2=80= =99 [-Werror=3Dunused-parameter] 71 | get_vector_fn(enum rte_fib_dir24_8_nh_sz nh_sz, bool be_addr) | ^ cc1: all warnings being treated as errors [434/3186] Compiling C object 'lib/76b5a35@@rte_port at sta/port_rte_port_e= thdev.c.o'. [435/3186] Compiling C object 'lib/76b5a35@@rte_port at sta/port_rte_port_f= d.c.o'. [436/3186] Compiling C object 'lib/76b5a35@@rte_pdcp at sta/pdcp_pdcp_proce= ss.c.o'. [437/3186] Compiling C object 'lib/76b5a35@@rte_vhost at sta/vhost_vhost_cr= ypto.c.o'. [438/3186] Compiling C object 'lib/76b5a35@@rte_vhost at sta/vhost_virtio_n= et.c.o'. ninja: build stopped: subcommand failed. ##[error]Process completed with exit code 1. ###########################################################################= ######### #### [End job log] "ubuntu-22.04-gcc-static-i386" at step Build and test ###########################################################################= #########