From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 548A745AF5; Wed, 9 Oct 2024 21:33:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4249740156; Wed, 9 Oct 2024 21:33:35 +0200 (CEST) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by mails.dpdk.org (Postfix) with ESMTP id 607324014F for ; Wed, 9 Oct 2024 21:33:34 +0200 (CEST) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-6e2fef23839so2050737b3.2 for ; Wed, 09 Oct 2024 12:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728502413; x=1729107213; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yB4zDJHvWUcNozyo0/lvP+N8YRG8JUlf0Q0HYDeZ/RA=; b=ah1+n1IUnlbAdqwpIQjIThhM7YVO9W8/CzsIEWNJ3+NqlhFczvEpM03upQ/ydtviKH IY1b5xf0JGXP2N5Pznx7ssQLIaWxwxLwUJ5vRUbXta56tMqjENirS5+McF67dMEuWsW/ UZ4J/rZ64Zm5kQaE5m0t15xP9u2YMVvj2V4yvxln4X4mQCwcBUzS/p8K4sbl0bByhkfT Ogabx6RjnV/ad1tWJAZNE8V8o4CbseO8MRKmRjpA2hReeGn9jiMM+5U57dITVE2cF+iZ PTs2HAcdR4FZjY/r26R/+ylD3dpA8+Ms2QDj76jGvACoeTDihtFda3qjyd9BuwFb+AaZ Ew9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728502413; x=1729107213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yB4zDJHvWUcNozyo0/lvP+N8YRG8JUlf0Q0HYDeZ/RA=; b=J+ri4rb0eb/jxLdGVDDcOiJcCQYFTrfUtkC8MLu8eAKrucV4fCvVfTj8Wep5QGeQya JqdjVfix3NvQiFFu3Hl6c8Ff7PhLgpbVe1SkNEPg9rb/2nQV9NLpenCISbthOtyxa/mQ Zsjae7858g+uAanggfyj+LH7vEGmBOo7U8x0c9cimT7vlND+g1UuxEl3pz4PrzEOjkmA o93gmtVlPpGsQKlg4/dyUPdeT9KqUoAP7BSJi0BeVl7/p5QbXxhGytuvDGtGrYCPUu6r rqtxImpiI36Sd2HS/RLE9KOYXQ+sx6SP6ptvH/2CslgsW2W3+oNzntaqEJ8g7HGLScZy mjdg== X-Forwarded-Encrypted: i=1; AJvYcCWvezTTyhr7Xl0v3KuzN1dpJmAmmal8WftDjvIg8vyapg4TiaxkFpS3WHEA4G+zdN6Debc=@dpdk.org X-Gm-Message-State: AOJu0YwaXZVUFkzdG+EFS/PgtxNQGF0pOvhnMqTugiLOlv30ITIkfhRs nFFe+VIgZO5gFf7ub6XxFLnkkO2eRtQomI4JZ4NIRACiKjai/WS8FVdVabo1J8I= X-Google-Smtp-Source: AGHT+IHCB/3lsysQ2CUjPlH55k6mxIVP33z8+GoYx+batksMJdSISBinSQ0inm3K339VZ2QdoeOESA== X-Received: by 2002:a05:690c:906:b0:6ae:614e:cbb with SMTP id 00721157ae682-6e3221902demr39682187b3.42.1728502413585; Wed, 09 Oct 2024 12:33:33 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6e321a8bb61sm4538737b3.36.2024.10.09.12.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 12:33:33 -0700 (PDT) Date: Wed, 9 Oct 2024 12:33:30 -0700 From: Stephen Hemminger To: Chengwen Feng Cc: , , Subject: Re: [PATCH v4 0/6] refine argparse library Message-ID: <20241009123330.5ae1ac97@hermes.local> In-Reply-To: <20240318111838.16991-1-fengchengwen@huawei.com> References: <20240220131502.47510-1-fengchengwen@huawei.com> <20240318111838.16991-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 18 Mar 2024 11:18:32 +0000 Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argparse: fix argument flags operate as uint32 type > test/argparse: refine testcases > argparse: fix doc don't display two hyphens > > --- > v4: address Thomas's comment on 4/6 commit: > - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and > TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. > v3: > - address Thomas's comment on 4/6 comit. > - add commit: fix doc don't display two hyphens. > v2: address David Marchand's comment: > - replace flag enum with marco. > - replace flag's hardcode with macro in test_argparse.c. > > app/test/test_argparse.c | 65 +++++++++++--------- > doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- > lib/argparse/rte_argparse.c | 61 +++++++++--------- > lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- > 4 files changed, 127 insertions(+), 131 deletions(-) The verb refine is not usually used for edits to documents or software that probably is a translation issue. Series-acked-by: Stephen Hemminger