From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2500545AFB; Thu, 10 Oct 2024 00:47:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8E1540156; Thu, 10 Oct 2024 00:47:27 +0200 (CEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 3353E400D6 for <dev@dpdk.org>; Thu, 10 Oct 2024 00:47:26 +0200 (CEST) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-71df4620966so296537b3a.0 for <dev@dpdk.org>; Wed, 09 Oct 2024 15:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728514045; x=1729118845; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=35iBdVO7UUFAjtqLgujk2GLQ1pvJAUDSnE4I/iR3hUA=; b=wBSWFfS9kfYxTB7UEwiAyo/CgIMGlx6C3Hk19tjmSSli6ynnaILUqUVVDdZvI2TPbx engw+6OhBKXUioCM2eDJvl6cP7yAK38Mt3JWzpjP0rhAX3vQ5PtPlyidBN2OHlJqaj4v x0+Xm8wSF9D9vThdtFU3rmHZGtP33CfO/B9JHAKDJ+UBJFVX7Zw7k3Keob99m8dvnSI/ Qqf5XYgSJx0SaId/zWFaZTI3Sv/MRl7jKivxPAuFcI4o+SdczJq7nsOOCcMgjAywWVEs Omd0eHiXp6x806Wmm0f7+yeTQe5Mrzo+6wOV5ntAG7aGB7h4E3sKxituLhR+QLhf4GPA w3VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728514045; x=1729118845; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=35iBdVO7UUFAjtqLgujk2GLQ1pvJAUDSnE4I/iR3hUA=; b=NKx+SEigMlGeSU5u/Te/JqTTqRM+n0VidoWJ/lxrAzf8Sjz8BP2vAWyUawjX+xGkVg 7mAujKDM+xWt4FueDy58PoW7KVo/+XfTS/J55CFuo/9sYUH1l2taoSb3qPi7Z7p3SShg UklA83QhRxKdj8WG3E5OenlFP1P5blK5PEBHEPfsQwYvREwyW4tOQEp+un77FUtqU3DC x/iYn+GobAZZuxwXa3OKt86Ia+TtBu60bEyhyvpevRe40WnTzzQruNlIk2PC2BSFSUUo mptKfmgruzRSFQg2sDBOHo89gZ3dBSVuHnEAes4kNnCZs1ykJBqebcu4QbkVxW3PD9QS JOIA== X-Forwarded-Encrypted: i=1; AJvYcCXhTpDH3FF/61zVpgQVT3z/+unDcVq8/hDVk+EtZM2Q1WDJG/ISsD0iBYr1XQKHHMSFXlg=@dpdk.org X-Gm-Message-State: AOJu0YybZUi4iv7KlRfDmczg5+5K1d9dZfYhlJxzCJVeXPngNm+b7tkx l4oeijfBLo857U5Y6oNHHWMYFqJbtyuaP+Ccu3YNBJispMfy0TTm43QYmiM/d0U= X-Google-Smtp-Source: AGHT+IFtsGlKPnSoUM8cTj16U2QgVV2NzgbXTnJxmZzEw5+gShZX+4Vcq+w/LYhSlPklKwHtcU/Smg== X-Received: by 2002:a05:6a00:1390:b0:71d:ea77:e94e with SMTP id d2e1a72fcca58-71e1db8ecffmr6609484b3a.16.1728514045381; Wed, 09 Oct 2024 15:47:25 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0cd0ad2sm8317939b3a.63.2024.10.09.15.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 15:47:25 -0700 (PDT) Date: Wed, 9 Oct 2024 15:47:23 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Chengwen Feng <fengchengwen@huawei.com> Cc: <thomas@monjalon.net>, <dev@dpdk.org>, <cristian.dumitrescu@intel.com>, <david.marchand@redhat.com> Subject: Re: [PATCH v2 0/4] cfgfile: enhance error detecting Message-ID: <20241009154723.1406342e@hermes.local> In-Reply-To: <20240705093115.4437-1-fengchengwen@huawei.com> References: <20240220035840.32978-1-fengchengwen@huawei.com> <20240705093115.4437-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, 5 Jul 2024 09:31:11 +0000 Chengwen Feng <fengchengwen@huawei.com> wrote: > When I was trying to debug a problem introduced by config.ini in > test-dma-perf, I found the cfgfile library should enhance error > detecting, so got this patchset. > > Chengwen Feng (4): > cfgfile: remove dead code > cfgfile: support verify name and value > cfgfile: verify add section and entry result > cfgfile: add strict parse flag > > --- > v2: replace unique name with strict parse flag which address Stephen's > comment. > > lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++---------- > lib/cfgfile/rte_cfgfile.h | 7 ++++ > 2 files changed, 59 insertions(+), 18 deletions(-) > This patch series is good, but a few things are needed still: - please add a functional test for this. - add a release note, since somebody might get be surprised. Also, would be good to put DPDK cfgfile parser on the Wikipedia page about ini files? This library could really use some work: - support variable length (not fixed size strings) - support multi-line - sub sections - faster access for large ini files (not linked list)