From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D50745AF9; Thu, 10 Oct 2024 02:18:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB2504025E; Thu, 10 Oct 2024 02:18:57 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 6DFC240156 for <dev@dpdk.org>; Thu, 10 Oct 2024 02:18:56 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2e2b159c609so373391a91.2 for <dev@dpdk.org>; Wed, 09 Oct 2024 17:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728519535; x=1729124335; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=eHuy7pru3k98ixp70634SmCsGUrHPJeq2M3mE7gnZN4=; b=sYEMHWecFHIdprniAej7r5X8fYlW+LmBWpECJGBmH4eqrOCkWg56ZeAv2/2tEm1IfJ kiygIXL/99dYVrj4jG2cEGq+RC6mW+x4mG7P/eFSIexNYjhJjf+B5KOA0syJzobAf9tK /WTJU3Ly8FtOgDOzB1+bQyzz9JgHwolQYISDmVkELTzpiAaYxu+sYKDPUZ8FgBLFvVTl +3zuQ5eY4Bj7Z5IPNBXZOX/VmseW2TUS3T3mREYzxW/6JCXOaBQ/I/U12rcYMVzCakPx Gqdi4BnvnRy79/exiMsWcZtZcmCjdcyb5gF0EfKXZ80uoIsfUrib2j/PI2Dh/oUKKg7b EvYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728519535; x=1729124335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eHuy7pru3k98ixp70634SmCsGUrHPJeq2M3mE7gnZN4=; b=KKWudxkNV7EXn79E+WxtXxXMnLarmmF+AiGKTZLBQCXyXwwes5NooMRc4jHBZgfCol mSChfV4D2abO2UpvU4n4TdWvbBUrwksbzNjVul/0iqWfvChqPXyK9YRuPgcCKF7nIaSl SbUVPgycvY1FKLx0Wv+MTNdY0yx/lLGcbTStCZbCAMKJPDrWWEgG7Fjw0YYLfQvj4iM1 tNI6zOmPz3BDX6iWSP0BoTEKzk051SdrthDKSnNF/zYHGySabopTAFEbytmVreEX3bDl +ZJeBxbRKIU9lOWYspzXhQtYZGGyKDzRmnuUkoZUKMop57Nntmnoa3DdjvktjP7tvgUL W7Uw== X-Forwarded-Encrypted: i=1; AJvYcCU+6pSS4ZnGaG19nPqXvquRo8o5vWUy8QlmmUFECBZ5DUMCkX7KYubM1sA7qtKlhFifjYU=@dpdk.org X-Gm-Message-State: AOJu0Yw40J/JbCsNjehFx5Yjcw+ImF4GXjjI3unwCcjoqICMy16hoYYK XLcIsveug8+RTwgoEEp5Rhd/lejR9v2MXMcqw8hipI6BZxAkc/VfniwNCuyRiHM= X-Google-Smtp-Source: AGHT+IHJtDTKA055ruwEgBV4t+G4kDN0yDsH0xK3IVyAH6bBbejOg/7jjVMVWRv/jX2ZVOtqeVYYBw== X-Received: by 2002:a17:90b:11d5:b0:2d8:9f4c:ecb8 with SMTP id 98e67ed59e1d1-2e2a2335c89mr5793519a91.13.1728519535428; Wed, 09 Oct 2024 17:18:55 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2d5f0656fsm39200a91.25.2024.10.09.17.18.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 17:18:55 -0700 (PDT) Date: Wed, 9 Oct 2024 17:18:53 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Slava Ovsiienko <viacheslavo@nvidia.com> Cc: Igor Gutorov <igootorov@gmail.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>, Matan Azrad <matan@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [PATCH 1/1] net/mlx5: show rx/tx descriptor ring limitations in rte_eth_dev_info Message-ID: <20241009171853.77e8dce7@hermes.local> In-Reply-To: <IA1PR12MB8078B175BF86C1B607921F83DFCD2@IA1PR12MB8078.namprd12.prod.outlook.com> References: <20240616173803.424025-1-igootorov@gmail.com> <20240616173803.424025-2-igootorov@gmail.com> <IA1PR12MB8078B175BF86C1B607921F83DFCD2@IA1PR12MB8078.namprd12.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 17 Jun 2024 07:18:58 +0000 Slava Ovsiienko <viacheslavo@nvidia.com> wrote: > Hi, Igor > > Thank you for the patch. > > 1. The absolute max descriptor number supported by ConnectX hardware is 32768. > 2. The actual max descriptor number supported by the port (and its related representors) > reported in log_max_wq_sz in HCA.caps. This value should be queried and save in mlx5_devx_cmd_query_hca_attr() routine. > 3. mlx5_rx_queue_pre_setup() should check requested descriptor number and reject if it exceeds log_max_wq_sz > 4. Please, format your patch according to the "fix" template. > > With best regards, > Slava Marking this patch as Changes Requested. Yes, this comment expands the scope of the original patch; but if this part of the mlx5 is going to change, might as well get it right.