From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 53F0D45B00;
Thu, 10 Oct 2024 11:18:19 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 96C314066D;
Thu, 10 Oct 2024 11:17:53 +0200 (CEST)
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam11on2092.outbound.protection.outlook.com [40.107.223.92])
by mails.dpdk.org (Postfix) with ESMTP id BDECE40614;
Thu, 10 Oct 2024 11:17:48 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=XiMW7ng5iWEGbGwB8s5pJSTB8HssdMJIN6ksrMlWhCsvv2ZaVDv/ItH+VwVWE0mAxpszpJNm3BsHXVRIM+FwxEpnljEv8XEVFfAQ0pxbG0PIi+kfsjnabmOqOkWmavFyCzcoZeUuRaRMg5uGfWnQyRsss+xAia3LYjtjjhyGf14zs/8wH3NlToAFO+16QtaYtVKE9GkXUDAWnim35ZV+EndEvFzfiieDweEPP6Wxg7H/sBr4fsB+022NwP4/5w1MiqejZQgvKpU/Yhwzguyz7GSUUHiAoMlGMd+BtDPF0mD9KjeUNCB39aiLN+1kiKicNUayrA4jcqn99TKkZsTISw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=xKpIMuyiJa63K4pHNvPDdQpbPqW5u5ESGwAtf4tu/wA=;
b=VPf9FY3SUPIVAHHhWZox4kw0LAKi5QzBdfLVgzupG5qQSO5BwzoJZkl4fT5IR4TxfvGu4QljqEqrajaZzZT+kKL6lGGILP2XEFFESHLc11PdxKJ4urMplh9A6oLNq1CfxxJ8EFyponRrDGdDXzZ6h29phj4F94YurHxfjXr9Vyh7i7rg1gHm+VShh1CRw4JCPS25d/8tt7iHSL9K/SgqbAGHNeddkjZfbcd8sX5Fewp6tx8nuIUwAQY60MOC62Yn5A/44BtS2PMiTOixxgSd3cWQcBYdxiflTd1thzFgL3nQkfOetFELjXoJAaXgss5dXN3d+u91fgopKgCgntEVaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;
dkim=pass header.d=corigine.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=xKpIMuyiJa63K4pHNvPDdQpbPqW5u5ESGwAtf4tu/wA=;
b=Qyd4EmWS+P1gAWRvZpPxWI8TW3o+haE/frmjjy6NnDhtToyL9h2dRuA7s8EwDjua0U1KtN/ia9PcjguPFAnr5/IKQDZrNPEcEdU1KXUqznbGfEYQJlcHERFIjRsaM/8iEmJkDxHUO6LTeI9Kln66hiGh/pKoR4RgjBoYt/KxhNY=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=corigine.com;
Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)
by MW3PR13MB3980.namprd13.prod.outlook.com (2603:10b6:303:5c::15)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.18; Thu, 10 Oct
2024 09:17:47 +0000
Received: from SJ0PR13MB5545.namprd13.prod.outlook.com
([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com
([fe80::b900:5f05:766f:833%5]) with mapi id 15.20.8026.020; Thu, 10 Oct 2024
09:17:47 +0000
From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,
stable@dpdk.org, Long Wu <long.wu@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 05/10] net/nfp: fix problem caused by configure function
Date: Thu, 10 Oct 2024 17:17:11 +0800
Message-Id: <20241010091716.3631747-6-chaoyong.he@corigine.com>
X-Mailer: git-send-email 2.39.1
In-Reply-To: <20241010091716.3631747-1-chaoyong.he@corigine.com>
References: <20241010091716.3631747-1-chaoyong.he@corigine.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: TP0P295CA0060.TWNP295.PROD.OUTLOOK.COM
(2603:1096:910:3::15) To SJ0PR13MB5545.namprd13.prod.outlook.com
(2603:10b6:a03:424::5)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|MW3PR13MB3980:EE_
X-MS-Office365-Filtering-Correlation-Id: 2851465e-d394-46a0-f393-08dce90c67cb
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
ARA:13230040|366016|376014|52116014|1800799024|38350700014;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4i6FaOGcMyD/htNry//6PB0SOMYQS9WwXBURPVOBBnO8eEYGbMgVsM5jueCF?=
=?us-ascii?Q?yFx0YOhbsJWEyYPBUuB4MDeBcxmafmNcgOMS3G2u2z/AD/sKhstrZfRkexlV?=
=?us-ascii?Q?5++cfGalXNzToW71C7FDV5V5UJ+rzFGBBqaYHRzg/lNsXnxPq13bzUHH/o73?=
=?us-ascii?Q?tcuzU/hI3yPieDkgk683pZOiggh4AOrFdduNG7Jg/IdAD1h1r7AnUslIlsLV?=
=?us-ascii?Q?Vfvu3npYdtCxtP4F3bdcjI8FPohp2SiGGrwFc8zTeZqnECCca1q1oYfZ7z/i?=
=?us-ascii?Q?hcU6wwRb6bkWhNFe7/2VQ6REc1uPmQ2Mx8rs+4xfjfPpy9BnP8uW9DQZ4abs?=
=?us-ascii?Q?bmx2jRjQkbT7T7R80OU/XCOYGkMzKyGgPgU3c4FP3StcIL2WoDfJ4MJB4dc/?=
=?us-ascii?Q?JW7kr/7Wrb5phe9PCOKdIc2R4eWryI0kwMeQQulKjYaZqHQI+p62ciqNZkpC?=
=?us-ascii?Q?e+ZFeOJa7y5dfubkoTYSYMF+5qgr2QRG3EaZczF8yzX/Ys8lsx884xFiOZHY?=
=?us-ascii?Q?FQnz8YAszJPMDou/m3O9El/ft2C+6ZwLah4zW2suFJU9Sc7MiATYWsSxtFx2?=
=?us-ascii?Q?Y5gxQZohSjUhb7WKBiu3lNEplsYx7nBQsXemMIsR9b2aiPWFuhkEeJppv4xJ?=
=?us-ascii?Q?VloV8UqncYR+l9hjXtKr4h1EzlF6nnuutQjLJK5ncOWYe6qGH+j9ZNpKMJnA?=
=?us-ascii?Q?5o/gg0dcpao6qIDr8LWNxrde7SJfBEk4ubEcmRLwZ1z+0earI06pD2sNhX6P?=
=?us-ascii?Q?3XyUpRrTfMIMWgJIgiOZZXD33pPI3pJT9yDJ4RsbU8mcJGKnqXMAk8jAiw1F?=
=?us-ascii?Q?9YNbH6cYIKZXE7SBN4uo+NRaBVV/kGIRj9IH+94XdYRKZztEH5zpES8gzV88?=
=?us-ascii?Q?m3Ci3emXb9CH9GgdeqnbA5LaUU1UMqJik6O61wEX1pDF189ue41MmgBy1Fk5?=
=?us-ascii?Q?0FmLrFUkwwbr2y6r3mi+J9nXcs6qP+cbCsmA3CUcbO4Jbjk/mNtfmpP7w2Ab?=
=?us-ascii?Q?08Z38DnI8JD9i21d9JDJmjrbTBwLkqMOfthauFS+dc22xLKtsyUPdSPQ4cY7?=
=?us-ascii?Q?qOtxl5avZSHmkUfi8qBWVfGdEK8j478l24hARH1ZeMk7XPzKhLInR5dsn59E?=
=?us-ascii?Q?Wgue7sm5lD6eQb0+f9wTw1zNSawTJ0L+q+XpqTiXEVG3IoPBmYzQMt8qVOpj?=
=?us-ascii?Q?+kCS67vLwkqZM9ymUSANs6RzlOee8K+S43Apy9hYPajcTuqCAsxsdQaZCmnf?=
=?us-ascii?Q?D0tBtUaMwp7+DMTARZWVr4jqmyKOnNYRWKJJl0yZuK0SPON7HYAAHzqwWf53?=
=?us-ascii?Q?NxcXkFrsMA4nbZElLY0afdStlDtbmQ1cTU2o6pTU4OKE+g=3D=3D?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230040)(366016)(376014)(52116014)(1800799024)(38350700014); DIR:OUT;
SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ntTvlBskcPUJXBiLRYTtqfQCXxtXNuY65TWznAIRtQpupgz5CoL/QGRb3C++?=
=?us-ascii?Q?tt70GT4lQIdHSJhXMkF+LcPWiVxxTn74eykiyK7p5h9uuHnvOI8EoYsRA4GA?=
=?us-ascii?Q?O428Q1ZMcH8Q1lBAL7Y3AoGU2M7EgXWlkKA965DOsu2iYlZvgMtjdyCvyogS?=
=?us-ascii?Q?TQBcUefJFPweLHc/4SRvqF0LVakAb46sRjb8vGxt8KM0XTaP8BHS55DEfBB1?=
=?us-ascii?Q?GJTXNzHismR8fHn3shSXDcfs1AAu9GYgfzxGZlf85jXB3ixTXBhEXmlqPTWy?=
=?us-ascii?Q?xV0ZSvsgozo0i9/K8bCXAgIBjeQ1UmtioXhBg+uK4PUuxEkdP9Rf/JKh0Vw/?=
=?us-ascii?Q?czLDEWt24hA9Ew3eNDZesWg4oQwPIFOp+dWhexmeeSJ6oT/ko7hN1DQlHp3i?=
=?us-ascii?Q?919XoIeFffsAxHdfH1Np8udhoiIl1tjeJ2Vhb06yYBOkz8BqcFSu6mkg0zKy?=
=?us-ascii?Q?yWGy3SBERJ2+rX9g+owbzW9+N+lKcOVIT9hZVzyooo1rGP/frB9TKHXDb8yB?=
=?us-ascii?Q?Zo+JZgGvtqiOJz63ak+J0/xn+ZKkP6QRqgKlQzSlhU3De69yIz3J098HCrFE?=
=?us-ascii?Q?zjP/8kKDOYWDeOupin2M8d/gSSVkpBjcf7zuLUlaTKe0mOXFoeGiSlS+bDiQ?=
=?us-ascii?Q?2+iU59ni4NP3iVbOiOuYFcIgJ53r/34o7I83JRZwn+uxx0Wtx3XgoY38xQHu?=
=?us-ascii?Q?oR0EVy3aU5nIX9GEkSe3dF7DCWFYXvzboZJ6gutx/QaPj23XqAEPSbbLBOEc?=
=?us-ascii?Q?WDkxmgRlH0kV1Mr4YIm8VMtdOV3iX7bAkoVT5got8TJYAw6d7l64kLPZnSyZ?=
=?us-ascii?Q?xh7GUc+40MkFHSSYXCiNJBqu9n6I6lxPMFDQh55KqJEEpX65rSpJO7W2rQoF?=
=?us-ascii?Q?fHBJQ9ll9UADyhXeoMwhTsYveAI74KCSjGnmHF935TloblC8D+vxiOAxEajX?=
=?us-ascii?Q?tKCsNwkLHZ0GIWf9Gfc/Y2aR2V2PsTDBc5mvtFR0N3Ah53J7In0stk5QDSSf?=
=?us-ascii?Q?9VbUVDJ48QVmYSRsnRLaSqcIDTSE6G9hj179nd/56FXCnpzGwJ5/wKSz8noi?=
=?us-ascii?Q?p3njoU4oN8xTH8PBw4DeSP271ObCIQMkHoDPZY8UaaiQ6sNoPwSHIF4vtgMC?=
=?us-ascii?Q?DCGdP88wlxMtDxEnqPPLIm1BE01pLyslCBVg1lkZ7rFFbW6hTl8buW3v58+g?=
=?us-ascii?Q?UheVRc0mhOW3aFKj8j1sENu+/KIpkkp0GC/TsTC3iYTZOGMcFXjtgGchaYXV?=
=?us-ascii?Q?u4+8PLbndrLT9Jat0FUDGD5XtWsF6+balgTX+P1wXbXi64k4f0HubK7IdClT?=
=?us-ascii?Q?AZd7jWKRvnBEEOJpgp+4vCfr1ZOdoxyH4fb2P+J1+qBywssU3g+POfqFZHEH?=
=?us-ascii?Q?aJvCiFFRZoCUzOSbJTOJQYE6LHMSyW0RrGZ5td1UH5j2DYVCF2+Cdhgcb0Lu?=
=?us-ascii?Q?5q6VaKpUdvML6xnlx+xW0SUpsDiXB7P2pd5tzoylg/109AK2Ow/BXAuC2eGu?=
=?us-ascii?Q?Xh0oGqsgIwbFWDxi+szJ8AK1sIRZhD7GoNIXTFcdcBqcZReOF+NCfX32h7zF?=
=?us-ascii?Q?XlFPgGnVtxHJOxZXtrJiLJzoivVTR9LQO1ChQwIN9IqfFf04S3CqI1kNAFIt?=
=?us-ascii?Q?Pw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2851465e-d394-46a0-f393-08dce90c67cb
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 09:17:47.1794 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AlFf2olq/7L1yahnRCeKUezrtdG8drpYQD3SvXYpV+l8FeICnxzrUrLeyiMaOTEd9WBMDLlRG9dX1UwWM0xToWY5KqLDfDpQRzW6RXSWXYM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR13MB3980
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The return value of 'nfp_eth_set_configured()' is three ways, the
original logic considered it as two ways wrongly.
Fixes: 61d4008fe6bb ("net/nfp: support setting link up/down")
Cc: stable@dpdk.org
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/nfp_ethdev.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 405386e882..2fe6b1a292 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -527,26 +527,36 @@ nfp_net_start(struct rte_eth_dev *dev)
static int
nfp_net_set_link_up(struct rte_eth_dev *dev)
{
+ int ret;
struct nfp_net_hw *hw;
struct nfp_net_hw_priv *hw_priv;
hw = dev->data->dev_private;
hw_priv = dev->process_private;
- return nfp_eth_set_configured(hw_priv->pf_dev->cpp, hw->nfp_idx, 1);
+ ret = nfp_eth_set_configured(hw_priv->pf_dev->cpp, hw->nfp_idx, 1);
+ if (ret < 0)
+ return ret;
+
+ return 0;
}
/* Set the link down. */
static int
nfp_net_set_link_down(struct rte_eth_dev *dev)
{
+ int ret;
struct nfp_net_hw *hw;
struct nfp_net_hw_priv *hw_priv;
hw = dev->data->dev_private;
hw_priv = dev->process_private;
- return nfp_eth_set_configured(hw_priv->pf_dev->cpp, hw->nfp_idx, 0);
+ ret = nfp_eth_set_configured(hw_priv->pf_dev->cpp, hw->nfp_idx, 0);
+ if (ret < 0)
+ return ret;
+
+ return 0;
}
static void
--
2.39.1