From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF6DE45B1E; Sat, 12 Oct 2024 19:45:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6ACF840267; Sat, 12 Oct 2024 19:45:03 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 786D840265 for <dev@dpdk.org>; Sat, 12 Oct 2024 19:45:01 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-20caccadbeeso15541955ad.2 for <dev@dpdk.org>; Sat, 12 Oct 2024 10:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728755100; x=1729359900; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RoopXBkEZPW67kzDNcpaAZ0uaZ38U1iGU8U6RKDT0cE=; b=pV1rSi9b4C5wqaks7VsnmhkY8r91UQZj/VDeSe03IYE7vx1/FNQ2aYEVFhSXJOqHBX 8bXy90S3l2ktUz4ix8MaEv+XKfpnC3ieclAi9xwYJ4Us7mzQs7A6Jmr04PeQ4MJL+6dL 6u/ZlvPytkHkzZ377Cl+6r062rXDPawUfnCDWgY0LTdy3J77Ze9PI1fTN0DAA6qqZfre dlNmBJnFr4MNKmHnWMOmylZescxv2kmMTj7QyRYB9C53qUoK5C+Jzyro6whszZXhxlf9 FRuCKJkS33FyEWwGcYStjw+UdxcVAr+tqHxpn+IkJ83VaCpkzOO8tXrEdH4ZclDf9XVw o26g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728755100; x=1729359900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RoopXBkEZPW67kzDNcpaAZ0uaZ38U1iGU8U6RKDT0cE=; b=MgMNe3FTNpaquxHKhzKFiW0MsjTlWx9zEENs1/btIIRsYSk/OY8C1cSuXALfrGSYx2 hvBiSlLrBieKCvKGjdQkD4TI8tJAg8+OwSWS1pDaOHJvRptlSqWnTE+TGrz8pKZRXey1 7ljXWDKRkuInMP1/tvoTgR1IWTNJBjZEtkghqGfX4Au8czaWnVjB4vQdYJsQiiLEroKA kLTWVVJzxfCIiqDeRzQ+SXLH0FDeYE8M/dMngXJtbRRnNuxUH/r1Na6zHm68UETZPJ0w XS3MQfyQg+YwBEX5qabAuFaG4g2A1HcHS3uXPNSuQKjgDm1elGRi5xgwVB1vsd6Db6aK lGuQ== X-Forwarded-Encrypted: i=1; AJvYcCU+aiWb7KzWLrVU/TnK6g/WrbfsUaCiahN5OitV/3go3hrW7fiRkCfSfegu10LzN6FI9/U=@dpdk.org X-Gm-Message-State: AOJu0YwPp6RtqKXXRzbt8x8DtyUCsuSOaH3DqNRjw1iHOMdbQceZCHRu exkclCDVwSv+0yMYlN9/zkvVKgGzGtzWzHwJXzB2oyg2hhrB0uXlVYbFFbdAkTg= X-Google-Smtp-Source: AGHT+IFIas7PD/dQdAEddGCNRknY6oaP3xXfRcnEEkN2lniIXKsN5VKMfbyGhwvlA1bxcpElALU9MA== X-Received: by 2002:a17:902:e542:b0:20c:9285:e941 with SMTP id d9443c01a7336-20ca147f639mr70200155ad.27.1728755100496; Sat, 12 Oct 2024 10:45:00 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c3510bfsm39712885ad.294.2024.10.12.10.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2024 10:45:00 -0700 (PDT) Date: Sat, 12 Oct 2024 10:44:57 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Sivaprasad Tummala <sivaprasad.tummala@amd.com> Cc: <david.hunt@intel.com>, <anatoly.burakov@intel.com>, <jerinj@marvell.com>, <radu.nicolau@intel.com>, <gakhil@marvell.com>, <cristian.dumitrescu@intel.com>, <ferruh.yigit@amd.com>, <konstantin.ananyev@huawei.com>, <dev@dpdk.org> Subject: Re: [PATCH v3 0/5] power: refactor power management library Message-ID: <20241012104457.60770481@hermes.local> In-Reply-To: <20241008174309.1133051-1-sivaprasad.tummala@amd.com> References: <20241008172719.902619-1-sivaprasad.tummala@amd.com> <20241008174309.1133051-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, 8 Oct 2024 17:43:03 +0000 Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers/power/uncore/*'. > > This refactor significantly improves code organization, enhances > clarity, and boosts maintainability. It lays the foundation for more > focused development on individual drivers and facilitates seamless > integration of future enhancements, particularly the AMD uncore driver. > > Furthermore, this effort aims to streamline code maintenance by > consolidating common functions for cpufreq and cppc across various > core drivers, thus reducing code duplication. > > Sivaprasad Tummala (5): > power: refactor core power management library > power: refactor uncore power management library > test/power: removed function pointer validations > power/amd_uncore: uncore support for AMD EPYC processors > maintainers: update for drivers/power Looks good but several build failures. It looks like the new internal function to get power ops is not in version.map. Also while looking, if I use IWYU it shows that errno.h and rte_errno.h are included but never used.