From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F7C145B3B; Mon, 14 Oct 2024 21:41:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57475402C3; Mon, 14 Oct 2024 21:41:39 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 7F2184026C for ; Mon, 14 Oct 2024 21:41:37 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-207115e3056so37646035ad.2 for ; Mon, 14 Oct 2024 12:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728934896; x=1729539696; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=etKEId9rQdt307n4uYbhRyUzF+6V3pNM+hdKm8U9eQw=; b=0iExxNUNS2HabBMWorj+SKvgOOyik4C8PuEojtUSUznPTImKSOCLrHzms/lmGNd9Wq R52E7KL/KeVB1XQfKsxlCK1F+ZOsw6mYqqMICQVEEHxnxX7xF0Wo+j1xXKv1aWb+5w+h g2HD4oVbMfjgPOFNdHUGjJ+RN80oCC7ixARE0QyDDMxZEasf0ljkzQjUCvvEE1ddfLrB UfrVKplohnwKDAEEQHQbERWypBD/T4sMb4IffnZ6YEqFT2sakQ0A2KA2qZNimqQTSGXD FNMos62ybLCCH63dUZ+uKfpR/QB7mkrgxCaXyyZRY1N5z7Gl20H6/jX6XPJyvSBfim9X QeTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728934896; x=1729539696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=etKEId9rQdt307n4uYbhRyUzF+6V3pNM+hdKm8U9eQw=; b=j20C3a1dtKO94oGbHbtOC/khYryS6pdfIIbDRWaHBWjagMcB3ZY1KzJ9IESMqOaeeF bSO0mb1jUTolI/gekjpAGnCcRvoQoSMvr521XVw0EjDAdNCg+HyeJFic2CZRYQ9fJWQ8 nJCVe692nRGRY0NbJrUqnz+pRTYchvcJjNmd+H/9/rcq5xNg9arSjGjgVC0wrBIh4xxq tv203jDFv44yeKnVkTyDNCAhcmCQ3j0iA0/z64XFduAyoN0oHxNSutOLtGrNCHCcq/WI YjkX714mUECUDB40EokNZc8epymQztpYzmPk0gqjzP0EYFt90uhONCkNfFPiPXRhaL4A ShHw== X-Gm-Message-State: AOJu0Yw1tHG76PKrl96WtdK/LRMYhNXhIQEkBZd7m/36fWN+5Bi/7BsU r3yDTRYXObXqs9WN3MSGG7IiAKBdWoiqxe2uaOuQLX6yQ2L8spPWVZsaoVJvBoY= X-Google-Smtp-Source: AGHT+IGfqnKaB23jlezv1meOi0BgDnnInJDc+ZYUf6+zoIbZheC98v+RosPjnYTNaTCpvkI1Bk54Hw== X-Received: by 2002:a17:902:fc8f:b0:20b:cae5:dec4 with SMTP id d9443c01a7336-20ca146699emr181204915ad.24.1728934896584; Mon, 14 Oct 2024 12:41:36 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8c0eb7a2sm69651335ad.157.2024.10.14.12.41.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 12:41:36 -0700 (PDT) Date: Mon, 14 Oct 2024 12:41:32 -0700 From: Stephen Hemminger To: Sriharsha Basavapatna Cc: dev@dpdk.org, Shahaji Bhosle , Randy Schacher , Kishore Padmanabha , Ajit Khaparde Subject: Re: [PATCH v4 01/47] net/bnxt: tf_core: fix wc tcam multi slice delete issue Message-ID: <20241014124132.7e0069c8@hermes.local> In-Reply-To: <20241004175338.3156160-2-sriharsha.basavapatna@broadcom.com> References: <20241004175338.3156160-1-sriharsha.basavapatna@broadcom.com> <20241004175338.3156160-2-sriharsha.basavapatna@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 4 Oct 2024 23:22:52 +0530 Sriharsha Basavapatna wrote: > From: Shahaji Bhosle >=20 > FW tries to update the HWRM request data in the > delete case to update the mode bit and also > update invalid profile id. This update only > happens when the data is send over DMA. HWRM > requests are read only buffers and cannot be > updated. So driver now will always send WC > tcam set message over DMA channel. >=20 > Update tunnel alloc apis to provide error message. >=20 > Fixes: ca5e61bd562d ("net/bnxt: support EM and TCAM lookup with table sco= pe") > Reviewed-by: Randy Schacher > Reviewed-by: Kishore Padmanabha > Signed-off-by: Shahaji Bhosle > Signed-off-by: Sriharsha Basavapatna > Reviewed-by: Ajit Khaparde > --- The patch series needs to be rebased, there is some fuzz and git doesn't li= ke to apply. Also, not every patch builds. For example after applying the first patch the build fails with: ../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c: In function =E2=80=98bnxt_tu= nnel_dst_port_alloc=E2=80=99: ../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:40:17: error: implicit declar= ation of function =E2=80=98PMD_DRV_LOG=E2=80=99; did you mean =E2=80=98PMD_= DRV_LOG_LINE=E2=80=99? [-Wimplicit-function-declaration] 40 | PMD_DRV_LOG(ERR, "Tunnel type:%d alloc failed for p= ort:%d error:%s\n", | ^~~~~~~~~~~ | PMD_DRV_LOG_LINE ../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:40:17: warning: nested extern= declaration of =E2=80=98PMD_DRV_LOG=E2=80=99 [-Wnested-externs] ../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:40:29: error: =E2=80=98ERR=E2= =80=99 undeclared (first use in this function) 40 | PMD_DRV_LOG(ERR, "Tunnel type:%d alloc failed for p= ort:%d error:%s\n", | ^~~ ../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:40:29: note: each undeclared = identifier is reported only once for each function it appears in ../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c: In function =E2=80=98bnxt_pm= d_global_tunnel_set=E2=80=99: ../drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c:601:37: error: =E2=80=98ERR= =E2=80=99 undeclared (first use in this function) 601 | PMD_DRV_LOG(ERR, "Tunnel type:%d alloc fail= ed for port:%d error:%s\n", | ^~~ [16/2343] Compiling C object drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_tf_ul= p_ulp_mapper.c.o