* [PATCH v1 1/1] net/octeon_ep: fix return code
@ 2024-10-15 7:25 Vamsi Krishna
2024-10-24 6:15 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: Vamsi Krishna @ 2024-10-15 7:25 UTC (permalink / raw)
To: jerinj; +Cc: dev, Vamsi Attunuru
From: Vamsi Attunuru <vattunuru@marvell.com>
In the changeset 304ba46be396, a goto statement was
mistakenly added after a return statement. This patch
corrects the code by removing the erroneous return.
Coverity issue: 445484
Fixes: 304ba46be396 ("net/octeon_ep: handle device removal on probe")
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
---
drivers/net/octeon_ep/otx_ep_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c b/drivers/net/octeon_ep/otx_ep_ethdev.c
index 42cfe4250c..b4f8baf3b3 100644
--- a/drivers/net/octeon_ep/otx_ep_ethdev.c
+++ b/drivers/net/octeon_ep/otx_ep_ethdev.c
@@ -849,7 +849,7 @@ otx_ep_eth_dev_init(struct rte_eth_dev *eth_dev)
otx_ep_info("Using pkind %d.", otx_epvf->pkind);
} else {
otx_ep_err("Invalid chip id");
- return -EINVAL;
+ ret = -EINVAL;
goto exit;
}
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] net/octeon_ep: fix return code
2024-10-15 7:25 [PATCH v1 1/1] net/octeon_ep: fix return code Vamsi Krishna
@ 2024-10-24 6:15 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2024-10-24 6:15 UTC (permalink / raw)
To: Vamsi Krishna; +Cc: jerinj, dev
On Tue, Oct 15, 2024 at 1:09 PM Vamsi Krishna <vattunuru@marvell.com> wrote:
>
> From: Vamsi Attunuru <vattunuru@marvell.com>
>
> In the changeset 304ba46be396, a goto statement was
> mistakenly added after a return statement. This patch
> corrects the code by removing the erroneous return.
>
> Coverity issue: 445484
> Fixes: 304ba46be396 ("net/octeon_ep: handle device removal on probe")
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Applied to dpdk-next-net-mrvl/for-main. Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-24 6:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-15 7:25 [PATCH v1 1/1] net/octeon_ep: fix return code Vamsi Krishna
2024-10-24 6:15 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).