From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A533345A78; Tue, 15 Oct 2024 19:42:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CBCC4025E; Tue, 15 Oct 2024 19:42:26 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id 1F042400D7 for ; Tue, 15 Oct 2024 19:42:25 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7ea80863f12so1103993a12.1 for ; Tue, 15 Oct 2024 10:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729014144; x=1729618944; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5ZKe+R+Ppo+hCwrMJ30aXucEsYv9Vw7IxIRt7Da7i/c=; b=ME17r8lIdZxOkKNXcIronFrQahm8upl3R7epJ+6w62ju5SLiYxPpRggiAWaWKWlTZh 0+KFd3LWtNd49KfuaHSRBczzvJjh5jOxObz/H6+z9y7H28fLwv9QFhxblZgreqFRvXj3 Pm/O5gnj3oDpX0ChT1c6UhMhBesyKHjTH+1uW40Qvm6ilLi6xzwSLogg39PQCUyudTRH 61BSFdgOCGlRJNaBhHjVQl9caWIjD2iOqfIUyyReJbR+xRlDZa9PnIgBpSR+AMRSkoGR 4xtg7kdg2XGuHl11rNY4WNAhCuDZgXke4d+Xhwm3Wx1OzjQ647xkIuNBPLCFBUMIq9p/ mNtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729014144; x=1729618944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5ZKe+R+Ppo+hCwrMJ30aXucEsYv9Vw7IxIRt7Da7i/c=; b=Ks/xuxiEDNlSAjVu/z9Jb75UUTWXSV1iKGY91IFGxkUxjC7EyvmIWeXZzlVBeOQ5TK wAHgEcdc0p5YUBml0fVyK2WL3JO5WlmpvGe+RDEfp89nqNW4qq9BAlKpjf/goCzqqNPW hnIqcQuc2s+E41R+qIRIhxKi9My/ldmYJ2s5/P2tQI4LMLJtfb6CkZ1r37DjBhgdCQ3I 4Q5CFenrsQXx/fg8+Zrhqk34KXpt6TAwVC+j4kpYmBbbIgcapDLLf9GQillio/ot6LzO vCEXENw0cUZ5c+qYsHea7hMA4irARxhb3IdBFk2b/ZK7OfskCL6628BPAHBHFWMKjH5d qDRw== X-Gm-Message-State: AOJu0YyDECXxwObafxSelcqn2pRGuPo0aCXgY78hGsD7W9fiQ8QkbkPu 4kSNBRmUJtYcNRpLk1cS+CMKD1yNgs5YfzokjR8K2p4u5RroTGLI9+kWzNSogoo= X-Google-Smtp-Source: AGHT+IHqZ9vekOMBmGUFBkiY/k2YG4Hxm/cp4HjSFmfs7ExvJwABdixvgQE/99dZVFDIf9iviMTLOA== X-Received: by 2002:a05:6a20:d504:b0:1cf:27bf:8e03 with SMTP id adf61e73a8af0-1d905effaa4mr1377675637.26.1729014144005; Tue, 15 Oct 2024 10:42:24 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ea9c728767sm1628119a12.93.2024.10.15.10.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 10:42:23 -0700 (PDT) Date: Tue, 15 Oct 2024 10:42:22 -0700 From: Stephen Hemminger To: Mingjin Ye Cc: dev@dpdk.org, Simei Su , Wenjun Wu , Kirill Rybalchenko Subject: Re: [PATCH v2 3/3] examples/ptpclient: add frequency adjustment support Message-ID: <20241015104222.2ee0fbe3@hermes.local> In-Reply-To: <20240906051939.879071-4-mingjinx.ye@intel.com> References: <20240906051939.879071-1-mingjinx.ye@intel.com> <20240906051939.879071-4-mingjinx.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 6 Sep 2024 05:19:39 +0000 Mingjin Ye wrote: > This patch adds PI servo algorithm to support frequency > adjustment API for IEEE1588 PTP. >=20 > For example, the command for starting ptpclient with PI algorithm is: > ./build/examples/dpdk-ptpclient -a 0000:81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 > --controller=3Dpi >=20 > Signed-off-by: Simei Su > Signed-off-by: Wenjun Wu > Signed-off-by: Mingjin Ye Looks like missing include, build is failing *Build Failed #1: OS: OpenAnolis8.9-64 Target: x86_64-native-linuxapp-gcc FAILED: examples/dpdk-ptpclient.p/ptpclient_ptpclient.c.o=20 gcc -Iexamples/dpdk-ptpclient.p -Iexamples -I../examples -Iexamples/ptpclie= nt -I../examples/ptpclient -I../examples/common -I. -I.. -Iconfig -I../conf= ig -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/= eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/= common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kva= rgs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -= I../lib/telemetry -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -= Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/ethdev -I../lib/ethdev= -Ilib/meter -I../lib/meter -Ilib/cmdline -I../lib/cmdline -fdiagnostics-co= lor=3Dalways -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werror -= std=3Dc11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wfor= mat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototype= s -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -W= strict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-miss= ing-field-initializers -D_GNU_SOURCE -march=3Dnative -mrtm -Wno-format-trun= cation -DALLOW_EXPERIMENTAL_API -MD -MQ examples/dpdk-ptpclient.p/ptpclient= _ptpclient.c.o -MF examples/dpdk-ptpclient.p/ptpclient_ptpclient.c.o.d -o e= xamples/dpdk-ptpclient.p/ptpclient_ptpclient.c.o -c ../examples/ptpclient/p= tpclient.c ../examples/ptpclient/ptpclient.c: In function =E2=80=98port_init=E2=80=99: ../examples/ptpclient/ptpclient.c:302:12: error: implicit declaration of fu= nction =E2=80=98rte_eth_timesync_adjust_freq=E2=80=99; did you mean =E2=80= =98rte_eth_timesync_adjust_time=E2=80=99? [-Werror=3Dimplicit-function-decl= aration] retval =3D rte_eth_timesync_adjust_freq(port, 0); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ rte_eth_timesync_adjust_time ../examples/ptpclient/ptpclient.c:302:12: error: nested extern declaration = of =E2=80=98rte_eth_timesync_adjust_freq=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors [2975/3043] Generating examples/multi_process/simple_mp/commands_hdr with a= custom command (wrapped by meson to capture output) [2976/3043] Linking target examples/dpdk-l2fwd-keepalive [2977/3043] Linking target examples/dpdk-l3fwd-graph [2978/3043] Linking target examples/dpdk-l3fwd [2979/3043] Compiling C object examples/dpdk-l3fwd-power.p/l3fwd-power_main= .c.o [2980/3043] Compiling C object examples/dpdk-mp_server.p/multi_process_clie= nt_server_mp_mp_server_main.c.o [2981/3043] Linking target examples/dpdk-l2fwd-macsec [2982/3043] Linking target examples/dpdk-hotplug_mp [2983/3043] Linking target examples/dpdk-link_status_interrupt ninja: build stopped