From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6236945B51; Wed, 16 Oct 2024 17:04:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5282240150; Wed, 16 Oct 2024 17:04:28 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 783A8400D6 for <dev@dpdk.org>; Wed, 16 Oct 2024 17:04:27 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-71e592d7f6eso2719462b3a.3 for <dev@dpdk.org>; Wed, 16 Oct 2024 08:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729091066; x=1729695866; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fAzYOesEYMbfMqqo8CSdiekjqWK9gDVrImEel0awMkM=; b=mH5wvNrHMC2hx1rIrvKDqciNiamkG20akH9EoQDotS7H9Y9zdYkSfmonQLZqzr0T3Z yZTFW4b/pkMQT39xbWH2zsZySs/PycRzMRfuTRQcEvxryD8o8eI7lpRhPRXhNLVz0h3Y taiIPmTE9zJ5tD9K41mVwpbfRv6/+aLdDjnur2eA/5qgN5Fji8yWCb7rsTd5U0kg9/J/ vbBM7in71NIWneM4xkNFID2OIY2CV9AF97dUilxaTzM9QtE7vLY971U+EmYesIAvuFzN PQ84BNT+DPZTVx4niu8Y87CDQ34j802QCUUQXuQrPWp5/7lHtMgURV16yW+yEyGJBpz7 y/BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729091066; x=1729695866; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fAzYOesEYMbfMqqo8CSdiekjqWK9gDVrImEel0awMkM=; b=DzgUt5FFBZgBttGSi0C0whiAiGLZlFJAZa5wHdlFWrxfpq9g4jEmlueKgxmFZw/Ixr qOhAKPf3XP9HzRoXn4fd3KrMmPmP06H5I+1FNeE6M/YgSTjdsnrrsb6Vd+AB/3BGP5a5 yQkaO4PN5hryMBDyGR3sgiokTpMnF2QEseHywTecCyESt1nCPDWHdVyv4z3q67+rS6n4 xpMZPm61W855eBJEWOud4OqfKkEYeO/E3enlMZfYallk2hYcaTSGFz8IqYBBXE3rDweC C3ikZq8LchgMmnOHseo3QmkTiaBMPt3IxxwMaGtUXzzzzYGaFjf4BS99R4Uz0sy/Jt45 jJPw== X-Gm-Message-State: AOJu0YwNtuVDxoSUURM3NEqwPWGppThgAV7FfksNIfgMOZKRbZ5cX7YY pgUqpWdSGM+nuiAPXMlFpuCL8A8O0PbTFtyfWoM9k/kuCkKcDS0pk+pcxkSv9jw= X-Google-Smtp-Source: AGHT+IEDodl1Brv3ML6mCfqk2j57CXoAWW79bZiwynFPBOHnWyiKKZEgwsrxiC2vt4BonPa3mo6bFg== X-Received: by 2002:a05:6a20:9c93:b0:1d9:9c6:5e7f with SMTP id adf61e73a8af0-1d909c661c2mr4345786637.4.1729091066554; Wed, 16 Oct 2024 08:04:26 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e774a2b37sm3163964b3a.112.2024.10.16.08.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 08:04:26 -0700 (PDT) Date: Wed, 16 Oct 2024 08:04:24 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= <mattias.ronnblom@ericsson.com> Cc: <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, Mattias =?UTF-8?B?UsO2bm5ibG9t?= <hofors@lysator.liu.se> Subject: Re: [PATCH 2/2] devtools: forbid the use of ffs compiler builtins Message-ID: <20241016080424.3f614ac2@hermes.local> In-Reply-To: <20241016135411.827850-2-mattias.ronnblom@ericsson.com> References: <20241016135411.827850-1-mattias.ronnblom@ericsson.com> <20241016135411.827850-2-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, 16 Oct 2024 15:54:11 +0200 Mattias R=C3=B6nnblom <mattias.ronnblom@ericsson.com> wrote: > Extend checkpatches.sh to detect the use of __builtin_(ffs|ffsll). >=20 > These intrinsics are not available in MSVC, and there are perfectly > serviceable alternatives in <rte_bitops.h>. >=20 > Signed-off-by: Mattias R=C3=B6nnblom <mattias.ronnblom@ericsson.com> > Suggested-by: David Marchand <david.marchand@redhat.com> Shouldn't this apply to all _builtin_ functions. There are a lot of drivers still doing this.