From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0A0D945B50;
Wed, 16 Oct 2024 15:28:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9964540656;
Wed, 16 Oct 2024 15:28:33 +0200 (CEST)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
(mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69])
by mails.dpdk.org (Postfix) with ESMTP id 26E754042C
for <dev@dpdk.org>; Wed, 16 Oct 2024 15:28:27 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=nXIOMHc0BsfkgxzyyZitcKbdCTw5iv29SWPac2tLfkkSC4wP6Y4j/UN0EFH4BapXnL8BxQZN7BFHHHQOUl01sdeqV1Nq514SoSCi503w9yGvBakeiaC5zVDVH7Y+/hLwgD7LLMTb+H3L8174+mSuvtroW7cga7nH86u+wJVQHThdqmuDSU+G38yM/8xEmDhyAtjNegK5WZm+YWobNx/sMrBaLzbslB/TDuLMKEO+vwRQiVcvbBvNeQHy7pE4uDrjOA/znTHYanZ0mAtRs10mNE9aUe+2dY3E7DrFXf7zOm9WZGoDD6tvK5lvFSv3v2sO2atOc32JHxKDqVYnnl6n7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=bZe54tHV1BWuXkkOzb0KIXBGV4vegSrp2GI9ZzhuZjE=;
b=AOYPY6/1UfeaZfgnn7pEeJkruk10Imx5b3eg459GhyJDCkS8lI73PuKHRf2B+FXOEC7L6UEc8NLv0IkhkhbVAFhW7uVEYYOIHf4hRcyICBXrTTiSr02DtTww+SwQTEJ73hMHrAXzRQOGO7bETIw7BF3oTCKjNhpQ//VkLqq7f6KXR6pyFE6BHQIp8K3cJcBm1L+Ui7bVRidj5PE+4Zqrq+TExDHuxwmaJWUt4+DTZRJgijxAEbYNzEX4fTcjwfbilS3V9tq+ALpx8UugHH5p44B+CI9RTCK89TO11QKiDZ1XIgWqiNi9LcIGbFTrLRnaIysnxkU5VgWBElTiMFIkLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;
dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;
dkim=none (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=bZe54tHV1BWuXkkOzb0KIXBGV4vegSrp2GI9ZzhuZjE=;
b=Edh3LfVxvH93jlV1QYOCEGFoqBCTJMofcirpZM+olY2qTJMZTOgcOfO3LDCn23l/c6WxmYuJTImaz+XyK1iNdbBwV9Ji+9pGOydDEY4Qk4eYWV1CUXkamBVEPex3S+WwPOsHJgv19BFifSKUeEeY7s7fEJJ8ZBKqKOz1vv3bc7+oQcWpe3AdV0o0/zHry8bcnd9QfHUsG2UQJkwYKo6TLTbAuxq2MrRV0L1qiWDxAarybJHLeMW3oSPY13FXOvzeqn75zNGFICbjgkSJkQfkrtMyZ7mSM5pcqniPpscg4ID8MWEbcI9mJt3lpIcpUovOF3bbAtlzy8h1/DAxPzTeYA==
Received: from AM0PR01CA0101.eurprd01.prod.exchangelabs.com
(2603:10a6:208:10e::42) by DU2PR07MB9450.eurprd07.prod.outlook.com
(2603:10a6:10:49c::21) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27; Wed, 16 Oct
2024 13:28:22 +0000
Received: from AM3PEPF0000A795.eurprd04.prod.outlook.com
(2603:10a6:208:10e:cafe::9d) by AM0PR01CA0101.outlook.office365.com
(2603:10a6:208:10e::42) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18 via Frontend
Transport; Wed, 16 Oct 2024 13:28:22 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74)
smtp.mailfrom=ericsson.com; dkim=none (message not signed)
header.d=none;dmarc=pass action=none header.from=ericsson.com;
Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates
192.176.1.74 as permitted sender)
receiver=protection.outlook.com;
client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C
Received: from oa.msg.ericsson.com (192.176.1.74) by
AM3PEPF0000A795.mail.protection.outlook.com (10.167.16.100) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8069.17 via Frontend Transport; Wed, 16 Oct 2024 13:28:22 +0000
Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by
smtp-central.internal.ericsson.com (100.87.178.62) with Microsoft SMTP Server
id 15.2.1544.11; Wed, 16 Oct 2024 15:28:21 +0200
Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])
by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id
0D0C81C0079; Wed, 16 Oct 2024 15:28:21 +0200 (CEST)
From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
To: <dev@dpdk.org>
CC: <hofors@lysator.liu.se>, =?UTF-8?q?Morten=20Br=C3=B8rup?=
<mb@smartsharesystems.com>, Stephen Hemminger <stephen@networkplumber.org>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, David Marchand
<david.marchand@redhat.com>, Jerin Jacob <jerinj@marvell.com>, Luka Jankovic
<luka.jankovic@ericsson.com>, =?UTF-8?q?Mattias=20R=C3=B6nnblom?=
<mattias.ronnblom@ericsson.com>, Konstantin Ananyev
<konstantin.ananyev@huawei.com>, Chengwen Feng <fengchengwen@huawei.com>
Subject: [PATCH v14 6/7] service: keep per-lcore state in lcore variable
Date: Wed, 16 Oct 2024 15:19:15 +0200
Message-ID: <20241016131916.827788-7-mattias.ronnblom@ericsson.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20241016131916.827788-1-mattias.ronnblom@ericsson.com>
References: <20241015093344.824073-2-mattias.ronnblom@ericsson.com>
<20241016131916.827788-1-mattias.ronnblom@ericsson.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AM3PEPF0000A795:EE_|DU2PR07MB9450:EE_
X-MS-Office365-Filtering-Correlation-Id: b48f34d4-3530-4cb8-4c0e-08dcede66850
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
ARA:13230040|376014|82310400026|1800799024|36860700013;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?L1kwd0QwYlIvRGMxdTZvYlFzSm0xakRLbmVmZkNjZEh6anpZZmhZNmVHd0lo?=
=?utf-8?B?Y2FtM0IzREtQYmV1SEJlMTVnaGlRTEVuM29UTy8rVmEyMlhRSUpXSktYN2ho?=
=?utf-8?B?S0VxRnhVOEw0dVM1cFFKM1ZSMUd2NnZpSjVtK0E1dFpmdGhYR1gyY1dXNE5W?=
=?utf-8?B?SFZXYUhjaUJUREcrZHBRTzNKcWdxL0hUalNsTmU5M1cwc040N3U5OVJ6OS9r?=
=?utf-8?B?M3ZRSndodjJLSC96TUNxUWNYeStwRVRDUWZXZXF3Ly9iTHNmRmQ2T0tJMHRl?=
=?utf-8?B?c0kyTjdId045VmVTYnhQcVQrdzFPdnFVcURNbE9ldktEY3VmWWNIeTdVL1Zq?=
=?utf-8?B?UWlCZ21YSzRlNFdwL1hENjd4SlA4Qyt5REJCa2ZSaFlhRkpzUkhXcVZjQ0o3?=
=?utf-8?B?UTY5SnQvMDBENU9wSFEzWUdHcHd4TWhVLy9WNmI3K05wQXh4aldQNXNha0I3?=
=?utf-8?B?UjBqWis5TytYc3ZqanlVZ2FUcWRwejFNTDFENVlNOXB6ZFlQNnk5WFE0NHNn?=
=?utf-8?B?TFUyZm9qSGF0dWFyRXB4NlNONUxLcmYvdXpaM25yY290aWFFdWVjQVhiZUN5?=
=?utf-8?B?RkdPRnJNbTdFSTFmL2ZURmNXcGEwZHdLWVk1S1RqSlNGQ3R6cHlaTER1K2xJ?=
=?utf-8?B?dmp3bTZFYW1FRVJlWTJrazgrSlI4OTZwQzJhc2dyVzB5Z2dlSHNwakN3YU5C?=
=?utf-8?B?M3NaaWFZaFNtV2xmVGZnN09CclJWVVcvTjJHK09RMnZZNGNXV3REUUliVWE3?=
=?utf-8?B?TEEyaEFCSnVaY0h5NVhMOHptNW9LZWNmdmtmdWtBOW1vWmhTLzdyTzRyWlFr?=
=?utf-8?B?NEJERGJjcUJCVmFSbVRoTkZGbmU1dW1sdFhIZGtzYmxrQUJBR2NCSFFiRFFT?=
=?utf-8?B?NlhDVVFYWDlQRk1UNnlvSjFRUDJaMFRxRWh1VUgvTTlUSFFyVWtDbTR1QnBL?=
=?utf-8?B?NHRTK3dtRW5PL29BeTd6amdPTnN2MjhwVlFSM2xnTjU2bzRGNE44aTllRVVQ?=
=?utf-8?B?LzhOdGd1ZmVDcVhsU2J2THBPQ2x5amx4WnRZSW9uSy8zbmZrTFRjSGNadkhE?=
=?utf-8?B?S3BOcFJBU2xsa0dGa2w1d3A1QzRONTB4Y2xhOEZLU0Y2RmJ3RTJ6S2V0dXEy?=
=?utf-8?B?emNlNFp6c3YxN2RZTWFMUms5ZDZUTENWRUhSMExBdDdIOGVSSnZPS29qMHQz?=
=?utf-8?B?eCttUHFwdHlzdkFwcmdaS3B2WnhpMTVpaURnMmZzUlVkeHZNaGlvME95bUpm?=
=?utf-8?B?SURjbDA1VzVmTzA1VnVFem4rK092aHVJVGdiblphTUVlTlNJYnB5ZWk2OWlj?=
=?utf-8?B?RGtad3NZMzE2NDNsU2I5WCs0cFVVWXBWaitqb055YjEwZ01nYU5oTWgxWjg4?=
=?utf-8?B?R1lzcjlBVFFoNUJHOUVoUmVIWFFZSWRIL3ViTlI2Sk02eHlNbTFOQThSdlpX?=
=?utf-8?B?aFhsV0NiN1BFQjNaR1RBNlpCWVNYZThWdkJZMG9MemlnVHRCcXhjTjlUa2hM?=
=?utf-8?B?R3c0Y1o4eGNWU2V3dHdpVkd4Ly9kOVc1aTNBczEyME1uMTB2TGZWTU9ZT3lr?=
=?utf-8?B?ZU1QemFxcHpCVUE5K3NDZkZqV2lzTmpsTElFZTVCYjkwNVZNUVRJSm9Zd3Vj?=
=?utf-8?B?N1N3Q3pBMitzQXA3U241dmNWTzNnWkNPamJzTzZ6L2lWOTZTU3JZcU1uV1ND?=
=?utf-8?B?b0ZpMDBZclBhQzhpekxyZzdGTmxQdUcvaHlVZTNjcjc0RjBuL1VjdGJQbUdB?=
=?utf-8?B?M3J4cHltNlZUU2gyM1BUb2FkMmdpbGVjT1ZkU3A2SUV6K1RsTVp4eFBOVC9X?=
=?utf-8?B?bVV3bXFRTFZTdVowbUord05PZTBDU1czc1BkWG1mOUludlBCeU1zaFpQcXBq?=
=?utf-8?Q?UrUNRgllYPGtq?=
X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;
CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013);
DIR:OUT; SFP:1101;
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2024 13:28:22.7652 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b48f34d4-3530-4cb8-4c0e-08dcede66850
X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];
Helo=[oa.msg.ericsson.com]
X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A795.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR07MB9450
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Replace static array of cache-aligned structs with an lcore variable,
to slightly benefit code simplicity and performance.
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
--
PATCH v14:
* Merge with bitset-related changes.
PATCH v7:
* Update to match new FOREACH API.
RFC v6:
* Remove a now-redundant lcore variable value memset().
RFC v5:
* Fix lcore value pointer bug introduced by RFC v4.
RFC v4:
* Remove strange-looking lcore value lookup potentially containing
invalid lcore id. (Morten Brørup)
* Replace misplaced tab with space. (Morten Brørup)
---
lib/eal/common/rte_service.c | 116 ++++++++++++++++++++---------------
1 file changed, 65 insertions(+), 51 deletions(-)
diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c
index 324471e897..dad3150df9 100644
--- a/lib/eal/common/rte_service.c
+++ b/lib/eal/common/rte_service.c
@@ -11,6 +11,7 @@
#include <eal_trace_internal.h>
#include <rte_lcore.h>
+#include <rte_lcore_var.h>
#include <rte_bitset.h>
#include <rte_branch_prediction.h>
#include <rte_common.h>
@@ -78,7 +79,7 @@ struct __rte_cache_aligned core_state {
static uint32_t rte_service_count;
static struct rte_service_spec_impl *rte_services;
-static struct core_state *lcore_states;
+static RTE_LCORE_VAR_HANDLE(struct core_state, lcore_states);
static uint32_t rte_service_library_initialized;
int32_t
@@ -99,12 +100,8 @@ rte_service_init(void)
goto fail_mem;
}
- lcore_states = rte_calloc("rte_service_core_states", RTE_MAX_LCORE,
- sizeof(struct core_state), RTE_CACHE_LINE_SIZE);
- if (!lcore_states) {
- EAL_LOG(ERR, "error allocating core states array");
- goto fail_mem;
- }
+ if (lcore_states == NULL)
+ RTE_LCORE_VAR_ALLOC(lcore_states);
int i;
struct rte_config *cfg = rte_eal_get_configuration();
@@ -120,7 +117,6 @@ rte_service_init(void)
return 0;
fail_mem:
rte_free(rte_services);
- rte_free(lcore_states);
return -ENOMEM;
}
@@ -134,7 +130,6 @@ rte_service_finalize(void)
rte_eal_mp_wait_lcore();
rte_free(rte_services);
- rte_free(lcore_states);
rte_service_library_initialized = 0;
}
@@ -284,7 +279,6 @@ rte_service_component_register(const struct rte_service_spec *spec,
int32_t
rte_service_component_unregister(uint32_t id)
{
- uint32_t i;
struct rte_service_spec_impl *s;
SERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);
@@ -292,9 +286,11 @@ rte_service_component_unregister(uint32_t id)
s->internal_flags &= ~(SERVICE_F_REGISTERED);
+ unsigned int lcore_id;
+ struct core_state *cs;
/* clear the run-bit in all cores */
- for (i = 0; i < RTE_MAX_LCORE; i++)
- rte_bitset_clear(lcore_states[i].mapped_services, id);
+ RTE_LCORE_VAR_FOREACH(lcore_id, cs, lcore_states)
+ rte_bitset_clear(cs->mapped_services, id);
memset(&rte_services[id], 0, sizeof(struct rte_service_spec_impl));
@@ -463,7 +459,10 @@ rte_service_may_be_active(uint32_t id)
return -EINVAL;
for (i = 0; i < lcore_count; i++) {
- if (rte_bitset_test(lcore_states[ids[i]].service_active_on_lcore, id))
+ struct core_state *cs =
+ RTE_LCORE_VAR_LCORE(ids[i], lcore_states);
+
+ if (rte_bitset_test(cs->service_active_on_lcore, id))
return 1;
}
@@ -473,7 +472,7 @@ rte_service_may_be_active(uint32_t id)
int32_t
rte_service_run_iter_on_app_lcore(uint32_t id, uint32_t serialize_mt_unsafe)
{
- struct core_state *cs = &lcore_states[rte_lcore_id()];
+ struct core_state *cs = RTE_LCORE_VAR(lcore_states);
struct rte_service_spec_impl *s;
SERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);
@@ -496,8 +495,7 @@ static int32_t
service_runner_func(void *arg)
{
RTE_SET_USED(arg);
- const int lcore = rte_lcore_id();
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs = RTE_LCORE_VAR(lcore_states);
rte_atomic_store_explicit(&cs->thread_active, 1, rte_memory_order_seq_cst);
@@ -533,13 +531,15 @@ service_runner_func(void *arg)
int32_t
rte_service_lcore_may_be_active(uint32_t lcore)
{
- if (lcore >= RTE_MAX_LCORE || !lcore_states[lcore].is_service_core)
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
+
+ if (lcore >= RTE_MAX_LCORE || !cs->is_service_core)
return -EINVAL;
/* Load thread_active using ACQUIRE to avoid instructions dependent on
* the result being re-ordered before this load completes.
*/
- return rte_atomic_load_explicit(&lcore_states[lcore].thread_active,
+ return rte_atomic_load_explicit(&cs->thread_active,
rte_memory_order_acquire);
}
@@ -547,9 +547,12 @@ int32_t
rte_service_lcore_count(void)
{
int32_t count = 0;
- uint32_t i;
- for (i = 0; i < RTE_MAX_LCORE; i++)
- count += lcore_states[i].is_service_core;
+
+ unsigned int lcore_id;
+ struct core_state *cs;
+ RTE_LCORE_VAR_FOREACH(lcore_id, cs, lcore_states)
+ count += cs->is_service_core;
+
return count;
}
@@ -566,7 +569,8 @@ rte_service_lcore_list(uint32_t array[], uint32_t n)
uint32_t i;
uint32_t idx = 0;
for (i = 0; i < RTE_MAX_LCORE; i++) {
- struct core_state *cs = &lcore_states[i];
+ struct core_state *cs =
+ RTE_LCORE_VAR_LCORE(i, lcore_states);
if (cs->is_service_core) {
array[idx] = i;
idx++;
@@ -582,7 +586,7 @@ rte_service_lcore_count_services(uint32_t lcore)
if (lcore >= RTE_MAX_LCORE)
return -EINVAL;
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
if (!cs->is_service_core)
return -ENOTSUP;
@@ -634,28 +638,30 @@ rte_service_start_with_defaults(void)
static int32_t
service_update(uint32_t sid, uint32_t lcore, uint32_t *set, uint32_t *enabled)
{
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
+
/* validate ID, or return error value */
if (!service_valid(sid) || lcore >= RTE_MAX_LCORE ||
- !lcore_states[lcore].is_service_core)
+ !cs->is_service_core)
return -EINVAL;
if (set) {
- uint64_t lcore_mapped = rte_bitset_test(lcore_states[lcore].mapped_services, sid);
+ bool lcore_mapped = rte_bitset_test(cs->mapped_services, sid);
if (*set && !lcore_mapped) {
- rte_bitset_set(lcore_states[lcore].mapped_services, sid);
+ rte_bitset_set(cs->mapped_services, sid);
rte_atomic_fetch_add_explicit(&rte_services[sid].num_mapped_cores,
1, rte_memory_order_relaxed);
}
if (!*set && lcore_mapped) {
- rte_bitset_clear(lcore_states[lcore].mapped_services, sid);
+ rte_bitset_clear(cs->mapped_services, sid);
rte_atomic_fetch_sub_explicit(&rte_services[sid].num_mapped_cores,
1, rte_memory_order_relaxed);
}
}
if (enabled)
- *enabled = rte_bitset_test(lcore_states[lcore].mapped_services, sid);
+ *enabled = rte_bitset_test(cs->mapped_services, sid);
return 0;
}
@@ -683,13 +689,14 @@ set_lcore_state(uint32_t lcore, int32_t state)
{
/* mark core state in hugepage backed config */
struct rte_config *cfg = rte_eal_get_configuration();
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
cfg->lcore_role[lcore] = state;
/* mark state in process local lcore_config */
lcore_config[lcore].core_role = state;
/* update per-lcore optimized state tracking */
- lcore_states[lcore].is_service_core = (state == ROLE_SERVICE);
+ cs->is_service_core = (state == ROLE_SERVICE);
rte_eal_trace_service_lcore_state_change(lcore, state);
}
@@ -700,14 +707,16 @@ rte_service_lcore_reset_all(void)
/* loop over cores, reset all mapped services */
uint32_t i;
for (i = 0; i < RTE_MAX_LCORE; i++) {
- if (lcore_states[i].is_service_core) {
- rte_bitset_clear_all(lcore_states[i].mapped_services, RTE_SERVICE_NUM_MAX);
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(i, lcore_states);
+
+ if (cs->is_service_core) {
+ rte_bitset_clear_all(cs->mapped_services, RTE_SERVICE_NUM_MAX);
set_lcore_state(i, ROLE_RTE);
/* runstate act as guard variable Use
* store-release memory order here to synchronize
* with load-acquire in runstate read functions.
*/
- rte_atomic_store_explicit(&lcore_states[i].runstate,
+ rte_atomic_store_explicit(&cs->runstate,
RUNSTATE_STOPPED, rte_memory_order_release);
}
}
@@ -723,17 +732,19 @@ rte_service_lcore_add(uint32_t lcore)
{
if (lcore >= RTE_MAX_LCORE)
return -EINVAL;
- if (lcore_states[lcore].is_service_core)
+
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
+ if (cs->is_service_core)
return -EALREADY;
set_lcore_state(lcore, ROLE_SERVICE);
/* ensure that after adding a core the mask and state are defaults */
- rte_bitset_clear_all(lcore_states[lcore].mapped_services, RTE_SERVICE_NUM_MAX);
+ rte_bitset_clear_all(cs->mapped_services, RTE_SERVICE_NUM_MAX);
/* Use store-release memory order here to synchronize with
* load-acquire in runstate read functions.
*/
- rte_atomic_store_explicit(&lcore_states[lcore].runstate, RUNSTATE_STOPPED,
+ rte_atomic_store_explicit(&cs->runstate, RUNSTATE_STOPPED,
rte_memory_order_release);
return rte_eal_wait_lcore(lcore);
@@ -745,7 +756,7 @@ rte_service_lcore_del(uint32_t lcore)
if (lcore >= RTE_MAX_LCORE)
return -EINVAL;
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
if (!cs->is_service_core)
return -EINVAL;
@@ -769,7 +780,7 @@ rte_service_lcore_start(uint32_t lcore)
if (lcore >= RTE_MAX_LCORE)
return -EINVAL;
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
if (!cs->is_service_core)
return -EINVAL;
@@ -799,6 +810,8 @@ rte_service_lcore_start(uint32_t lcore)
int32_t
rte_service_lcore_stop(uint32_t lcore)
{
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
+
if (lcore >= RTE_MAX_LCORE)
return -EINVAL;
@@ -806,12 +819,11 @@ rte_service_lcore_stop(uint32_t lcore)
* memory order here to synchronize with store-release
* in runstate update functions.
*/
- if (rte_atomic_load_explicit(&lcore_states[lcore].runstate, rte_memory_order_acquire) ==
+ if (rte_atomic_load_explicit(&cs->runstate, rte_memory_order_acquire) ==
RUNSTATE_STOPPED)
return -EALREADY;
uint32_t i;
- struct core_state *cs = &lcore_states[lcore];
for (i = 0; i < RTE_SERVICE_NUM_MAX; i++) {
bool enabled = rte_bitset_test(cs->mapped_services, i);
@@ -831,7 +843,7 @@ rte_service_lcore_stop(uint32_t lcore)
/* Use store-release memory order here to synchronize with
* load-acquire in runstate read functions.
*/
- rte_atomic_store_explicit(&lcore_states[lcore].runstate, RUNSTATE_STOPPED,
+ rte_atomic_store_explicit(&cs->runstate, RUNSTATE_STOPPED,
rte_memory_order_release);
rte_eal_trace_service_lcore_stop(lcore);
@@ -842,7 +854,7 @@ rte_service_lcore_stop(uint32_t lcore)
static uint64_t
lcore_attr_get_loops(unsigned int lcore)
{
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
return rte_atomic_load_explicit(&cs->loops, rte_memory_order_relaxed);
}
@@ -850,7 +862,7 @@ lcore_attr_get_loops(unsigned int lcore)
static uint64_t
lcore_attr_get_cycles(unsigned int lcore)
{
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
return rte_atomic_load_explicit(&cs->cycles, rte_memory_order_relaxed);
}
@@ -858,7 +870,7 @@ lcore_attr_get_cycles(unsigned int lcore)
static uint64_t
lcore_attr_get_service_calls(uint32_t service_id, unsigned int lcore)
{
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
return rte_atomic_load_explicit(&cs->service_stats[service_id].calls,
rte_memory_order_relaxed);
@@ -885,7 +897,7 @@ lcore_attr_get_service_error_calls(uint32_t service_id, unsigned int lcore)
static uint64_t
lcore_attr_get_service_cycles(uint32_t service_id, unsigned int lcore)
{
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
return rte_atomic_load_explicit(&cs->service_stats[service_id].cycles,
rte_memory_order_relaxed);
@@ -901,7 +913,10 @@ attr_get(uint32_t id, lcore_attr_get_fun lcore_attr_get)
uint64_t sum = 0;
for (lcore = 0; lcore < RTE_MAX_LCORE; lcore++) {
- if (lcore_states[lcore].is_service_core)
+ struct core_state *cs =
+ RTE_LCORE_VAR_LCORE(lcore, lcore_states);
+
+ if (cs->is_service_core)
sum += lcore_attr_get(id, lcore);
}
@@ -963,12 +978,11 @@ int32_t
rte_service_lcore_attr_get(uint32_t lcore, uint32_t attr_id,
uint64_t *attr_value)
{
- struct core_state *cs;
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
if (lcore >= RTE_MAX_LCORE || !attr_value)
return -EINVAL;
- cs = &lcore_states[lcore];
if (!cs->is_service_core)
return -ENOTSUP;
@@ -993,7 +1007,8 @@ rte_service_attr_reset_all(uint32_t id)
return -EINVAL;
for (lcore = 0; lcore < RTE_MAX_LCORE; lcore++) {
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs =
+ RTE_LCORE_VAR_LCORE(lcore, lcore_states);
cs->service_stats[id] = (struct service_stats) {};
}
@@ -1004,12 +1019,11 @@ rte_service_attr_reset_all(uint32_t id)
int32_t
rte_service_lcore_attr_reset_all(uint32_t lcore)
{
- struct core_state *cs;
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
if (lcore >= RTE_MAX_LCORE)
return -EINVAL;
- cs = &lcore_states[lcore];
if (!cs->is_service_core)
return -ENOTSUP;
@@ -1044,7 +1058,7 @@ static void
service_dump_calls_per_lcore(FILE *f, uint32_t lcore)
{
uint32_t i;
- struct core_state *cs = &lcore_states[lcore];
+ struct core_state *cs = RTE_LCORE_VAR_LCORE(lcore, lcore_states);
fprintf(f, "%02d\t", lcore);
for (i = 0; i < RTE_SERVICE_NUM_MAX; i++) {
--
2.43.0