From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECD2C45B56; Wed, 16 Oct 2024 22:23:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69FEF4021F; Wed, 16 Oct 2024 22:23:55 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id CB66640144 for ; Wed, 16 Oct 2024 22:23:53 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-20cb7139d9dso1963415ad.1 for ; Wed, 16 Oct 2024 13:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729110233; x=1729715033; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQlXX1LlrBSULsB2JGIbbwHRjV2cK2h3joNZF0BRyss=; b=ho6cLLO7DbC8l8kFziuGcubjCiK3ssBk8dqtIB0k/4gme/RNKkSCM5FZhs9rgdtYCc ce7/AzlWoZDFZzWWzXzXDRzdr4IrFAWY1HWCSTVoz3AxGWWIIaMS+8PMxua3L8WogInM w2ItFeqIbIAbBINs55xz6dF8EHncuq0C+43cRlhYYUSjb0MPmSWSvebM5b0L7h/aa0n7 yH3t5SWbVxRFm/+w4oZNkIVWGtmCy2xgIEF/NDsOEw19FIzglzsfGqL31/2Zj2GREswu z+nDBu5vWYkt8//Phztm/h8GFVOWZc0G/1fn2ueWCYp3mnsd0Jd7PiZJPgOB1umYFlAt 1vdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729110233; x=1729715033; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQlXX1LlrBSULsB2JGIbbwHRjV2cK2h3joNZF0BRyss=; b=WCSDku6yfH5Ihw1HbrB31oyX2mTtV+qhdosPUE2/N2pH7rG1axVCfAKXz/ssi8pwIj PZmN3Zgoqt2VnzoaHV4vGjQxrBBkgmuDn8czrmSoy3GqcKtJwBLzun4DY88pqG7iZEx/ OYMeOuKQwtxfaijmJD8DrwvuRGElr01h+zDTSDlBP5j/88m1bKpo3RGC9895lFOEJiHZ 6dI4Fb2w0SJFiiZStJGadrsyktVxRvoOkeSKEO+wjnXARCurWgauAdc5MorHNTo5dEY6 mlL2JKE2SqE/sZQ3nIXa1u42EIbHrdc7sKLMY9AVCzizIdjtaayw9VhLUPSY37rHpQ3Q dO5w== X-Gm-Message-State: AOJu0YzsJ5sbSMHzons5h5q132o2P7eTmYIoogtwyBBYSri1gjSn0JZN X/F4m6sJ4ztZsXxbXkZhYhpAAubWVVd1EfW1OeD7MacnALOpeMZDT8QANqr/TNQlW3AvTPMAflw E X-Google-Smtp-Source: AGHT+IHDyIbMoGVlC2vwc2qD8V03EXfGF3+8qp7Y8XiIjHhd3IrU+06dFi9FY4xVWjJSL/ZhPbBORg== X-Received: by 2002:a17:902:e5c8:b0:20c:7be3:2816 with SMTP id d9443c01a7336-20d27f0a57bmr67446495ad.40.1729110232591; Wed, 16 Oct 2024 13:23:52 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d180361e5sm32308825ad.120.2024.10.16.13.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 13:23:52 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v26 00/15] Log subsystem improvements Date: Wed, 16 Oct 2024 13:20:27 -0700 Message-ID: <20241016202343.190653-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20200814173441.23086-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of startup codes. Timestamp is optional and must be enabled on command line. * Displaying console output with colors. It uses the standard conventions used by many other Linux commands for colorized display. The default is to enable color if the console output is going to a terminal. But it can be always on or disabled by command line flag. This default was chosen based on what dmesg(1) command does. Color is used by many tools (vi, iproute2, git) because it is helpful; DPDK drivers and libraries print lots of not very useful messages. And having error messages highlighted in bold face helps. This might also get users to pay more attention to error messages. Many bug reports have earlier messages that are lost because there are so many info messages. * Add support for automatic detection of systemd journal protocol. If running as systemd service will get enhanced logging. * Use of syslog is optional and the meaning of the --syslog flag has changed. The default is *not* to use syslog if output is going to a terminal. Add myself as maintainer for log because by now have added more than previous authors. v26 - rebase and change release note - by default, do not disable color - support dark mode with colors - when using color format message to string then print to avoid getting multiple threads intermixing on output. Stephen Hemminger (15): maintainers: add for log library windows: make getopt functions have const properties windows: add os shim for localtime_r eal: make eal_log_level_parse common eal: do not duplicate rte_init_alert() messages eal: change rte_exit() output to match rte_log() log: move handling of syslog facility out of eal eal: initialize log before everything else log: drop syslog support, and make code common log: add hook for printing log messages log: add timestamp option log: add optional support of syslog log: add support for systemd journal log: colorize log output doc: add release note about log library MAINTAINERS | 1 + app/test/test_eal_flags.c | 64 ++++- doc/guides/linux_gsg/linux_eal_parameters.rst | 27 -- doc/guides/prog_guide/log_lib.rst | 76 +++++- doc/guides/rel_notes/release_24_11.rst | 26 ++ lib/eal/common/eal_common_debug.c | 6 +- lib/eal/common/eal_common_options.c | 135 ++++++---- lib/eal/common/eal_internal_cfg.h | 1 - lib/eal/common/eal_options.h | 7 + lib/eal/freebsd/eal.c | 64 +---- lib/eal/linux/eal.c | 68 +---- lib/eal/windows/eal.c | 49 +--- lib/eal/windows/getopt.c | 23 +- lib/eal/windows/include/getopt.h | 8 +- lib/eal/windows/include/rte_os_shim.h | 10 + lib/log/log.c | 71 ++++-- lib/log/log_color.c | 216 ++++++++++++++++ lib/log/log_freebsd.c | 12 - lib/log/log_internal.h | 28 +- lib/log/log_journal.c | 200 +++++++++++++++ lib/log/log_linux.c | 61 ----- lib/log/log_private.h | 61 +++++ lib/log/log_syslog.c | 88 +++++++ lib/log/log_timestamp.c | 240 ++++++++++++++++++ lib/log/log_windows.c | 18 -- lib/log/meson.build | 12 +- lib/log/version.map | 5 +- 27 files changed, 1197 insertions(+), 380 deletions(-) create mode 100644 lib/log/log_color.c delete mode 100644 lib/log/log_freebsd.c create mode 100644 lib/log/log_journal.c delete mode 100644 lib/log/log_linux.c create mode 100644 lib/log/log_private.h create mode 100644 lib/log/log_syslog.c create mode 100644 lib/log/log_timestamp.c delete mode 100644 lib/log/log_windows.c -- 2.45.2