From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DB2845B56; Wed, 16 Oct 2024 22:24:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 049014060B; Wed, 16 Oct 2024 22:24:04 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 8389E40611 for ; Wed, 16 Oct 2024 22:24:00 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20b5affde14so1561535ad.3 for ; Wed, 16 Oct 2024 13:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729110240; x=1729715040; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=syLoQl99tMzzU18CNAC5tW74aHSWzB99Q3t6U8LsAzc=; b=E0a04dDQbBy5Y1nEFpzziPKl6yIAJ/dXRH3sN7DiLnzm4o1ZDP3g5zMlR6fN/KXo/I 0P9kfVfwRDz9r/C4KcZ4S6SeAcx37a+pXi4DvqDeT1XbKySJsUvwMKHIUjOitmxbKADI ducByobP7wm6knabwDdf9MzNIRYe2/JgxI6W6joXlcUIVuhBbxj2PZrSI5d1OUblvRrd ML7ZL/RXrMy6iGKRHkDGnqG6NGj3oRAWjCuUEO6NxEkagZ9tOvkva5h34c+I3OcFOPv/ Cfq0yKsBEmnt7Iousp2JeRGDv4Cv2dOG/pZ4D2N4mSe/I1TFrHcb8U7BvT7sboYU8ymI Ow9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729110240; x=1729715040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=syLoQl99tMzzU18CNAC5tW74aHSWzB99Q3t6U8LsAzc=; b=JcUjaJDQq0FBnKrkFIvZNzY49UgdomdXoisomaCgRFd9jGtiOC3RJs6cl+jH5wSnD6 Rrtzw1HM3t1T1R1exDmfJKqTTV680k3VfJbOSwETNOpyuDY2yD5jjvC4zJICf6wDJD9n +73irEKdpQ6N/IOt/Mp92dXYdBETm55Ile6d65QKpeBwoDg7R/RekRCDq/8okVE+aHb9 NJ15GkPASWjUTkxfmfnM/HVpwcJ63arM/W+ktb7heE8ex6EOsZSul3X7O9cUFbedclAT 6CcUFnBz0aj5oPwYon/yPhJ8lejNJ3UBNz28x6uvUIulmC14MXDKD6pbRU+XHJ2JWt2r xiew== X-Gm-Message-State: AOJu0YxH7jZbrdwu0dj2ukU1fhF7juVCznkzIbg8gwZthNEiWrKmKWp3 0BVWvBi0yB5Qmyd88tYOkVsF6L8yjwO06qULFukRvM/P75gS+xFHuu0azsx2DHblox7cP8ahYgl q X-Google-Smtp-Source: AGHT+IHGXMlsDRPS7hw1eBxVRyHrEmE7NSxTSdjPSxUKTZGplo8TGfm5AZrPvHmKaytQdvyfNx0cFQ== X-Received: by 2002:a17:903:244b:b0:20c:eb89:4881 with SMTP id d9443c01a7336-20d27f1cbc0mr74092185ad.37.1729110239681; Wed, 16 Oct 2024 13:23:59 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d180361e5sm32308825ad.120.2024.10.16.13.23.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 13:23:59 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng Subject: [PATCH v26 05/15] eal: do not duplicate rte_init_alert() messages Date: Wed, 16 Oct 2024 13:20:32 -0700 Message-ID: <20241016202343.190653-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241016202343.190653-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241016202343.190653-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index d3b40e81d8..7b974608e4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 40d750ed0d..c53a051405 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -830,8 +830,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.45.2