From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3939545B61;
Thu, 17 Oct 2024 21:13:01 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C0F674029C;
Thu, 17 Oct 2024 21:13:00 +0200 (CEST)
Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com
[209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 948674025F
for <dev@dpdk.org>; Thu, 17 Oct 2024 21:12:59 +0200 (CEST)
Received: by mail-pj1-f45.google.com with SMTP id
98e67ed59e1d1-2e31af47681so1050485a91.2
for <dev@dpdk.org>; Thu, 17 Oct 2024 12:12:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729192379;
x=1729797179; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=KhC2NFRhEQQCLcM5JgIPfl75YPQD8Rta9L9YcWO2XE8=;
b=FMxkzJBMG47TNfVz2hpY1/6LyJC7UkBPhT5XntmLj5/UkdI+3uKHqn6bwaLr34dc7m
BnM7e32g2i6PbT4CHGxGeHErBcdSM5H6GMwJvTREsCyO1dJsZMHq7IvfHDFeLz36Neg7
R/ne/VWRFL7iQ3eyq85BND4IPzvuHIhDn0Id1Um/1KrnyAv+l9NhdNELMJUicscgPfxj
e7+RUt8g+r2e3w2TuYSfsH/NGYJYFCarfUT8iu3EHSqWv86t1z6C3jvT3hCO5JBGRmnQ
ujc+GckUKdhz7/QcA2HFNrWydbVCN+VpIQVmD8Rs2qyjFTxBhwLedG/0M2rWEH6A5NWE
AeAg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1729192379; x=1729797179;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=KhC2NFRhEQQCLcM5JgIPfl75YPQD8Rta9L9YcWO2XE8=;
b=oJe/ggTZGTgbrV55TMaUhMK0c0sJz5y7PDEt1J+bM8N1wxmq6MTv4F2rSS3ixRyW9w
s5LhgQ03MCLDcMa+HC9asKY/rJFykRiTeFmKoje7YA+xeUzXm2PFYvXlSB+e8esOP4NJ
lPlEbBURr+96Pjvm1tLcGb0OxbFTjcHaomlBoEjFDtk8zy4K9yCQL89MQZ2ToriB5Kx1
RiSovg6Mn+yX+6G3LYQXogJUO1ajQDaScUGQVpVDzfFmL1qMoos5K9MNofaO8rj+wMJg
3U2rWpL3QeC/msIPt9eXqmlvJrM6awNUk8mgdTI4HHUPa6jRKt6qhAdRWBZwV0JM+ja2
ePkg==
X-Gm-Message-State: AOJu0YxA9tXbQ0mONZYLpXCfanapKAcmMGKi+ZKO+dn3a02X+i3GJrbm
3pC5W0gnHY2wsALtpmLoI0hZUPLJ/wu13NQhNqB0rcbiFvWb8PHlQDtr5HzsaVk=
X-Google-Smtp-Source: AGHT+IF4BoF7SdKq++7YILovfrPRFADMkoNnZiMy663uNEwi9KSDD51DS0uikFdbq4f7UxgbbeDkMA==
X-Received: by 2002:a17:90a:d60c:b0:2e2:b6ef:1611 with SMTP id
98e67ed59e1d1-2e561851ea1mr18820a91.18.1729192378729;
Thu, 17 Oct 2024 12:12:58 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
98e67ed59e1d1-2e55d78a7a9sm231707a91.3.2024.10.17.12.12.58
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 17 Oct 2024 12:12:58 -0700 (PDT)
Date: Thu, 17 Oct 2024 12:12:56 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>
Subject: Re: [PATCH] examples/l3fwd: support setting the data size of mbuf
Message-ID: <20241017121256.5ef23f0e@hermes.local>
In-Reply-To: <20241016082232.4005800-1-chaoyong.he@corigine.com>
References: <20241016082232.4005800-1-chaoyong.he@corigine.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Wed, 16 Oct 2024 16:22:32 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:
> From: Long Wu <long.wu@corigine.com>
>=20
> The previous code used a macro as the data size for mbuf
> to create the mempool and users cannot modify the size.
>=20
> Now modify the code to support setting the data size of
> mbuf by '--mbuf-size' parameter. If user does not add the
> parameter in start command line, the default size is still
> 'RTE_MBUF_DEFAULT_BUF_SIZE'.
>=20
> Examples:
> dpdk-l3fwd -l 0-3 -- -p 0x03 --mbuf-size=3D4096
>=20
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Patch has build failures
*Build Failed #1:
OS: OpenAnolis8.9-64
Target: x86_64-native-linuxapp-gcc
FAILED: examples/dpdk-l3fwd.p/l3fwd_main.c.o=20
gcc -Iexamples/dpdk-l3fwd.p -Iexamples -I../examples -Iexamples/l3fwd -I../=
examples/l3fwd -I../examples/common -I. -I.. -Iconfig -I../config -Ilib/eal=
/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/in=
clude -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../=
lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/lo=
g -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/tele=
metry -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/net -I.=
./lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/ethdev -I../lib/ethdev -Ilib/meter=
-I../lib/meter -Ilib/cmdline -I../lib/cmdline -Ilib/acl -I../lib/acl -Ilib=
/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -Ilib/lpm -I../lib/lpm -Ilib/fib=
-I../lib/fib -Ilib/rib -I../lib/rib -Ilib/eventdev -I../lib/eventdev -Ilib=
/timer -I../lib/timer -Ilib/cryptodev -I../lib/cryptodev -Ilib/dmadev -I../=
lib/dmadev -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D64 -Wall -Win=
valid-pch -Wextra -Werror -std=3Dc11 -O3 -include rte_config.h -Wcast-qual =
-Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-decla=
rations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpoin=
ter-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-p=
acked-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -march=3Dna=
tive -mrtm -Wno-format-truncation -DALLOW_EXPERIMENTAL_API -MD -MQ examples=
/dpdk-l3fwd.p/l3fwd_main.c.o -MF examples/dpdk-l3fwd.p/l3fwd_main.c.o.d -o =
examples/dpdk-l3fwd.p/l3fwd_main.c.o -c ../examples/l3fwd/main.c
../examples/l3fwd/main.c: In function =E2=80=98parse_args=E2=80=99:
../examples/l3fwd/main.c:944:44: error: comparison is always false due to l=
imited range of data type [-Werror=3Dtype-limits]
if (mbuf_seg_size <=3D 0 || mbuf_seg_size > 0xFFFF)
^
cc1: all warnings being treated as errors