From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79A9345B68; Fri, 18 Oct 2024 11:01:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEFD740678; Fri, 18 Oct 2024 11:01:19 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id E430E402BD for ; Fri, 18 Oct 2024 11:01:17 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71e49ad46b1so1281427b3a.1 for ; Fri, 18 Oct 2024 02:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1729242077; x=1729846877; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PjItn4UKNh32h4VjxiwoHdLhBhYvtTxKRydk1cNjExQ=; b=GSXkLRSfzQBpfNWXq5KvFdgH233t1IkubHp6L58o4sbrLLWZJEXOwribtyST7sQ9Ee /Ed6WJIm4TSA1Oz6lsMTfRf/yrVQTx254UTt4Fr9JMj2fqdPPAzG9NYHO7ui4hjIS/9g XP+uwvd7fH66fPyDCetz2KQzMOqXWMgTh3+Qc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729242077; x=1729846877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PjItn4UKNh32h4VjxiwoHdLhBhYvtTxKRydk1cNjExQ=; b=bLTs9ZHGIrQax/wgfXA+be6ldYGhTBWyy9Zau3XsXLxgvK6UR/ubMPm7UTPQWVNfT9 OOa40MVosOEwi6p04/RHqOKQvXRIimy80Vdf393YlafN3mpTtG7h9+zZdyh2uqQJ7A7p 0UZx+O6FeF0tAWNSJ+vLU6LZHwDjtgmBc0mCiKl4xc2dNw46O9XNeLCgbu5RpEkVpJsw sYxYdb26+8IQ8To1LV69COGnCg3N8JA/IBzsD7o+gJqv/cniaeth5GXr1vosAyB66eOP Xg+ecUMHaI+lOPsc4vTxTN7T7syUcURPwsMQHPNsgKR/kRmb2Jgc+qUP0rwBnMoJwsCb rjUQ== X-Gm-Message-State: AOJu0YzUDLWWhTuqa8vMw4f85536TCKrz/6EOGyK74K0BkW5NzlSEunE qwpaF6nuBV43DfdjU794rDDjsh7oUTR6a6jrqTmYftsztvHGdfT+w8YjKeXsf0/gnevETST0VdD 26BxPmAvEd4LWmPR4fwhWrHgT2IMemdLIUV3XV2QucCNzRwFqB09k7r4hVQNPITzyIBvNJa0rs8 r7yJS7NpITcSmkjgbeB4BvY51P8yD3Fnvi6tMHv1U9Gw== X-Google-Smtp-Source: AGHT+IFGBF5JS2DbvmF0KbKeBIM0g2NMnOjQ9KAwCNIxV7HOTM2Unkek6+ddjVaV0YCcLYl6bNOu0Q== X-Received: by 2002:a05:6a00:1749:b0:71e:6489:d18 with SMTP id d2e1a72fcca58-71ea332c305mr2831136b3a.22.1729242076321; Fri, 18 Oct 2024 02:01:16 -0700 (PDT) Received: from dhcp-10-123-154-23.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ea3311f45sm1009891b3a.14.2024.10.18.02.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 02:01:14 -0700 (PDT) From: Sriharsha Basavapatna To: dev@dpdk.org Cc: Sangtani Parag Satishbhai , Sriharsha Basavapatna , Ajit Khaparde Subject: [PATCH v5 07/47] net/bnxt: tf_core: fix slice count in case of HA entry move Date: Fri, 18 Oct 2024 14:40:44 +0530 Message-Id: <20241018091124.3373258-8-sriharsha.basavapatna@broadcom.com> X-Mailer: git-send-email 2.39.0.189.g4dbebc36b0 In-Reply-To: <20241018091124.3373258-1-sriharsha.basavapatna@broadcom.com> References: <20241018091124.3373258-1-sriharsha.basavapatna@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sangtani Parag Satishbhai When entries are moved during HA, a shared move function transfers TCAM entries by using get/set message APIs, and the slice number of the entry is required to accomplish the movement. The slice number is calculated as the product of row_slice and entry size. Before calling get/set message APIs, the source entry size should be updated with the destination entry size; otherwise, it might corrupt the slice number field, which may result in writing an incorrect entry. A fix is made which now copies the entry size from the source to the destination before calling get/set message APIs, ensuring the correct slice number is modified. Signed-off-by: Sangtani Parag Satishbhai Reviewed-by: Sriharsha Basavapatna Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_tcam_mgr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/tf_core/cfa_tcam_mgr.c b/drivers/net/bnxt/tf_core/cfa_tcam_mgr.c index 349f52caba..33b1e4121e 100644 --- a/drivers/net/bnxt/tf_core/cfa_tcam_mgr.c +++ b/drivers/net/bnxt/tf_core/cfa_tcam_mgr.c @@ -1717,6 +1717,11 @@ cfa_tcam_mgr_shared_entry_move(int sess_idx, struct cfa_tcam_mgr_context *contex uint8_t key[CFA_TCAM_MGR_MAX_KEY_SIZE]; uint8_t mask[CFA_TCAM_MGR_MAX_KEY_SIZE]; uint8_t result[CFA_TCAM_MGR_MAX_KEY_SIZE]; + /* + * Copy entry size before moving else if + * slice number is non zero and entry size is zero it will cause issues + */ + dst_row->entry_size = src_row->entry_size; int rc; @@ -1791,7 +1796,6 @@ cfa_tcam_mgr_shared_entry_move(int sess_idx, struct cfa_tcam_mgr_context *contex ROW_ENTRY_SET(dst_row, dst_row_slice); dst_row->entries[dst_row_slice] = entry_id; - dst_row->entry_size = src_row->entry_size; dst_row->priority = src_row->priority; ROW_ENTRY_CLEAR(src_row, entry->slice); entry->row = dst_row_index; -- 2.39.3