From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA44D45B6A; Fri, 18 Oct 2024 18:40:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86EB440654; Fri, 18 Oct 2024 18:40:07 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 64259402F0 for ; Fri, 18 Oct 2024 18:40:04 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2e2e2d09decso2547329a91.1 for ; Fri, 18 Oct 2024 09:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729269603; x=1729874403; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=H9LmhOHKvUYKi1oQaQbn9/8k4tvx9Ago34mGDTnwlog=; b=VQYLLUpLok7WsVtaZr92/w9AjTIRZXRDjI1LuNpOrQsLzFUGsfCMwH6wYN1vuvRUx0 BlNO3+geXX0qzBi7uZ6f/Yazc8HOnk4J9mdaYasisDd7Y1VegQ6gzdiRcLi/Co6rJhoq dzox45PbVgb2JX+xMKUs1iLBlOYkP06EGq8pd9XoTdUQv2VhsZglPju8nbpMhPpf0GLq gOdLJWCQvgvCjrgdwqcLAYBuwV98FiB10UiPjFdHD6lDL+u84ziHB3AmDUVIiGK0tRR6 BuD0rkIxuMoJHCjEHD3o9eMZLS8awK3cgf7n8m6FUuzbMWsEzFLbZnfkwEMTF0J0vP3K mTkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729269603; x=1729874403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H9LmhOHKvUYKi1oQaQbn9/8k4tvx9Ago34mGDTnwlog=; b=rZR/NEqz8WI2Rvd1ItTU8wYNlbpBSbSROmkhj0YcFglY/KI6ruqXkfdNSPtcnwtiQM o4QP2Tw/Ag6STAscc+n3BPuC3Kanhwtj2r1rVMl0oBv7E9bmK0udlnIgONREZnQ3OoVV dBZS1voY28K3jsN/aK/i06t54hgR9z2oH47Cvy9J+ovhkzxQHPPm1e6MzQRmRjJSfCCT p0rkeRyf32Y/1o/5o5yM1nlC9EabIvS5FsXVNtE5oUamWb58Ythtc6Te8aKb3VIlSbqE iuKDmS2VEnlh1ialiHgRx3HULZGtnzTmK/Fnil7ATfMszQup1cIbzhUv42UBpkN0laeB sCjw== X-Gm-Message-State: AOJu0YxGblgQCBEzFc48E//ngvPuDzXCGJZvjw19c/1CsKgo9OwO+WGO x727FafpPD3FLZTspIBq8Me1mSsbrZr8p5ByrXlIXCfXhq6xwvP7qWNzYl8gfW4= X-Google-Smtp-Source: AGHT+IEbIn+dj5MzAawi4Og97Y8ZmpK/lXOpwpXxx8ffPLW+Rn/fjShK0DqZ/e6cW3u93t8pUjVA5g== X-Received: by 2002:a17:90a:f3c1:b0:2da:8edf:ddc with SMTP id 98e67ed59e1d1-2e5651a92a8mr4393914a91.19.1729269603590; Fri, 18 Oct 2024 09:40:03 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e55da73a47sm2306514a91.49.2024.10.18.09.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 09:40:03 -0700 (PDT) Date: Fri, 18 Oct 2024 09:32:38 -0700 From: Stephen Hemminger To: =?UTF-8?B?546L6aKi?= Cc: "dev@dpdk.org" , "pro_nic_dpdk@realtek.com" Subject: Re: [PATCH v2 03/18] net/r8169: add hardware registers access routines Message-ID: <20241018093238.02af79ed@hermes.local> In-Reply-To: References: <20241017063200.26101-1-howard_wang@realsil.com.cn> <20241017063200.26101-4-howard_wang@realsil.com.cn> <20241017093424.091b3474@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 18 Oct 2024 03:41:28 +0000 =E7=8E=8B=E9=A2=A2 wrote: > Dear Stephen, >=20 > In r8169 pmd, mdelay and udelay are macros. > #define mdelay rte_delay_ms > #define udelay rte_delay_us >=20 > Best Regards, > Howard Wang That kind of redefinition can lead to confusion, can it be avoided?