From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B86245B6A; Fri, 18 Oct 2024 18:40:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A94D40613; Fri, 18 Oct 2024 18:40:03 +0200 (CEST) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 107AE402F0 for ; Fri, 18 Oct 2024 18:40:02 +0200 (CEST) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2e06acff261so1716864a91.2 for ; Fri, 18 Oct 2024 09:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729269601; x=1729874401; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=rIbyQiumYI2YjwaCLFGLl2BDqAkw6obtkFwqxemTDyo=; b=Rom5trtxlNZewef/H39Kn5wKUUQk46IHTwP/p6SaMCEzsWl1nIaoa2lpCfedMlIMWm t3gBoIyNaFpuVYGlehA2F3Ir21n+ZFmoEWKlsgCQ163FIcd1NkeH8IEzorvvrauYF6Jt 6FFz+WvNUwUpznr19MelNh916a3OXOfXybxUG/pnVeghBGYphUPTgXH12nPngnzc5N1c WnhxoQ4yTlnE2m52qCzHbQC2Eu6siCP90jKt837jruGsNGQaiTyc7d9L1c0bN706n1nB PEAOp+7FwabQoEmrY/lUffJX53Mw3sSort3+VZhI4kraJdNGtmQuV9Bq6hDlP9R0DgLm AgkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729269601; x=1729874401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rIbyQiumYI2YjwaCLFGLl2BDqAkw6obtkFwqxemTDyo=; b=ZFHeSe8vjI6y+onSl4cvsqJv3K3nModnpCGOeaW+R03imhOVjXsGnXW6d6z0eR7e8D oDlNqmffA6R0CoDvHfz6oVwrfvRiftslvU5zn0bU4waN31eXfEcF7sBkhZAwKKMFHLkX wBam3Nep25AIsP3/slwf6iFji2WlwfyORtY66wmYwuKRQgPMcyiWaSQ41pFbkQGulIIB yaW6byXZGrHTe+0lUMCWug7L3943nMlUeTK4gb2JMHp0CRIdq6zG8cwMk9kszuZG+YAd TD+B6GVwhtKlIDP8PrIVSoBT+oDbWFAkjY+ffUFFBoIc7y+qhhJhYIBOhlnoLSDSOhQ/ YJVw== X-Gm-Message-State: AOJu0Yw/HyqtdCwG4yieb7ECUwQc7ImWhZ5EVcIXITv0logri1vqUdgx 47h+ijkEGWGG8d7JvJpoHJBEBu9wfWHYflFpYclhRWx7aIz8IDXiJcvvPJliQsc= X-Google-Smtp-Source: AGHT+IHqAmHHoJ2nv23FufLJ8i2IuBS4MnqhfElMFAUUFslTVwy7Rtvo/Y5SgaYSTaes2PMohCQliQ== X-Received: by 2002:a17:90b:382:b0:2c9:6a38:54e4 with SMTP id 98e67ed59e1d1-2e56184dd54mr3113267a91.41.1729269601271; Fri, 18 Oct 2024 09:40:01 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e55da73a47sm2306514a91.49.2024.10.18.09.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 09:40:01 -0700 (PDT) Date: Fri, 18 Oct 2024 09:33:22 -0700 From: Stephen Hemminger To: =?UTF-8?B?546L6aKi?= Cc: "dev@dpdk.org" , "pro_nic_dpdk@realtek.com" Subject: Re: [PATCH v2 05/18] net/r8169: add support for hw config Message-ID: <20241018093322.53a3e8d9@hermes.local> In-Reply-To: <27fc470be6d046189171d3f995569a8b@realsil.com.cn> References: <20241017063200.26101-1-howard_wang@realsil.com.cn> <20241017063200.26101-6-howard_wang@realsil.com.cn> <20241017093551.743eecc5@hermes.local> <27fc470be6d046189171d3f995569a8b@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 18 Oct 2024 05:45:18 +0000 =E7=8E=8B=E9=A2=A2 wrote: > Dear Stephen, >=20 > As you can see, there are some issues with the current code regarding whi= tespace and CODE_INDENT. I used astyle to adjust the code format with the f= ollowing command. However, I found that I could not fully meet the checkpat= ch requirements (unless I modify them manually). Would you mind providing s= ome suggestions? For example, what tools do you use to standardize the code= ? Thank you! >=20 We do not expect all patches to be clean with checkpatch. But the indent warnings are valid. DPDK code should be indented with tabs.