Re: [PATCH v6 06/47] net/bnxt: tf_core: TF support flow scale query

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 21 Oct 2024 13:55:26 +0530
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> wrote:

> From: Shuanglin Wang <shuanglin.wang@broadcom.com>
> 
> TF supports the flow scale query feature for OVS application.
> The resource usage is tracked when opening a TF session
> or adding/deleting a flow. The resources includes WC TCAM,
> EM, Action, Counter, Meter, ACT_ENCAP, ACT_ENCAP, and SP_SMAC.
> User can query the resource usage using niccli.
> 
> Several improvements on flow scale query feature:
> 1. Some default rules require both RX and TX resources;
>    need to update usage states on both direcitons.
> 2. Update resoure usage state for regular flows only.
> 3. Added a buffer dirty state to avoid unnecessary
>    state sync with firmware.
> 
> This feature is disabled by default. Using the build flag
> -DTF_FLOW_SCALE_QUERY to enable it.
> 
> Signed-off-by: Shuanglin Wang <shuanglin.wang@broadcom.com>
> Reviewed-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>


### [PATCH] net/bnxt: tf_core: TF support flow scale query

WARNING:TYPO_SPELLING: 'direcitons' may be misspelled - perhaps 'directions'?
#14: 
   need to update usage states on both direcitons.
                                       ^^^^^^^^^^

WARNING:TYPO_SPELLING: 'resoure' may be misspelled - perhaps 'resource'?
#15: 
2. Update resoure usage state for regular flows only.
          ^^^^^^^

WARNING:LONG_LINE_COMMENT: line length of 296 exceeds 120 columns
#220: FILE: drivers/net/bnxt/hsi_struct_def_dpdk.h:23264:
+/* Common structure to cast crypto key split entries. This casting is required in the following HWRM command inputs/outputs if the backing store type is TX_CK or RX_CK. 1. hwrm_func_backing_store_cfg_v2_input 2. hwrm_func_backing_store_qcfg_v2_output 3. hwrm_func_backing_store_qcaps_v2_output */