From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4964E45BA3; Tue, 22 Oct 2024 18:17:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D43234029B; Tue, 22 Oct 2024 18:16:59 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id C3F4E40272 for <dev@dpdk.org>; Tue, 22 Oct 2024 18:16:58 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71ea2643545so3832670b3a.3 for <dev@dpdk.org>; Tue, 22 Oct 2024 09:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729613818; x=1730218618; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=lL8sWtPCNhE2aBxFsfGEWrwvP5Wi57qdNAx1S0EzadA=; b=Gj0mtNP4VEjnGvGWOu0zKy4p1/WKWYerMr0c2L8DWqkYWyc5UGX2dsOY1xFhEaKZ9K iOdntZwRUyXgv/Rsno9599hEL5LXpAdAodsjh1CMe/qvzy/zEFgqipMdB6OnN1I/R+OT ZER61WRBOgi3MlWFb2hCNbLtv24bbFNJI7NASeybUy00HBud5Y5obz2lmmYaLP2vPzsh jRBhHJ2KMATeJQ1ndY4N4bXrVnpPC7sJz3KiwprB9Y+qr9k82UP9xQP8qK0o2gGWh0qT i9xqsVfFP8B+rvDshGaqq5qBJtuYbOjDIheCQRK58jye5x26+ioPIIIPZnPjg6DAlmQG 8Xjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729613818; x=1730218618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lL8sWtPCNhE2aBxFsfGEWrwvP5Wi57qdNAx1S0EzadA=; b=RrPgu1RZQcPAwM/1AuEJlGQoufjsegLgaJLvqEX9l8pyy49cnWynTaytRbpcrOQl6V AvJyPy1WGbDKM1xpKesaWlnbcn79noN2TA2y1eYMxaK+HVWEqNJ26WMBt0KSEIdGhekA 7IIT6vkxvey+QLiTZYWsGzZ3KgSjRD5eyGRFlwXzITdq9h02L4lSES8H0fHgU+6eZVw5 8i/jJORoNn9EN8rl/xZBYYPHGzPQzoPujVBEZWPnJ0yaroiwoQk38l1kX6kX0XvSA5yi XpJuv/um0LA85E7LEGfV7Bw81vmHhCCTs7e+XKGcJZoniLv47ZKoVCMHBzQVXSGs5uR+ NRMw== X-Gm-Message-State: AOJu0Yy7GkHHNN7kgUGjWRoENoejKPcVxvltjieF48dO9eIYaHg4GQBX vA8pqyuGBIJFbyNm/BpKlQT9r5iEFVBRRC1u9Utz3726Wz0yYUaIT4+TB+gj694= X-Google-Smtp-Source: AGHT+IHPfrv2N9QFaX8mDYBDRmFJRP5W3Rvu9KpDDWcygcc+tw/3Ey76BFjkIsxdLPP7xmcw6y3niw== X-Received: by 2002:a05:6a00:2d29:b0:71e:692e:7afb with SMTP id d2e1a72fcca58-71ea31172cemr19071955b3a.5.1729613817949; Tue, 22 Oct 2024 09:16:57 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ec13ea1aesm4906034b3a.155.2024.10.22.09.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 09:16:57 -0700 (PDT) Date: Tue, 22 Oct 2024 09:16:55 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: lew@perftech.com Cc: dev@dpdk.org Subject: Re: [PATCH] ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share() Message-ID: <20241022091655.543539b3@hermes.local> In-Reply-To: <20241022144205.49664-1-lew@perftech.com> References: <20241022144205.49664-1-lew@perftech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, 22 Oct 2024 09:42:05 -0500 lew@perftech.com wrote: > From: Lewis Donzis <lew@perftech.com> > > Forcing wait true prevents checking link status without delay, because the function will wait more than 10 seconds for link status to be true. > > Signed-off-by: Lewis Donzis <lew@perftech.com> Looks correct, driver seems to be trying to work around slow SFP link detection. Acked-by: Stephen Hemminger <stephen@networkplumber.org>