From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C617945BAE;
Wed, 23 Oct 2024 10:32:04 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 0916742D2E;
Wed, 23 Oct 2024 10:29:38 +0200 (CEST)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
by mails.dpdk.org (Postfix) with ESMTP id 57FCA41153
for <dev@dpdk.org>; Wed, 23 Oct 2024 10:29:00 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.88.105])
by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XYMcl6LTYzQs7g;
Wed, 23 Oct 2024 16:28:07 +0800 (CST)
Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84])
by mail.maildlp.com (Postfix) with ESMTPS id BB0F714039F;
Wed, 23 Oct 2024 16:28:59 +0800 (CST)
Received: from localhost.huawei.com (10.50.165.33) by
dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.39; Wed, 23 Oct 2024 16:28:59 +0800
From: Dengdui Huang <huangdengdui@huawei.com>
To: <dev@dpdk.org>
CC: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>,
<mb@smartsharesystems.com>, <david.marchand@redhat.com>,
<iboukris@gmail.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>,
<haijie1@huawei.com>, <liuyonglong@huawei.com>
Subject: [PATCH v4 37/42] net/vhost: use rte strerror
Date: Wed, 23 Oct 2024 16:28:47 +0800
Message-ID: <20241023082852.2780488-38-huangdengdui@huawei.com>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <20241023082852.2780488-1-huangdengdui@huawei.com>
References: <20231114082539.1858594-44-huangdengdui@huawei.com>
<20241023082852.2780488-1-huangdengdui@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.50.165.33]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
dggpeml500011.china.huawei.com (7.185.36.84)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.
Cc: stable@dpdk.org
Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
drivers/net/vhost/rte_eth_vhost.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 87c05caccd..d1bb124a69 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -568,7 +568,7 @@ eth_vhost_update_intr(struct rte_eth_dev *eth_dev, uint16_t rxq_idx)
if (vq->kickfd >= 0 && vq->kickfd != vring.kickfd) {
if (epoll_ctl(vq->ev.data.fd, EPOLL_CTL_DEL, vq->kickfd, &vq->ev) < 0) {
VHOST_LOG_LINE(DEBUG, "Failed to unregister %d from rxq-%d epoll: %s",
- vq->kickfd, rxq_idx, strerror(errno));
+ vq->kickfd, rxq_idx, rte_strerror(errno));
} else {
VHOST_LOG_LINE(DEBUG, "Unregistered %d from rxq-%d epoll",
vq->kickfd, rxq_idx);
@@ -580,7 +580,7 @@ eth_vhost_update_intr(struct rte_eth_dev *eth_dev, uint16_t rxq_idx)
if (vq->kickfd != vring.kickfd && vring.kickfd >= 0) {
if (epoll_ctl(vq->ev.data.fd, EPOLL_CTL_ADD, vring.kickfd, &vq->ev) < 0) {
VHOST_LOG_LINE(ERR, "Failed to register %d in rxq-%d epoll: %s",
- vring.kickfd, rxq_idx, strerror(errno));
+ vring.kickfd, rxq_idx, rte_strerror(errno));
} else {
vq->kickfd = vring.kickfd;
VHOST_LOG_LINE(DEBUG, "Registered %d in rxq-%d epoll",
@@ -731,7 +731,7 @@ eth_vhost_unconfigure_intr(struct rte_eth_dev *eth_dev)
if (vq->kickfd >= 0) {
if (epoll_ctl(vq->ev.data.fd, EPOLL_CTL_DEL, vq->kickfd, &vq->ev) < 0) {
VHOST_LOG_LINE(DEBUG, "Failed to unregister %d from rxq-%d epoll: %s",
- vq->kickfd, i, strerror(errno));
+ vq->kickfd, i, rte_strerror(errno));
} else {
VHOST_LOG_LINE(DEBUG, "Unregistered %d from rxq-%d epoll",
vq->kickfd, i);
--
2.33.0