From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 833FF45BD4; Fri, 25 Oct 2024 10:51:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73A234028F; Fri, 25 Oct 2024 10:51:06 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2043.outbound.protection.outlook.com [40.107.21.43]) by mails.dpdk.org (Postfix) with ESMTP id 417BC4003C for ; Fri, 25 Oct 2024 10:50:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d4Mo5Mh8y3M1bB9pPo0py3eeylf6YUkSVEjtNIZJtw2/KiicC+oyDiY8pjj9IWgT04icL//lfr8Wh5NyNsMckhfvs7NqPXsQeeaFeemIJ0VrF3In76cAM4thIO6dq3OAVhIGN5hkW8HQA1kKDE80SE2325rPz7KLIcXqllq+ZOuv8ELRHRkv5J5Qkmoc6ImgTMLeGW6Kes7TXrOzqZ47iNyUPCoV9o5oTHMW8hk7gkJldSrUWoN/UyWgcbXj7ZHeF5JjWTE7/m9E2UUEKbvpZkjXrRiAT1OohRg1hMotuKIIf0Uo5kq8q+aT2OMKLRrkayWIJRmCxwQAbroaI/dtdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ddiwh231S2Cr/wkdr3oEWK5GXS1Nz5WtGz6HUHXF9Qs=; b=X0+q5rhh+tM1RCZQCdhxXBXnym74Kk/uUI5Q5Waad5RSRAQ9U0b1tPceK49EGqixZIpLihuAbGubggQWGWAcNe33d1kWz7pHI49fDn2e8mJXme23acjHw0JIHUqOmeUzUhX9jfnPti/dN8IErXuFPyrvbQ0aVtVXi9dF1MXyy8RuxKJuqFhwPEVPNUtcs9dQW845FBwguW9Q5sq/GJ+yI5Woaa2JV506T4kJG3pdZ66QkLw3/V4aRjnm9ThgOarebJfClyD/QX5n3bFfiZuE4zOvKHuJ8w0Zz36pMYOpakA6T+x53W4I9Hq9bwUpnhVQ7b2ugaiKzIHUzIRu8MFxAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ddiwh231S2Cr/wkdr3oEWK5GXS1Nz5WtGz6HUHXF9Qs=; b=bA8r0G6tndzSOSwOAefXx3jqdnnIj7D71QU8Hif8qTvYawZf6X7MH9I6fTC5ubh/sgDTSz+3OnI0Dg8VHwRgfoiM/mdWNgL+d6rPcL5XZ4QdTIzARBfd9fmvDRjGv+ArUYgpL4bUS5MjXtDj1ytf+AkyeIHIDB02NVTblOQWTmCJaBe3r6mn0GGFvmY9dO/wXu7G6DlSOnfWXH3dR9s1qlUjh9r8ytvQ6+AL/QwAwg3BCmddyU1dHrl38fa65Ar0+clC46F6IwXJkWyHCMmdiDOzqZNyn41bqnlvkjcOaG8t6jp96wvVZ9mxT+5DzL+W9azP4pfBtQjfI6sP6iw37Q== Received: from DU7P195CA0026.EURP195.PROD.OUTLOOK.COM (2603:10a6:10:54d::6) by DB9PR07MB7849.eurprd07.prod.outlook.com (2603:10a6:10:2a5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21; Fri, 25 Oct 2024 08:50:50 +0000 Received: from DB3PEPF00008859.eurprd02.prod.outlook.com (2603:10a6:10:54d:cafe::18) by DU7P195CA0026.outlook.office365.com (2603:10a6:10:54d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.20 via Frontend Transport; Fri, 25 Oct 2024 08:50:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DB3PEPF00008859.mail.protection.outlook.com (10.167.242.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.14 via Frontend Transport; Fri, 25 Oct 2024 08:50:50 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.61) with Microsoft SMTP Server id 15.2.1544.11; Fri, 25 Oct 2024 10:50:49 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id D1CF41C00A9; Fri, 25 Oct 2024 10:50:49 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Stephen Hemminger , Konstantin Ananyev , David Marchand , Jerin Jacob , Luka Jankovic , Thomas Monjalon , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= , "Chengwen Feng" Subject: [PATCH v17 2/8] eal: add lcore variable functional tests Date: Fri, 25 Oct 2024 10:41:43 +0200 Message-ID: <20241025084149.873037-3-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241025084149.873037-1-mattias.ronnblom@ericsson.com> References: <20241023075302.869008-1-mattias.ronnblom@ericsson.com> <20241025084149.873037-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PEPF00008859:EE_|DB9PR07MB7849:EE_ X-MS-Office365-Filtering-Correlation-Id: 67e5984d-d4d3-4764-6962-08dcf4d22087 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a1dtQzJQck9WRnBXVHVhUEZGQWJhM2hkc2tVcmFja2cvRGp5djhhRlpMYlNB?= =?utf-8?B?YXIyZlcweWNTTVQ0VFNSUzZ5Tm5XYXczVnRVNzJzakRMMFloWjMzOGtGTXNG?= =?utf-8?B?akM3bHc3U3Q0b2RwMkVPT3gwQkhOc0JaMGRmNldGa0d3dysrUW1GSnB6QTYz?= =?utf-8?B?MTVkMFVoRnJDcWtqTmxLVnBSMXArOFNad3oxZmduNXVMLzJPendDeDlVVGZE?= =?utf-8?B?RWZpZy91Qm5jYTFOdW9xM2M5Z3Z0SmozUnZLMytkR1dyTGlaZXNIM1VZMkcz?= =?utf-8?B?Y0ZnODduTktqRjM1VXhtbUxMVWNYSzFqTysxbDdIdTZTb3BVT2w3QkxwSkFU?= =?utf-8?B?NTlVQzZvRUlUcklEL2QvMHQ0Vk1jQ0VCMGduL1NpTEZEdlE5NWR6Wm5CRlZM?= =?utf-8?B?OWw4NzkzWGU0SE1wdWhhSjN3Uk90ZGZYTVdMNzVrL3VNVjY5c0swYmxZTm41?= =?utf-8?B?SGdtd2NoMDN5TDA2OHMrU1lKd2Z2SnB5bFhRaEZjZExJcXY2bFg0Q2NHeXg1?= =?utf-8?B?VXRDY1hmc1NpY1Z3WkFMZHBrZnlhT01Qd25SWnpIRDRNLzJ0NmxTQklQZTQx?= =?utf-8?B?NlZJTlJHQVF6MmZmOEthUU1NK3FOcWoxUzNqdUNkZDhHcWlkbGNKam9iL28r?= =?utf-8?B?Y2hHUlRPRmc4a1dzQWo0M0JzRVFRcm4vdlZZSU4rdmJkUE5neWQrK1BwNVZV?= =?utf-8?B?WThsUTZRODZObHRQZHk3V2pxM2JUbUdUV25pRDd2Z29VWkVObXZjYlNGc2d1?= =?utf-8?B?S2dvdXhmUFArZjdUSXlPb0xHQ3R5VGxTLzcveHhkR2hMa21ITFg0aTQvQ3pD?= =?utf-8?B?V2liWHhyQlJVc3liL1N1dUVYdk9QMWRONXhNeHFGSHBVZWxUTXVNWE9QdEdR?= =?utf-8?B?WUltbVRleHpETHFoT3FzUGZjSTBIM2FjZVZhSWNGOHdVSWxJbmxGTmJXZGRE?= =?utf-8?B?NXZqcCtVS0t1aFA4MzdYNzA5bGVSR2xkQXhvaW9YOUZKKzZHdXRIZU8reCtq?= =?utf-8?B?QUtROVY2dG5UejI4UmhYOXNQUXZrTTVvczNEYllrd1JxNTVMdlRYdmpyWU0v?= =?utf-8?B?VGdRQnFKNURLeGtJakpQQ211dEFrN1JWMHJoYlFyajVMQTJHQlpUT1o5cDk3?= =?utf-8?B?c0UranAvWlVFeEE0OGp4NXJEQ0M2OGNYTjBnSGlOVE1sN1ZwcGFuSWxFL3pH?= =?utf-8?B?TjFOb3daRFNzMDhZVUJWRGZRc251VlNVT2ZzNnFoZXRVc3VxM0o2eFozVGNj?= =?utf-8?B?SGdCU0NzTEkySGp0RzhHMjBaakprMFlPL1k5NEVROUpIc2NzdXZGWUtkYUs3?= =?utf-8?B?UTArTUVkMjN3MyttRU1vZjNyQnluRkN5NFpGck1XbXNpcmdiZk5IV0dyY0xv?= =?utf-8?B?Q1YvdnFaTkdvWTJPa0owcjVYWlZTS0lKL1RITURtdWFDUTZ0R2JhUW94TFR2?= =?utf-8?B?NDJNbVkvTnJvd0ZteTh5L0pONTIwVHE1dGFVcWJtQTk3TE8zL0xadEh0YVFZ?= =?utf-8?B?Q1JtVU1yNHlaSG9KVmZJb0xsUU9jRFhxYitxV0lNeWdKbXRnNWVhdmJ3azVH?= =?utf-8?B?eFhQd0svUGxYZjZmUHdjdC9Hdld5dFVNbDBERmY2bmJ0UVNabFczTG1nTTFY?= =?utf-8?B?cGx0dno1WloveFJYVXIwRVRLaWZxcWJ5R2hRTTRuSkt1akQwTzgwby9UalJI?= =?utf-8?B?QlBEeVJRR1NqVnYvdUhaYlVLenB2RDdTcTBwQ1dZakg4S3hQSnJwVXlWVnNV?= =?utf-8?B?TTdpT3VIbnB0NFk0cjJIOW5MQkxnT2crK3BOQ2VVQTFXaVZ2WlN5SUo4NTNB?= =?utf-8?B?YzNuT1ZBcEoxZ3N0NHFucXczZVhTNExKVW9ic2lSdkViZkZlZ21OSHVGdE5W?= =?utf-8?B?V0NIQk44cHhTUFUxeWFnbWlhbHEzN0J2L3BDZ3hDM1pvaHc9PQ==?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 08:50:50.5041 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 67e5984d-d4d3-4764-6962-08dcf4d22087 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DB3PEPF00008859.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR07MB7849 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add functional test suite to exercise the API. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger -- PATCH v6: * Update FOREACH invocations to match new API. RFC v5: * Adapt tests to reflect the removal of the GET() and SET() macros. RFC v4: * Check all lcore id's values for all variables in the many variables test case. * Introduce test case for max-sized lcore variables. RFC v2: * Improve alignment-related test coverage. --- app/test/meson.build | 1 + app/test/test_lcore_var.c | 432 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 433 insertions(+) create mode 100644 app/test/test_lcore_var.c diff --git a/app/test/meson.build b/app/test/meson.build index 0f7e11969a..7dccd197ac 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -104,6 +104,7 @@ source_file_deps = { 'test_ipsec_sad.c': ['ipsec'], 'test_kvargs.c': ['kvargs'], 'test_latencystats.c': ['ethdev', 'latencystats', 'metrics'] + sample_packet_forward_deps, + 'test_lcore_var.c': [], 'test_lcores.c': [], 'test_link_bonding.c': ['ethdev', 'net_bond', 'net'] + packet_burst_generator_deps + virtual_pmd_deps, diff --git a/app/test/test_lcore_var.c b/app/test/test_lcore_var.c new file mode 100644 index 0000000000..ddf70b03a0 --- /dev/null +++ b/app/test/test_lcore_var.c @@ -0,0 +1,432 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2024 Ericsson AB + */ + +#include +#include +#include + +#include +#include +#include + +#include "test.h" + +#define MIN_LCORES 2 + +RTE_LCORE_VAR_HANDLE(int, test_int); +RTE_LCORE_VAR_HANDLE(char, test_char); +RTE_LCORE_VAR_HANDLE(long, test_long_sized); +RTE_LCORE_VAR_HANDLE(short, test_short); +RTE_LCORE_VAR_HANDLE(long, test_long_sized_aligned); + +struct int_checker_state { + int old_value; + int new_value; + bool success; +}; + +static void +rand_blk(void *blk, size_t size) +{ + size_t i; + + for (i = 0; i < size; i++) + ((unsigned char *)blk)[i] = (unsigned char)rte_rand(); +} + +static bool +is_ptr_aligned(const void *ptr, size_t align) +{ + return ptr != NULL ? (uintptr_t)ptr % align == 0 : false; +} + +static int +check_int(void *arg) +{ + struct int_checker_state *state = arg; + + int *ptr = RTE_LCORE_VAR(test_int); + + bool naturally_aligned = is_ptr_aligned(ptr, sizeof(int)); + + bool equal = *(RTE_LCORE_VAR(test_int)) == state->old_value; + + state->success = equal && naturally_aligned; + + *ptr = state->new_value; + + return 0; +} + +RTE_LCORE_VAR_INIT(test_int); +RTE_LCORE_VAR_INIT(test_char); +RTE_LCORE_VAR_INIT_SIZE(test_long_sized, 32); +RTE_LCORE_VAR_INIT(test_short); +RTE_LCORE_VAR_INIT_SIZE_ALIGN(test_long_sized_aligned, sizeof(long), + RTE_CACHE_LINE_SIZE); + +static int +test_int_lvar(void) +{ + unsigned int lcore_id; + + struct int_checker_state states[RTE_MAX_LCORE] = {}; + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct int_checker_state *state = &states[lcore_id]; + + state->old_value = (int)rte_rand(); + state->new_value = (int)rte_rand(); + + *RTE_LCORE_VAR_LCORE(lcore_id, test_int) = state->old_value; + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) + rte_eal_remote_launch(check_int, &states[lcore_id], lcore_id); + + rte_eal_mp_wait_lcore(); + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct int_checker_state *state = &states[lcore_id]; + int value; + + TEST_ASSERT(state->success, "Unexpected value " + "encountered on lcore %d", lcore_id); + + value = *RTE_LCORE_VAR_LCORE(lcore_id, test_int); + TEST_ASSERT_EQUAL(state->new_value, value, + "Lcore %d failed to update int", lcore_id); + } + + /* take the opportunity to test the foreach macro */ + int *v; + unsigned int i = 0; + RTE_LCORE_VAR_FOREACH(lcore_id, v, test_int) { + TEST_ASSERT_EQUAL(i, lcore_id, "Encountered lcore id %d " + "while expecting %d during iteration", + lcore_id, i); + TEST_ASSERT_EQUAL(states[lcore_id].new_value, *v, + "Unexpected value on lcore %d during " + "iteration", lcore_id); + i++; + } + + return TEST_SUCCESS; +} + +static int +test_sized_alignment(void) +{ + unsigned int lcore_id; + long *v; + + RTE_LCORE_VAR_FOREACH(lcore_id, v, test_long_sized) { + TEST_ASSERT(is_ptr_aligned(v, alignof(long)), + "Type-derived alignment failed"); + } + + RTE_LCORE_VAR_FOREACH(lcore_id, v, test_long_sized_aligned) { + TEST_ASSERT(is_ptr_aligned(v, RTE_CACHE_LINE_SIZE), + "Explicit alignment failed"); + } + + return TEST_SUCCESS; +} + +/* private, larger, struct */ +#define TEST_STRUCT_DATA_SIZE 1234 + +struct test_struct { + uint8_t data[TEST_STRUCT_DATA_SIZE]; +}; + +static RTE_LCORE_VAR_HANDLE(char, before_struct); +static RTE_LCORE_VAR_HANDLE(struct test_struct, test_struct); +static RTE_LCORE_VAR_HANDLE(char, after_struct); + +struct struct_checker_state { + struct test_struct old_value; + struct test_struct new_value; + bool success; +}; + +static int check_struct(void *arg) +{ + struct struct_checker_state *state = arg; + + struct test_struct *lcore_struct = RTE_LCORE_VAR(test_struct); + + bool properly_aligned = + is_ptr_aligned(test_struct, alignof(struct test_struct)); + + bool equal = memcmp(lcore_struct->data, state->old_value.data, + TEST_STRUCT_DATA_SIZE) == 0; + + state->success = equal && properly_aligned; + + memcpy(lcore_struct->data, state->new_value.data, + TEST_STRUCT_DATA_SIZE); + + return 0; +} + +static int +test_struct_lvar(void) +{ + unsigned int lcore_id; + + RTE_LCORE_VAR_ALLOC(before_struct); + RTE_LCORE_VAR_ALLOC(test_struct); + RTE_LCORE_VAR_ALLOC(after_struct); + + struct struct_checker_state states[RTE_MAX_LCORE]; + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct struct_checker_state *state = &states[lcore_id]; + + rand_blk(state->old_value.data, TEST_STRUCT_DATA_SIZE); + rand_blk(state->new_value.data, TEST_STRUCT_DATA_SIZE); + + memcpy(RTE_LCORE_VAR_LCORE(lcore_id, test_struct)->data, + state->old_value.data, TEST_STRUCT_DATA_SIZE); + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) + rte_eal_remote_launch(check_struct, &states[lcore_id], + lcore_id); + + rte_eal_mp_wait_lcore(); + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct struct_checker_state *state = &states[lcore_id]; + struct test_struct *lstruct = + RTE_LCORE_VAR_LCORE(lcore_id, test_struct); + + TEST_ASSERT(state->success, "Unexpected value encountered on " + "lcore %d", lcore_id); + + bool equal = memcmp(lstruct->data, state->new_value.data, + TEST_STRUCT_DATA_SIZE) == 0; + + TEST_ASSERT(equal, "Lcore %d failed to update struct", + lcore_id); + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + char before = + *RTE_LCORE_VAR_LCORE(lcore_id, before_struct); + char after = + *RTE_LCORE_VAR_LCORE(lcore_id, after_struct); + + TEST_ASSERT_EQUAL(before, 0, "Lcore variable before test " + "struct was modified on lcore %d", lcore_id); + TEST_ASSERT_EQUAL(after, 0, "Lcore variable after test " + "struct was modified on lcore %d", lcore_id); + } + + return TEST_SUCCESS; +} + +#define TEST_ARRAY_SIZE 99 + +typedef uint16_t test_array_t[TEST_ARRAY_SIZE]; + +static void test_array_init_rand(test_array_t a) +{ + size_t i; + for (i = 0; i < TEST_ARRAY_SIZE; i++) + a[i] = (uint16_t)rte_rand(); +} + +static bool test_array_equal(test_array_t a, test_array_t b) +{ + size_t i; + for (i = 0; i < TEST_ARRAY_SIZE; i++) { + if (a[i] != b[i]) + return false; + } + return true; +} + +static void test_array_copy(test_array_t dst, const test_array_t src) +{ + size_t i; + for (i = 0; i < TEST_ARRAY_SIZE; i++) + dst[i] = src[i]; +} + +static RTE_LCORE_VAR_HANDLE(char, before_array); +static RTE_LCORE_VAR_HANDLE(test_array_t, test_array); +static RTE_LCORE_VAR_HANDLE(char, after_array); + +struct array_checker_state { + test_array_t old_value; + test_array_t new_value; + bool success; +}; + +static int check_array(void *arg) +{ + struct array_checker_state *state = arg; + + test_array_t *lcore_array = RTE_LCORE_VAR(test_array); + + bool properly_aligned = + is_ptr_aligned(lcore_array, alignof(test_array_t)); + + bool equal = test_array_equal(*lcore_array, state->old_value); + + state->success = equal && properly_aligned; + + test_array_copy(*lcore_array, state->new_value); + + return 0; +} + +static int +test_array_lvar(void) +{ + unsigned int lcore_id; + + RTE_LCORE_VAR_ALLOC(before_array); + RTE_LCORE_VAR_ALLOC(test_array); + RTE_LCORE_VAR_ALLOC(after_array); + + struct array_checker_state states[RTE_MAX_LCORE]; + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct array_checker_state *state = &states[lcore_id]; + + test_array_init_rand(state->new_value); + test_array_init_rand(state->old_value); + + test_array_copy(*RTE_LCORE_VAR_LCORE(lcore_id, test_array), + state->old_value); + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) + rte_eal_remote_launch(check_array, &states[lcore_id], + lcore_id); + + rte_eal_mp_wait_lcore(); + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + struct array_checker_state *state = &states[lcore_id]; + test_array_t *larray = RTE_LCORE_VAR_LCORE(lcore_id, test_array); + + TEST_ASSERT(state->success, "Unexpected value encountered on " + "lcore %d", lcore_id); + + bool equal = test_array_equal(*larray, state->new_value); + + TEST_ASSERT(equal, "Lcore %d failed to update array", + lcore_id); + } + + RTE_LCORE_FOREACH_WORKER(lcore_id) { + char before = + *RTE_LCORE_VAR_LCORE(lcore_id, before_array); + char after = + *RTE_LCORE_VAR_LCORE(lcore_id, after_array); + + TEST_ASSERT_EQUAL(before, 0, "Lcore variable before test " + "array was modified on lcore %d", lcore_id); + TEST_ASSERT_EQUAL(after, 0, "Lcore variable after test " + "array was modified on lcore %d", lcore_id); + } + + return TEST_SUCCESS; +} + +#define MANY_LVARS (2 * RTE_MAX_LCORE_VAR / sizeof(uint32_t)) + +static int +test_many_lvars(void) +{ + uint32_t **handlers = malloc(sizeof(uint32_t *) * MANY_LVARS); + unsigned int i; + + TEST_ASSERT(handlers != NULL, "Unable to allocate memory"); + + for (i = 0; i < MANY_LVARS; i++) { + unsigned int lcore_id; + + RTE_LCORE_VAR_ALLOC(handlers[i]); + + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + uint32_t *v = + RTE_LCORE_VAR_LCORE(lcore_id, handlers[i]); + *v = (uint32_t)(i * lcore_id); + } + } + + for (i = 0; i < MANY_LVARS; i++) { + unsigned int lcore_id; + + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + uint32_t v = *RTE_LCORE_VAR_LCORE(lcore_id, handlers[i]); + TEST_ASSERT_EQUAL((uint32_t)(i * lcore_id), v, + "Unexpected lcore variable value on " + "lcore %d", lcore_id); + } + } + + free(handlers); + + return TEST_SUCCESS; +} + +static int +test_large_lvar(void) +{ + RTE_LCORE_VAR_HANDLE(unsigned char, large); + unsigned int lcore_id; + + RTE_LCORE_VAR_ALLOC_SIZE(large, RTE_MAX_LCORE_VAR); + + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + unsigned char *ptr = RTE_LCORE_VAR_LCORE(lcore_id, large); + + memset(ptr, (unsigned char)lcore_id, RTE_MAX_LCORE_VAR); + } + + for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { + unsigned char *ptr = RTE_LCORE_VAR_LCORE(lcore_id, large); + size_t i; + + for (i = 0; i < RTE_MAX_LCORE_VAR; i++) + TEST_ASSERT_EQUAL(ptr[i], (unsigned char)lcore_id, + "Large lcore variable value is " + "corrupted on lcore %d.", + lcore_id); + } + + return TEST_SUCCESS; +} + +static struct unit_test_suite lcore_var_testsuite = { + .suite_name = "lcore variable autotest", + .unit_test_cases = { + TEST_CASE(test_int_lvar), + TEST_CASE(test_sized_alignment), + TEST_CASE(test_struct_lvar), + TEST_CASE(test_array_lvar), + TEST_CASE(test_many_lvars), + TEST_CASE(test_large_lvar), + TEST_CASES_END() + }, +}; + +static int test_lcore_var(void) +{ + if (rte_lcore_count() < MIN_LCORES) { + printf("Not enough cores for lcore_var_autotest; expecting at " + "least %d.\n", MIN_LCORES); + return TEST_SKIPPED; + } + + return unit_test_suite_runner(&lcore_var_testsuite); +} + +REGISTER_FAST_TEST(lcore_var_autotest, true, false, test_lcore_var); -- 2.43.0