From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id EF79F45BDF;
Sat, 26 Oct 2024 12:25:53 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6805F402AF;
Sat, 26 Oct 2024 12:25:49 +0200 (CEST)
Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])
by mails.dpdk.org (Postfix) with ESMTP id 4F77B4027A
for <dev@dpdk.org>; Sat, 26 Oct 2024 12:25:46 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.163.44])
by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4XbG3P3QBzz2DdlL;
Sat, 26 Oct 2024 18:24:17 +0800 (CST)
Received: from kwepemf500004.china.huawei.com (unknown [7.202.181.242])
by mail.maildlp.com (Postfix) with ESMTPS id 73E051400D3;
Sat, 26 Oct 2024 18:25:44 +0800 (CST)
Received: from localhost.localdomain (10.28.79.22) by
kwepemf500004.china.huawei.com (7.202.181.242) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.1544.11; Sat, 26 Oct 2024 18:25:43 +0800
From: Jie Hai <haijie1@huawei.com>
To: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Chengwen
Feng <fengchengwen@huawei.com>, Kevin Laatz <kevin.laatz@intel.com>, Bruce
Richardson <bruce.richardson@intel.com>, Conor Walsh <conor.walsh@intel.com>,
Sean Morrissey <sean.morrissey@intel.com>
CC: <lihuisong@huawei.com>, <haijie1@huawei.com>, <huangdengdui@huawei.com>
Subject: [PATCH v4 01/13] dmadev: replace strtok with reentrant version
Date: Sat, 26 Oct 2024 18:14:39 +0800
Message-ID: <20241026101451.29135-2-haijie1@huawei.com>
X-Mailer: git-send-email 2.22.0
In-Reply-To: <20241026101451.29135-1-haijie1@huawei.com>
References: <20231113104550.2138654-1-haijie1@huawei.com>
<20241026101451.29135-1-haijie1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.28.79.22]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
kwepemf500004.china.huawei.com (7.202.181.242)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.
The strtok() is non-reentrant, it is better to replace it with a
reentrant version.
Fixes: 39b5ab60df30 ("dmadev: add telemetry")
Cc: stable@dpdk.org
Signed-off-by: Jie Hai <haijie1@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
lib/dmadev/rte_dmadev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
index 8bb7824aa129..5c5ac78ae9c4 100644
--- a/lib/dmadev/rte_dmadev.c
+++ b/lib/dmadev/rte_dmadev.c
@@ -1016,7 +1016,7 @@ dmadev_handle_dev_stats(const char *cmd __rte_unused,
struct rte_dma_info dma_info;
struct rte_dma_stats dma_stats;
int dev_id, ret, vchan_id;
- char *end_param;
+ char *end_param, *sp = NULL;
const char *vchan_param;
if (params == NULL || strlen(params) == 0 || !isdigit(*params))
@@ -1035,7 +1035,7 @@ dmadev_handle_dev_stats(const char *cmd __rte_unused,
if (dma_info.nb_vchans == 1 && *end_param == '\0')
vchan_id = 0;
else {
- vchan_param = strtok(end_param, ",");
+ vchan_param = strtok_r(end_param, ",", &sp);
if (!vchan_param || strlen(vchan_param) == 0 || !isdigit(*vchan_param))
return -EINVAL;
--
2.22.0