From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 72EEA45BEC;
Sun, 27 Oct 2024 04:08:46 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1E8FB402EB;
Sun, 27 Oct 2024 04:08:40 +0100 (CET)
Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com
[209.85.215.182])
by mails.dpdk.org (Postfix) with ESMTP id 4B29240272
for <dev@dpdk.org>; Sun, 27 Oct 2024 04:08:37 +0100 (CET)
Received: by mail-pg1-f182.google.com with SMTP id
41be03b00d2f7-7ea7e250c54so2399774a12.0
for <dev@dpdk.org>; Sat, 26 Oct 2024 20:08:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729998516;
x=1730603316; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=3yA3kW0Wjdz4YLMxOXguyMGlxyAcxh1+uYohUOUDr68=;
b=aZtW+XheHDiTVxHNv9+aj0JQP0nSKlpBSN5X9AUPAFEkqP5c8cTOXHWkevEN8FU32G
UDBvllHIrksFbjJ4kUT8b464QxxsJN82Qus68Z3AL++iIohhg8MfUzTAcS9bLSjLxFpn
FTV08uDFbh8e/3EorRsWyP9LErpmY7fuImTWpog2jpU+V03IDEhWiWU4kYA8766dRuJ6
aB8cqKKMZxtQ+Xu9413qVpnvmXOwIpiAS3gAR2hkpvAEGt5pQwZxB4P8mMPXOrEWni4U
JljbQTcMVRWwW0ylkNT34lsE8cqgxZai4Ogrf4f40k7wkCAwl7Y7nvE62uYlZO3dQwp/
O59Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1729998516; x=1730603316;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=3yA3kW0Wjdz4YLMxOXguyMGlxyAcxh1+uYohUOUDr68=;
b=dHwpRZHtoI9ARRdoFJtgUYYBaIbycRAjuMQwpXF4a6HDCEZCmJx00A6ecIrqSOmRMR
pqm0+9HYaDmrSt9zmz5XuOkVjTEiuQeg6geJXLVP4qm1HRF4NbCKhxYH9n567dsabpbE
a73EGWtAfe7DrxrQbw2TdBBYDXTjClp2bJ6I8YNFQiZBPp7R+7GLWGY2eSyHGFhCf8lt
PSP+EcZzvF7RK3fF2H4zwu+9OvV8iCyAxNiwdKwQ5lGEgN49haK4dLrLAXkngulF/y1s
rc1AeYUm3zjDdCzUJ3vwBxtsvEgyjtmLI28rkw5kYi4HpmKVlpeVBvrbCiZNl1nfW/xR
qfcA==
X-Gm-Message-State: AOJu0YzXWwE/NfC1zZwlj5Jej9Q0Hq3W3lkXmg3cJXHUcooptIwGwzBE
sUfyfi9ZNFpb+81B4XVt/n2ni8OeQBauy249uoNoDNfspHkApla+yMTFKtoCAsw=
X-Google-Smtp-Source: AGHT+IGjnyu4u9J8LJYvZLp9boAL79O2Za061owof7ZpCBkJLk5FJIyELMKwcNk8AQkEVcBkO1sFZg==
X-Received: by 2002:a05:6a21:1690:b0:1d7:cc6:53d0 with SMTP id
adf61e73a8af0-1d9a83a3fd9mr6317854637.5.1729998516389;
Sat, 26 Oct 2024 20:08:36 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-72057931766sm3384534b3a.49.2024.10.26.20.08.35
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 26 Oct 2024 20:08:36 -0700 (PDT)
Date: Sat, 26 Oct 2024 20:01:57 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jie Hai <haijie1@huawei.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Andrew
Rybchenko <andrew.rybchenko@oktetlabs.ru>, <lihuisong@huawei.com>,
<fengchengwen@huawei.com>, <huangdengdui@huawei.com>
Subject: Re: [PATCH v4 03/13] ethdev: replace strtok with reentrant version
Message-ID: <20241026200157.31212a16@hermes.local>
In-Reply-To: <20241026101451.29135-4-haijie1@huawei.com>
References: <20231113104550.2138654-1-haijie1@huawei.com>
<20241026101451.29135-1-haijie1@huawei.com>
<20241026101451.29135-4-haijie1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Sat, 26 Oct 2024 18:14:41 +0800
Jie Hai <haijie1@huawei.com> wrote:
> Multiple threads calling the same function may cause condition
> race issues, which often leads to abnormal behavior and can cause
> more serious vulnerabilities such as abnormal termination, denial
> of service, and compromised data integrity.
>=20
> The strtok() is non-reentrant, it is better to replace it with a
> reentrant version.
>=20
> Fixes: f38f62650f7b ("ethdev: add Rx queue telemetry query")
> Fixes: 9e7533aeb80a ("ethdev: add telemetry command for TM level capabili=
ties")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com>
Only called from RTE_INIT() so naturally single threaded.
No need for this one in stable.