From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6DE245BEC; Sun, 27 Oct 2024 04:08:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09286402E5; Sun, 27 Oct 2024 04:08:37 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 84308402B8 for <dev@dpdk.org>; Sun, 27 Oct 2024 04:08:35 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7203c74e696so2369268b3a.0 for <dev@dpdk.org>; Sat, 26 Oct 2024 20:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729998514; x=1730603314; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CT9XmxEv2qA8P3nhrXW78RH4dOPBFeS0G/IO01S/gW0=; b=PGijX9FcvzoHr5jUsl5v5CkyugDhxw5fKexNgZeWqpjrEG2pjwxYrZh1PD7BpY4XLX Nx43+2hQXX3ZNjbaa84cS+qLWxV+K0RTtHidBlfO7HTnZNhboDnUm09l0yGnJxJ0Ye1M ano4gNOpeI/IZRiBXOCD1UTH4R2/Vm9w+4qdFE03EVBNPQjYIEcpVCP5PPbjOjC13Ku8 Vt8m4L+j8xZWvK2vT0le4CB0NFFdvwSIYIi9bGRrJc2zANUyd6dWecbklL84E2IohIB1 eNy/k70/GAso9JCMsElYTmM+T18REpbaain+awBpWF+yTo9sfUoK9FLPDYJ/i0G50b9Q isYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729998514; x=1730603314; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CT9XmxEv2qA8P3nhrXW78RH4dOPBFeS0G/IO01S/gW0=; b=vWfOxBD4Y/uFNHpMpqSWWEH+cZbZQBczbs5NJA3ZSttS46W+nK9rVwK1w+0ZT1LCyS YOSyIn+WJmbrDqzeoRyUVTZ3L6MitU9S7xcMAlOvZOy6+hv7ahsGF8GSMvvcvSeR4Kll g6O2p/azxnpikMJGerSNWyXhHgYmyeuFwsjvStWENfd++PH3fkyXHOgDTNxPwXz66SIa vB2nbCPBWfd/dD4uQimEtSwgr6bvWycBqIg8NXxPj71thKGtuYjKFIrnWYwvNcNYjIMA 2L/i74PoFS4kTyFhm1giulmYitMReVzDyh9JleJUhK5QPlfPFBa4LSJyNVGwxWGwRYiq 28fg== X-Gm-Message-State: AOJu0YziLJ0NyQnyhapxvtS6lLg1Q97UuI4q9W5Db71rxid/9iq7rhbK YBvDKoGrbDFs+72mc/Sm8XLgZhC5N/f1f3tAxgNrTY1aNfHOQbW+nAr7WOpsWpA= X-Google-Smtp-Source: AGHT+IE0INtWovt8ttliSqJyvobPLytjuOGI76v18k2dtRfhMyrk6bYcoGDK/I1/3iDxxWF2JBXujA== X-Received: by 2002:a05:6a00:180e:b0:71e:51ae:d765 with SMTP id d2e1a72fcca58-720630a839cmr7294783b3a.27.1729998514122; Sat, 26 Oct 2024 20:08:34 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057931766sm3384534b3a.49.2024.10.26.20.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 20:08:33 -0700 (PDT) Date: Sat, 26 Oct 2024 20:02:44 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Jie Hai <haijie1@huawei.com> Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Naga Harish K S V <s.v.naga.harish.k@intel.com>, Jerin Jacob <jerinj@marvell.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <huangdengdui@huawei.com> Subject: Re: [PATCH v4 04/13] eventdev: replace strtok with reentrant version Message-ID: <20241026200244.06ef381b@hermes.local> In-Reply-To: <20241026101451.29135-5-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20241026101451.29135-1-haijie1@huawei.com> <20241026101451.29135-5-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Sat, 26 Oct 2024 18:14:42 +0800 Jie Hai <haijie1@huawei.com> wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. >=20 > The strtok() is non-reentrant, it is better to replace it with a > reentrant version. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Jie Hai <haijie1@huawei.com> > Acked-by: Chengwen Feng <fengchengwen@huawei.com> > Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com> Yet another function only called from RTE_INIT()