From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B93245BF5; Sun, 27 Oct 2024 18:27:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 268A040665; Sun, 27 Oct 2024 18:26:40 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 2A84D402E2 for <dev@dpdk.org>; Sun, 27 Oct 2024 18:26:32 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-20c6f492d2dso39325755ad.0 for <dev@dpdk.org>; Sun, 27 Oct 2024 10:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730049991; x=1730654791; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=pUIbeV75/Dh1lTsDSuZcBYAuUKzqI7m/SIdekBr8gZlAlbpguMpIwTI88rbgLXzMbi /ihWF24vgQFQIdn5oNcB2HOo4FMxh1KX2Mnc+5lW8JkqWFqCf3DJzPMVC49iAG2vExE2 WdKjSkv90EBqSaN8BLEwp/3ZJP4k99D9ytKPH6CSlAy/bkdSBmXcGJszf0+eMuT8wQjW PALr5T+pwct871qSVuBIQGP62PIaPWsQCK82m70UGlvyXGbY+1ztx90KvO8il99cNY5X /9M1HLnYQxci2gCt3oCXndoYaIhfuaXVPYo/9jlebtCyN2b3YLzsAcy8tU0NTRARICUg gKtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730049991; x=1730654791; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=fB2IrLO2DsquegYzjMuQ7VWh/IfjOtD/dDBrXQX8FUOR3UHyS3bnrQW+TtNbxpcVka 3ON/9gm8IBi5nW7MFt0NP2frZ+Ya7qNCY5+X38a0fjocsMg4wpGeBxAPUtCIe5UDq/TP 7+udz8ZHRBsV/Uwmp/667WNNDMz7BNQYvUMqwT+Rkg16l3t/so0X1IMGIAGp6niW/KdF 1o74vva5mhuEiyJDvTkUPU69lntK2Rq1luNPUhgVIP6wUhUkc22dmSwej3SBXPzr1XHB xOJyrNJ9KPGXd5hYajQmYS/Me6e5yribdhszFfp06OpPXJ74E0THw+nGMBXtg43xTX0t wzbA== X-Gm-Message-State: AOJu0YxUnLVBPYNqRa2g8uaylS7gF9XsF/s6mZAqNd3cGxXlZLDfTxlw i5SjAi/vuocMzjM/UonIOr6TqqdoSFNe/oS2p1hqip4H785QKsNp5tbXrU58Reozr7KpLXu1MOF 7Z/NB+w== X-Google-Smtp-Source: AGHT+IGcqECVmzX9uuTu354hWW+aNT80tF0hqlhvqiZczrgHip0MACsZPok9NclEY94UhHJ0/sROzw== X-Received: by 2002:a17:902:f60d:b0:20c:ad30:6b97 with SMTP id d9443c01a7336-210c6c6c57cmr84558485ad.38.1730049991345; Sun, 27 Oct 2024 10:26:31 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf71d50sm37754465ad.72.2024.10.27.10.26.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 10:26:31 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Tyler Retzlaff <roretzla@linux.microsoft.com>, =?UTF-8?q?Morten=20Br=C3=B8rup?= <mb@smartsharesystems.com>, Bruce Richardson <bruce.richardson@intel.com>, Chengwen Feng <fengchengwen@huawei.com> Subject: [PATCH v30 06/13] eal: change rte_exit() output to match rte_log() Date: Sun, 27 Oct 2024 10:24:36 -0700 Message-ID: <20241027172616.176175-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241027172616.176175-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241027172616.176175-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with code: 1 [ 0.006250] EAL: Cannot init EAL: Permission denied Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com> Acked-by: Morten Brørup <mb@smartsharesystems.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Chengwen Feng <fengchengwen@huawei.com> --- lib/eal/common/eal_common_debug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c index 3e77995896..bcfcd6df6f 100644 --- a/lib/eal/common/eal_common_debug.c +++ b/lib/eal/common/eal_common_debug.c @@ -36,15 +36,13 @@ rte_exit(int exit_code, const char *format, ...) va_list ap; if (exit_code != 0) - RTE_LOG(CRIT, EAL, "Error - exiting with code: %d\n" - " Cause: ", exit_code); + EAL_LOG(CRIT, "Error - exiting with code: %d", exit_code); va_start(ap, format); rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); va_end(ap); if (rte_eal_cleanup() != 0 && rte_errno != EALREADY) - EAL_LOG(CRIT, - "EAL could not release all resources"); + EAL_LOG(CRIT, "EAL could not release all resources"); exit(exit_code); } -- 2.45.2