From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DA5045BC0; Tue, 29 Oct 2024 17:22:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C93A42EA0; Tue, 29 Oct 2024 17:22:38 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 2B01A42E48 for <dev@dpdk.org>; Tue, 29 Oct 2024 17:22:37 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7d4fa972cbeso4828775a12.2 for <dev@dpdk.org>; Tue, 29 Oct 2024 09:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730218956; x=1730823756; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=k0Mbi9twF39hayBOJpUxjWBVVgR6gJlIWu+hkDh8keI=; b=oAgB8z8wol7plBmsbwPI4s2xZidfpI/eeASa4dMKJfNaCuFQZ+6uIaKjieDbb1QINU dseezdXp7/N1+mtRj556En2bGVW7P2zPyD35LE4EOYHhXfymHyUtab+zP1nnLbeQwprn S6S16/izGii64QaNr+PVDQx8Y6/pVvbmYcu5OEq9WEszCQrQzV8/Q28ofkwtByWiW7vk QkQoqMfm5WIH4uqdgFEBiK8FYia3a59E+ixxVEEOToS9KSkG0BL2qfPDC7zLVjDy/Shu 0rTJ44iS/6YujWLaq7ejw9FBbw1qfLCpKHlfWxyrrmu+I2U2d/nu1wYyczffHs1IQJG+ hEOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730218956; x=1730823756; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k0Mbi9twF39hayBOJpUxjWBVVgR6gJlIWu+hkDh8keI=; b=kyZ+/rxiI32pHFEeTcRYxH9N6b2frp/6zNig3U3GRFFHtdM7Iw135l67oVHgHikxrd ZlEGh5riyGEt26pZd00gx9qs7YofXmkJ+x+cjygphTrgya0tkMqKwenKDa6vX5BZ74gi NmdyDJrHzWJOSHhaWIhQ58Dm2VhKBtI1I3yJBkPW51VZ/iw6EazGzFJmHzGG3XdtFQnj QyD3sgmyzbLkdkWhq60jq5IqI4hlXFDUAGpxa/mgcKObE4Ob8PJoGwt7Wo7LFRBfeSDe iivQwDgVNx4Nj8sx2fyV4RF+w6btG/OX2j8B40DudPlRJ/gwSpTpApvd3hMY0zdTniGO +DAg== X-Forwarded-Encrypted: i=1; AJvYcCXjs7h3xQ+m4fgkEWxnJzs8HVbqww9RqmnszP+eX/frA8owWZESGjeHuZ9Qh+WBwWnjDF0=@dpdk.org X-Gm-Message-State: AOJu0Yxtk27nezRf5Qhe8cM0ABlvrlr90VY5Z/LPqx1SqtCizQVwqX7P vpO8OFSX0FfYC9axu23lJy+D79Rd2KsRQy1OP0CLk+M3GewuNGzTJltIgwgftks= X-Google-Smtp-Source: AGHT+IFqrkZGEH8R6kDd1WoZ9wUB8PDi4qV57/rBgl1Ql25juU2ZiBModkTPRB8VjBXb+/2sbGJPdA== X-Received: by 2002:a05:6a20:2d8a:b0:1d9:c718:4cc with SMTP id adf61e73a8af0-1d9c718061emr7834542637.6.1730218956256; Tue, 29 Oct 2024 09:22:36 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057a21078sm7768091b3a.169.2024.10.29.09.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 09:22:36 -0700 (PDT) Date: Tue, 29 Oct 2024 09:22:34 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: <shaibran@amazon.com> Cc: <ferruh.yigit@amd.com>, <dev@dpdk.org>, Amit Bernstein <amitbern@amazon.com> Subject: Re: [PATCH 1/1] net/ena: add histogram support Message-ID: <20241029092234.0935fd9a@hermes.local> In-Reply-To: <20241029080215.5069-2-shaibran@amazon.com> References: <20241029080215.5069-1-shaibran@amazon.com> <20241029080215.5069-2-shaibran@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, 29 Oct 2024 10:02:15 +0200 <shaibran@amazon.com> wrote: > From: Shai Brandes <shaibran@amazon.com> > > The framework computes the differences between specified > start and end points in the code, providing insights into > performance by outputting a histogram of the time intervals. > The histogram can be used to track metrics like packet > processing latency in the network driver. > This framework requires enablement via a compilation > flag and is excluded in release builds by default. > > Signed-off-by: Amit Bernstein <amitbern@amazon.com> > Signed-off-by: Shai Brandes <shaibran@amazon.com> Could this be generic for all PMD's and built off of existing DPDK trace mechanism? Yes, histogram is useful. But IMHO DPDK should discourage PMD specific features.