From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6C9AC45B4C;
Tue, 29 Oct 2024 15:32:47 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 447E642E9C;
Tue, 29 Oct 2024 15:32:32 +0100 (CET)
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
(mail-bn7nam10on2084.outbound.protection.outlook.com [40.107.92.84])
by mails.dpdk.org (Postfix) with ESMTP id A8CBF42E80;
Tue, 29 Oct 2024 15:32:25 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=Z+qy7K5CcqTNgoXCPO8+t2yCKIJloNAlN9S8PEF6aoM6r0HW9KKxG898UUkdh2FUIeROf5xJp/zJ18jLI8MR2d/kuqqHJBKcYzfOc4yLv1jcUtOK7ycM2z9HUiZhHz/RXpCBEcmDAWn213Qqr9XZOsy1lnGVagY4grvhBAs4kg/gOjoQFU3NyWCfeTpR+lCxztFtXYgaPdqMavzezq574Q/4vO1Xyp4a9sEDl2QoPV8JZ7yPoynJHLQFdYcXZUXHt2t/u+zcWsLHmVjQfmtmXI2l2K4njVnqN71dm4eW2q8TYHauS9VS2K4JKcIk2pmnb4gSvMHerBxKk2zTACUvig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=htQ+aK34Jum5czOtPgDnOeUfGDaUEddCTsukZmu1+4U=;
b=FSEIMpzz0ZB3Qzh5qnVHYSAf9VBI78RIOocbZxsOndAIbpvWaN66rHo/4Rjfxyi0/3EGoGw9gyLh7X3PHcw0UtHW5+4DNh54Uw2ASVq66pyd0CnlFP1qTaGGzrX1zfvTnbceDcjcrQZctp1YEKA381YytwKLrVGa96dzFNopj/6n/IkLlshuXjO3LjWWD7GdIELcQzqwHCwhFVEn+G0cWF3AEsbDmBt0GzuaU5nq2ZV2JXLjxSrKLB+caqlLKU1uEiLj2gb0adQAJw5JlaWh+JpZCwa3ez673HKepFJpS0FiWPWwpHMnoQ2JNRmzdsDe54LVHRHITmsQVyhv2MbUrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;
dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;
dkim=none (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=htQ+aK34Jum5czOtPgDnOeUfGDaUEddCTsukZmu1+4U=;
b=VeswqGlY1IkVJonRs3OapZmEQQWp98K4Nkxqycmm2zYEtdVtGXAhXcvaWuyWhsr+YyBrHikbBh8gjZOAswpRQ7zxMUAdSpkhTi/yce2g4T7BIX5O/P/FJFcf6Qbfzg5WQfkmh4SgLMILCUTSaVlM9vVAJfoDyXicpzqYBHSbxewKjvklhEQOXI5raqurm8kRvBQ2rKpqMNwCAsnI8UlL7Y9Gq7LwtyA9NKU/sqHhcfYzsnrZocHCbQKlx+n7kWpDExzt3VFLYHMeUtfwTLIK5l5A+CAZuWwLmRj1MAHEXsNweHborvBRYDTvodsGZ+pDWvT6xlXWOAZpc5HonYwNEQ==
Received: from BN9PR03CA0561.namprd03.prod.outlook.com (2603:10b6:408:138::26)
by MN0PR12MB5787.namprd12.prod.outlook.com (2603:10b6:208:376::9)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.25; Tue, 29 Oct
2024 14:32:19 +0000
Received: from BN3PEPF0000B06F.namprd21.prod.outlook.com
(2603:10b6:408:138:cafe::c5) by BN9PR03CA0561.outlook.office365.com
(2603:10b6:408:138::26) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.29 via Frontend
Transport; Tue, 29 Oct 2024 14:32:19 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161)
smtp.mailfrom=nvidia.com;
dkim=none (message not signed)
header.d=none;dmarc=pass action=none header.from=nvidia.com;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
216.228.117.161 as permitted sender) receiver=protection.outlook.com;
client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C
Received: from mail.nvidia.com (216.228.117.161) by
BN3PEPF0000B06F.mail.protection.outlook.com (10.167.243.74) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8137.0 via Frontend Transport; Tue, 29 Oct 2024 14:32:18 +0000
Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com
(10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 29 Oct
2024 07:31:46 -0700
Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com
(10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 29 Oct
2024 07:31:43 -0700
From: "Minggang Li(Gavin)" <gavinl@nvidia.com>
To: <viacheslavo@nvidia.com>, <matan@nvidia.com>, <orika@nvidia.com>,
<thomas@monjalon.net>, Dariusz Sosnowski <dsosnowski@nvidia.com>, Bing Zhao
<bingz@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>, Spike Du
<spiked@nvidia.com>
CC: <dev@dpdk.org>, <rasland@nvidia.com>, <stable@dpdk.org>
Subject: [PATCH V3 4/7] common/mlx5: fix Netlink socket leak
Date: Tue, 29 Oct 2024 16:31:15 +0200
Message-ID: <20241029143118.875214-5-gavinl@nvidia.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20241029143118.875214-1-gavinl@nvidia.com>
References: <20241029134256.874767-8-gavinl@nvidia.com>
<20241029143118.875214-1-gavinl@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.126.231.35]
X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To
rnnvmail201.nvidia.com (10.129.68.8)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN3PEPF0000B06F:EE_|MN0PR12MB5787:EE_
X-MS-Office365-Filtering-Correlation-Id: 4840c18c-6342-4559-35cc-08dcf8267e24
X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
ARA:13230040|82310400026|376014|36860700013|1800799024;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1Q0jNPuB3oiExNpbvh3jluh3lU6nA0s0LPRtVJqQlPbMyExBr3OVV35MMbV4?=
=?us-ascii?Q?Qwh7Vw9cqNCGgT4qCPstxkk9ox8P/T6eD/gousk/tH5EcIDtsrs3KoQns2dO?=
=?us-ascii?Q?nHWfqcl1AO9augUfuffr1r9XJ0kvP3t2VsK0LaPziDBdGZux5VftYsu7hJ+H?=
=?us-ascii?Q?Agy2/oK6LfGCzhZUPjnZYf5QVknjautjR/TVJmBqIZeg648J9oMUkzhJMp21?=
=?us-ascii?Q?pZpzs1p1C7awWL9/P+hTZRmevbMmc5g8LQYzJtAaHOXAjn8/kRA1IJ1JLSdL?=
=?us-ascii?Q?CPnVCvRzZLv7VXXbjdUDHNTPQQdwPtLagS04FKRhDp6ytNQP7fy6tmapRKCU?=
=?us-ascii?Q?ncZIQVAwWtO99oZs649nMLtjnJsC81v93MhHOq13cgHFQWw8PmvVmKa2fzA1?=
=?us-ascii?Q?WIMtXeKfT2GzeBVjjNGzeqIuGdE9Jf9WXQx5cKmYhJ9djFuPuWc7ojiAlprj?=
=?us-ascii?Q?V5npzsg0M3wTcOQkq7yvaMXHBKgAqGATsQpaOIh4RCn85BDrORAt8ZNuFUPG?=
=?us-ascii?Q?YErYBJLcvglltEb2YNoUewLnG0Ghh+li+hXQ418KY+St8DQykGe2N23zwwyi?=
=?us-ascii?Q?aQ2RWFE6jKr6ecLtJ/VpGgJMSwRRT8Kbo7ixYMBa8inBIYcE04vWgLPQwX44?=
=?us-ascii?Q?SguOvAJoe4PDj5pDoBE3MPOMl/2UwdjimjIVJUvORyv/PJziC/FS5E7BEPyY?=
=?us-ascii?Q?TNQyMS18/5k+94ddqn6/U66S23t7w4YFMp7YLSSOJrSBe2BgYRk6FrRJQUJs?=
=?us-ascii?Q?AG5Sfw/pRno57UR5muyr9jpvRNidk7NfgdixjFN9UFl+Y46/wqHnTAA//3lf?=
=?us-ascii?Q?dQ3SAJ2/LWQAf4vOjs4gOQVOg17k2KTzZ1iD8f4+aai8FU1KCgKPsZX/jsjb?=
=?us-ascii?Q?6QZWMCPslfZYKD62x5Q7ZvhFxx0gHRh2aHebFGtX+gabdYVgrHs7Wr/m5g1i?=
=?us-ascii?Q?3o+DCXmHS7aRVQT8N0dFKmAyxMWkTEkTpR2g7nL3eXBFtyNGFQRnhgHg5tLX?=
=?us-ascii?Q?K0St9m+X9y6BzEcUq9ppFk1Kg/U8AIzql4uPEQwqlDZzKywGhIAs+Dp+iP1m?=
=?us-ascii?Q?FxtjarJ8AeNs5p4gk3CdizLy76ndyTBeIb6mAtZihB0MZBhiCGO2XGq1m63l?=
=?us-ascii?Q?RxVOzlsZU7J0LgQV8Py9arK95G+CHMaisJFMtgKhcauV9ynf/Pez/opiLiOs?=
=?us-ascii?Q?S982accSsyY4ePRY8MD/CTcsjBvEd67l2Elacap4T4oNdI6+VW75p4cDaviF?=
=?us-ascii?Q?hMpxYic+MAKYyA3S3lYmcjYISgn92GTrTJZ1GrX8wWlPGVIdWhsYjxuZnqxr?=
=?us-ascii?Q?VJa5S6OLNITu/smejxG69U5Z+QCFE4XjLEwe3WLPNKW3dxlanKpV+oSrenWm?=
=?us-ascii?Q?CQwdWWwvYohno8AMg8mzplrPBzYIALwua0lF3AY7/GiDNsJq1Q=3D=3D?=
X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;
SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024); DIR:OUT;
SFP:1101;
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2024 14:32:18.6484 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4840c18c-6342-4559-35cc-08dcf8267e24
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];
Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B06F.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5787
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Fixes: 72d7efe464b1 ("common/mlx5: share interrupt management")
Cc: stable@dpdk.org
Signed-off-by: Minggang Li(Gavin) <gavinl@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/net/mlx5/linux/mlx5_os.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index 695936f634..4537ca0466 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -3071,10 +3071,15 @@ mlx5_os_dev_shared_handler_install(struct mlx5_dev_ctx_shared *sh)
void
mlx5_os_dev_shared_handler_uninstall(struct mlx5_dev_ctx_shared *sh)
{
+ int fd;
+
mlx5_os_interrupt_handler_destroy(sh->intr_handle,
mlx5_dev_interrupt_handler, sh);
+ fd = rte_intr_fd_get(sh->intr_handle_nl);
mlx5_os_interrupt_handler_destroy(sh->intr_handle_nl,
mlx5_dev_interrupt_handler_nl, sh);
+ if (fd >= 0)
+ close(fd);
#ifdef HAVE_IBV_DEVX_ASYNC
mlx5_os_interrupt_handler_destroy(sh->intr_handle_devx,
mlx5_dev_interrupt_handler_devx, sh);
--
2.34.1