From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F39945C0F; Tue, 29 Oct 2024 23:23:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F139142EE8; Tue, 29 Oct 2024 23:23:40 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 803114060F for <dev@dpdk.org>; Tue, 29 Oct 2024 23:23:40 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20cf3e36a76so60302655ad.0 for <dev@dpdk.org>; Tue, 29 Oct 2024 15:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730240619; x=1730845419; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hzOEWgvB2tUboFYW8NPOkYLyN7aEynwSnHv9iicHqA0=; b=clwmfcGTr0oTOBiCVFaetlvnN0xSLn0I0jIi7JC80jDzBazRjnnTlfnptK8nYug9Om Gc+0ML0TX5yfVQZH691ptguuXyGSZ5eDv5hf+gUFiC2cRhxDKUGmsQbTfG3npq1eYbUL x1qsWLVxyh0v+/3HEDWbjSXpUYfZ9Eu6AZetJo11aCjO/EM7KDLd4ILqX+HY1UblQpcf OEbjnS2/P9CvM02GSbeC/tIZGgSiCJbGfS927YGLs+RvrkrYUpaXzAGIrlEU/7D57SxI 1b1YBEXl/XCRVoPr0m+CZEFe9822hLMWnjTVy9iEuimgz4dHa37EGiQhtNGKwSORcU2t 56gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730240619; x=1730845419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hzOEWgvB2tUboFYW8NPOkYLyN7aEynwSnHv9iicHqA0=; b=N3OtgKRo69JoWj2r+QuA51+BsqrrdLNO9NRaYvsyzqYG1H/YJTG+HPO0ZfGM+S3gox xArGEFKmWgCF6iky0dF659wH3SCJmGtnchYzo2siitmSmXHQD61a5SRhWlMZdrKLjn1H /G//lCD5ZAEdGLtyL4XcV6iWHo4B146nbJs/7XcZCdrrj5i+WXnVMvWWNWrIZYINTCA1 AqnjoGhRepodcwXmeocC0WyF4gfI7+dGuO47DVtjlcTVSeuSmYCv/jarIYuKDl0NpHBl eGAyueKtgIAfbRp9SWFZkFchpKvXdMZPq372C6iYqpdEGEravedzbLL0X6fsZWevSxMt vKsQ== X-Forwarded-Encrypted: i=1; AJvYcCUbjEg/DG2GMAvYWu7yJSKHyXqnkznSvqzJW2Sg767EvXmA8aNv91mGP0JhozvjuxV2aV4=@dpdk.org X-Gm-Message-State: AOJu0Yz0lsVL2/rCsimpVs5UMW3YUuQwne3bpZBMolmWEtNae3gS/OIq VT+fHTKDBCa4WDoKNpK09YqiQn7mXGHC+Qgeo4sZbdBrgOPSHUJGJEIo8G060ME= X-Google-Smtp-Source: AGHT+IE893EGnyXDwrr8xSpzcIcdiCDWJ7Y+t1RkaI5BH/yE+pieP/5W1Ks3+qKydGiDEej31rE7vQ== X-Received: by 2002:a17:902:ecc2:b0:20c:693b:6578 with SMTP id d9443c01a7336-210c6c0119emr192096615ad.25.1730240619582; Tue, 29 Oct 2024 15:23:39 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc044f82sm71218335ad.258.2024.10.29.15.23.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 15:23:39 -0700 (PDT) Date: Tue, 29 Oct 2024 15:23:36 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: Gregory Etelson <getelson@nvidia.com>, aman.deep.singh@intel.com, dev@dpdk.org, Praveen Shetty <praveen.shetty@intel.com>, david.marchand@redhat.com, mkashani@nvidia.com, thomas@monjalon.net, yuying.zhang@intel.com, Dariusz Sosnowski <dsosnowski@nvidia.com> Subject: Re: [PATCH v5 1/1] testpmd: add hairpin-map parameter Message-ID: <20241029152336.40b66c0b@hermes.local> In-Reply-To: <2785a2fb-2daf-4da4-9da3-0528740addde@amd.com> References: <f726aa50-97b0-4e7b-82fc-d51ee2090d47@amd.com> <20240922065053.996568-1-getelson@nvidia.com> <2785a2fb-2daf-4da4-9da3-0528740addde@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, 29 Oct 2024 21:51:40 +0000 Ferruh Yigit <ferruh.yigit@amd.com> wrote: > On 9/22/2024 7:50 AM, Gregory Etelson wrote: > > Hairpin offloads packet forwarding between ports. > > Packet is expected on Rx port <rp>, Rx queue <rq> and is forwarded > > to Tx port <tp> Tx queue <tq>. > > > > Testpmd implements a static hairpin configuration scheme. > > > > The new parameter allows explicit selection of Rx and Tx ports and > > queues in hairpin configuration. > > The new `hairpin-map` parameter is provided with 5 parameters, > > separated by `:` > > > > `--hairpin-map=Rx port id:Rx queue:Tx port id:Tx queue:queues number` > > > > Testpmd operator can provide several `hairpin-map` parameters for > > different hairpin maps. > > Example: > > > > dpdk-testpmd <EAL params> -- \ > > <testpmd params> \ > > --rxq=2 --txq=2 --hairpinq=2 --hairpin-mode=0x12 \ > > --hairpin-map=0:2:1:2:1 \ # [1] > > --hairpin-map=0:3:2:2:3 # [2] > > > > Hairpin map [1] binds Rx port 0, queue 2 with Tx port 1, queue 2. > > Hairpin map [2] binds > > Rx port 0, queue 3 with Tx port 2, queue 2, > > Rx port 0, queue 4 with Tx port 2, queue 3, > > Rx port 0, queue 5 with Tx port 2, queue 4. > > > > The new `hairpin-map` parameter is optional. > > If omitted, testpmd will create "default" hairpin maps. > > > > Signed-off-by: Gregory Etelson <getelson@nvidia.com> > > Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com> > > > > +Praveen > cpfl is only other driver that implements hairpin, @Praveen can you > please help reviewing this patch, and confirm change works fine with > your changes. > > @Stephen, if you have any free cycles, can you please help on this patch > too? > > Thanks, > ferruh Ok, can do semantic review but do not have any working HW with hairpin capability.