From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14C5145C4D; Fri, 1 Nov 2024 19:06:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 068B64026C; Fri, 1 Nov 2024 19:06:06 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 194EC4003C for <dev@dpdk.org>; Fri, 1 Nov 2024 19:06:05 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 12B7920C5D80; Fri, 1 Nov 2024 11:06:04 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 12B7920C5D80 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1730484364; bh=nk9r91K27EtbwAcTaX8+Rvqii1Q8m2JINp88G04oENg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kDJRyauHKojkGuRZwTqzrjaVhnp9cB77woYGQC9QrilJPkJTuqZxfP8xzPSXR3CSz 8VGQ6U72GisAWHpunDbY8eZePA/shWHDPY8qiAVPj3w4AcbfuSHQi+Zt7ldOym2D2M jVK5Cp8fqXLQ+ygSsoZEoVT8EyOhK2GdQvmwQxDw= Date: Fri, 1 Nov 2024 11:06:04 -0700 From: Andre Muezerie <andremue@linux.microsoft.com> To: Stephen Hemminger <stephen@networkplumber.org> Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>, dev@dpdk.org, Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>, Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Bruce Richardson <bruce.richardson@intel.com>, Chengwen Feng <fengchengwen@huawei.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>, Harry van Haaren <harry.van.haaren@intel.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>, Kevin Laatz <kevin.laatz@intel.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>, Pallavi Kadam <pallavi.kadam@intel.com>, Reshma Pattan <reshma.pattan@intel.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>, Yuying Zhang <Yuying.Zhang@intel.com> Subject: Re: [PATCH 00/16] remove use of VLAs for Windows built code Message-ID: <20241101180604.GA26638@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <20241007101546.2a19311b@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241007101546.2a19311b@hermes.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, Oct 07, 2024 at 10:15:46AM -0700, Stephen Hemminger wrote: > On Wed, 17 Apr 2024 16:41:43 -0700 > Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > > As per guidance technical board meeting 2024/04/17. This series > > removes the use of VLAs from code built for Windows for all 3 > > toolchains. If there are additional opportunities to convert VLAs > > to regular C arrays please provide the details for incorporation > > into the series. > > > > MSVC does not support VLAs, replace VLAs with standard C arrays > > or alloca(). alloca() is available for all toolchain/platform > > combinations officially supported by DPDK. > > > > Tyler Retzlaff (16): > > eal: include header required for alloca > > hash: remove use of VLAs for Windows built code > > ethdev: remove use of VLAs for Windows built code > > gro: remove use of VLAs for Windows built code > > latencystats: remove use of VLAs for Windows built code > > lpm: remove use of VLAs for Windows built code > > rcu: remove use of VLAs for Windows built code > > app/testpmd: remove use of VLAs for Windows built code > > test: remove use of VLAs for Windows built code > > common/idpf: remove use of VLAs for Windows built code > > net/i40e: remove use of VLAs for Windows built code > > net/ice: remove use of VLAs for Windows built code > > net/ixgbe: remove use of VLAs for Windows built code > > common/mlx5: remove use of VLAs for Windows built code > > net/mlx5: remove use of VLAs for Windows built code > > build: enable vla warnings on Windows built code > > > > app/test-pmd/cmdline.c | 2 +- > > app/test-pmd/cmdline_flow.c | 9 +++-- > > app/test-pmd/config.c | 16 +++++---- > > app/test-pmd/shared_rxq_fwd.c | 2 +- > > app/test/test.c | 2 +- > > app/test/test_cmdline_string.c | 2 +- > > app/test/test_cryptodev.c | 32 +++++++++--------- > > app/test/test_cryptodev_blockcipher.c | 4 +-- > > app/test/test_cryptodev_crosscheck.c | 2 +- > > app/test/test_dmadev.c | 9 +++-- > > app/test/test_hash.c | 8 ++--- > > app/test/test_mempool.c | 25 +++++++------- > > app/test/test_reassembly_perf.c | 4 +-- > > app/test/test_reorder.c | 48 +++++++++++++++------------ > > app/test/test_service_cores.c | 9 +++-- > > app/test/test_thash.c | 7 ++-- > > config/meson.build | 4 +++ > > drivers/common/idpf/idpf_common_rxtx.c | 2 +- > > drivers/common/idpf/idpf_common_rxtx_avx512.c | 6 ++-- > > drivers/common/mlx5/mlx5_common.h | 4 +-- > > drivers/common/mlx5/mlx5_devx_cmds.c | 7 ++-- > > drivers/net/i40e/i40e_testpmd.c | 5 ++- > > drivers/net/ice/ice_rxtx.c | 2 +- > > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +-- > > drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 2 +- > > drivers/net/mlx5/mlx5.c | 5 ++- > > drivers/net/mlx5/mlx5_flow.c | 6 ++-- > > lib/eal/linux/include/rte_os.h | 1 + > > lib/eal/windows/include/rte_os.h | 1 + > > lib/ethdev/rte_ethdev.c | 9 ++--- > > lib/gro/rte_gro.c | 4 +-- > > lib/hash/rte_cuckoo_hash.c | 4 +-- > > lib/hash/rte_thash.c | 2 +- > > lib/latencystats/rte_latencystats.c | 2 +- > > lib/lpm/rte_lpm.h | 2 +- > > lib/rcu/rte_rcu_qsbr.c | 6 ++-- > > 36 files changed, 137 insertions(+), 123 deletions(-) > > Looks good: > > Series-Acked-by: Stephen Hemminger <stephen@networkplumber.org> > > > Series needs to be rebased to current master, some parts have changed. Hi Stephen, I'll continue the work Tyler was doing on this front. You can expect a new rebased patch soon. I'll also adapt it for the parts that have changed.