From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C509945C76;
Mon, 4 Nov 2024 12:10:59 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1C04640E24;
Mon, 4 Nov 2024 12:10:45 +0100 (CET)
Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])
by mails.dpdk.org (Postfix) with ESMTP id DD6A8402AF
for <dev@dpdk.org>; Mon, 4 Nov 2024 12:10:40 +0100 (CET)
Received: from mail.maildlp.com (unknown [172.19.163.17])
by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Xhpcr2hGBz1SDPV;
Mon, 4 Nov 2024 19:09:00 +0800 (CST)
Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84])
by mail.maildlp.com (Postfix) with ESMTPS id 7C7251A0190;
Mon, 4 Nov 2024 19:10:39 +0800 (CST)
Received: from localhost.huawei.com (10.50.165.33) by
dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2507.39; Mon, 4 Nov 2024 19:10:39 +0800
From: Dengdui Huang <huangdengdui@huawei.com>
To: <dev@dpdk.org>
CC: <ajit.khaparde@broadcom.com>, <thomas@monjalon.net>,
<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,
<mb@smartsharesystems.com>, <david.marchand@redhat.com>,
<iboukris@gmail.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>,
<haijie1@huawei.com>, <liuyonglong@huawei.com>
Subject: [PATCH v5 07/52] pdump: replace strerror with reentrant version
Date: Mon, 4 Nov 2024 19:09:52 +0800
Message-ID: <20241104111037.3632161-8-huangdengdui@huawei.com>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <20241104111037.3632161-1-huangdengdui@huawei.com>
References: <20231114082539.1858594-1-huangdengdui@huawei.com>
<20241104111037.3632161-1-huangdengdui@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.50.165.33]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
dggpeml500011.china.huawei.com (7.185.36.84)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The function strerror() is insecure in a multi-thread environment.
This patch uses strerror_r() to replace it.
Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Huisong Li <lihuisong@huawei.com>
---
lib/pdump/rte_pdump.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
index 679c3dd0b5..83cb8b75d8 100644
--- a/lib/pdump/rte_pdump.c
+++ b/lib/pdump/rte_pdump.c
@@ -284,6 +284,7 @@ static int
set_pdump_rxtx_cbs(const struct pdump_request *p)
{
uint16_t nb_rx_q = 0, nb_tx_q = 0, end_q, queue;
+ char errmsg[RTE_STRERR_BUFSIZE];
uint16_t port;
int ret = 0;
struct rte_bpf *filter = NULL;
@@ -335,9 +336,11 @@ set_pdump_rxtx_cbs(const struct pdump_request *p)
ret = rte_eth_dev_info_get(port, &dev_info);
if (ret != 0) {
+ if (strerror_r(-ret, errmsg, sizeof(errmsg)) != 0)
+ snprintf(errmsg, sizeof(errmsg), "Unknown error %d", -ret);
PDUMP_LOG_LINE(ERR,
"Error during getting device (port %u) info: %s",
- port, strerror(-ret));
+ port, errmsg);
return ret;
}
@@ -731,15 +734,18 @@ int
rte_pdump_stats(uint16_t port, struct rte_pdump_stats *stats)
{
struct rte_eth_dev_info dev_info;
+ char errmsg[RTE_STRERR_BUFSIZE];
const struct rte_memzone *mz;
int ret;
memset(stats, 0, sizeof(*stats));
ret = rte_eth_dev_info_get(port, &dev_info);
if (ret != 0) {
+ if (strerror_r(-ret, errmsg, sizeof(errmsg)) != 0)
+ snprintf(errmsg, sizeof(errmsg), "Unknown error %d", -ret);
PDUMP_LOG_LINE(ERR,
"Error during getting device (port %u) info: %s",
- port, strerror(-ret));
+ port, errmsg);
return ret;
}
--
2.33.0