From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA1E045D6B; Thu, 21 Nov 2024 19:25:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68A4D42FDF; Thu, 21 Nov 2024 19:25:01 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 53D2E40A6B for ; Thu, 21 Nov 2024 19:24:56 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-724d23df764so712833b3a.1 for ; Thu, 21 Nov 2024 10:24:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732213495; x=1732818295; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7DdZaXIun8eKC7Xc1tS/1drNMQCXbn81we0F5N/eFRs=; b=e//fxDdfRiAiCSK7nKFpO3w3WW0pCPlZHGyB7gW07ON0z93CHWuI7hFlJjB7RYBUYo nW2xqDsRhgxCrloUEfDu+tOsRFtMfTCpU0vIf5o+8sv3Z2G14f6Cb0lFiZg9Y0WxfO+F Hvl4QYvGoAqUPkZt5ZBsItVYWNUrnlzKokYYqhjdM5jO/zGGsJ8kKRN5mPO4wuWVqNvs JpaHr7ozzCwIKht7in9vEi+oJVqoFLGUx+6VBbDWZTaJuY8uEEm21icR8XLPNKV4pj/Q TB69lBwquoadwufyYBiB6mZEfX+Esm8cckejTND17zyGnwTP4vrkUsQ/qObalcPHrb6q mENg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732213495; x=1732818295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7DdZaXIun8eKC7Xc1tS/1drNMQCXbn81we0F5N/eFRs=; b=R70hZLCfH1dnj+JgWCVvVqqRBn9rmroOcGseUwIuOJrOgp2N9Fe55p3uVQno9J5Kqq iMzEvQO+ggVYbpXtkizYyXp1u6KDquLdRtMRPuIjkBqzC6sXuVfwEjPztw+D0PJ6H1R6 7glj1jmuXTHDWb+mTu/bjuAGzGbyZJje8ScJopgZ/p2zpCwcRs6xDiwWjelFiVT5lXbR RuGyooFpX2qaNjNXAKOdcKzTROLgMg0HFjfxWEEtsmQCy8fPruR3QEGGgzTL+xRbxkiR JjHWdjiU+KfBoX7cB9c4eZj2ixetZBYADcCaba2FkhsuF9laFE7F4BsqRliE0sIUMV7d n4Gg== X-Gm-Message-State: AOJu0Yy75OUsMpegLdF8w5LaVX8vEKfoSV7K88kKndwjVOQHhXWGhNX9 49lHoL/a9Roy2v0vXeW7ttbS7Q/9mLgNZxU6IPlozRUmvFGNNUz2uGCP+27tLOWrOIAoLaYGQnG jeUM= X-Gm-Gg: ASbGnctEwBpTsE3KxskOfbV2qqDK28WZeLjWSEzmYxJpRikCaxQ3mI3okGYP2tvuwm5 lhYlPgqYzJdZs51C0v+DyLkys82KSmfkUneB5I57ZfV59FmgWggkTdP0sFqujKGuTth5FvpJIGc IqR3Km4uTI2RHNDbQdpntKLXIzqr7tpUsONkngrSvBy4SfU3o0UGLQTGyxWlLP0+jt5ESiqkXda j9rWzk9Rphm7HUA2duwXmeiHShbULM+mdvRBwt+CJvzi4c8alh0apcdDFHjsi01zlTSLVXutnH0 FbCieUvUt6PdDvwheA8N1NkVztE= X-Google-Smtp-Source: AGHT+IGKBihf7x62DujbfhOy7BgaNdSJgDhvJdnIOOQN169TsBI4dsWmkp7X5s50K62CxwW/SHnVAg== X-Received: by 2002:a05:6a00:1487:b0:71e:cf8:d6fa with SMTP id d2e1a72fcca58-724becbac09mr9330279b3a.15.1732213495541; Thu, 21 Nov 2024 10:24:55 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de454aa1sm70201b3a.4.2024.11.21.10.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2024 10:24:55 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , declan.doherty@intel.com, stable@dpdk.org, Chas Williams , "Min Hu (Connor)" , Pablo de Lara Subject: [PATCH v4 2/9] app/test: fix typo in address compare Date: Thu, 21 Nov 2024 10:23:23 -0800 Message-ID: <20241121182443.68025-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241121182443.68025-1-stephen@networkplumber.org> References: <20241114001403.147609-1-stephen@networkplumber.org> <20241121182443.68025-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The first argument of 'memcmp' function was equal to the second argument. Therefore ASSERT would always be true. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 92073ef961ee ("bond: unit tests") Cc: declan.doherty@intel.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- app/test/test_link_bonding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 805613d7dd..b752a5ecbf 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -792,7 +792,7 @@ test_set_primary_member(void) &read_mac_addr), "Failed to get mac address (port %d)", test_params->bonding_port_id); - TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr, + TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr, sizeof(read_mac_addr)), "bonding port mac address not set to that of primary port\n"); -- 2.45.2