From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D168F45D6B;
	Thu, 21 Nov 2024 19:25:44 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 678444329E;
	Thu, 21 Nov 2024 19:25:08 +0100 (CET)
Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com
 [209.85.210.181])
 by mails.dpdk.org (Postfix) with ESMTP id 2D95642FCF
 for <dev@dpdk.org>; Thu, 21 Nov 2024 19:25:01 +0100 (CET)
Received: by mail-pf1-f181.google.com with SMTP id
 d2e1a72fcca58-723f37dd76cso1275319b3a.0
 for <dev@dpdk.org>; Thu, 21 Nov 2024 10:25:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732213500;
 x=1732818300; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=l21Pg390V4j6zy88yz6E5exOjrveQVhJKRd99FzrHxg=;
 b=dDEUjr/LTUnDUJ6EwPh4KDDfiEUqtf5xyAGtOvkad+sW3eiEplsVsavs21ItGESb1h
 csB2DuHrgH3erE6jtbGFIPlSE5woVd0XZ6qN1p4ZiZrSl+I//wdhB1CJgSyxpBQLNyrM
 hwXdwR1uCin0HbVG5IY51EaN4tSYTbRgel4Hqv9aRWz33qbL/9ZOjBRvpaG0OIcIXu5d
 Ew+TIRuT/RGEgcgkqdcwHrvCtfSElG0PZ+vB6OGK4XhVAv0ZgAG8Bl0IjR/uaVEEnEOc
 oeqxi4ODDV8CdWVrxxWKzGy3TwZnfpX11MqB3nJscIjKlQsnUNHHy+ep+6whldDO44aM
 4Rjw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1732213500; x=1732818300;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=l21Pg390V4j6zy88yz6E5exOjrveQVhJKRd99FzrHxg=;
 b=oYA96PKi+O/VePeiaPMoR6+COAyFjqFfrKQyNVqdJlGkVU6/RpYvxK0L4yaGUcanUo
 bdSZs1EqNfMy2Jh11uRw59Cv0TdZJoV9dKyFWOfRNB3eouBG374FfZZ9pKPEiCfwdXDn
 472oQETcyi58dq4aNDAxPeajGEK3kOnYWXVIOYDQU/TN5lrEQqY3qpHjiqG1U5HJ7Rik
 9fSHeJbvdXGvjtCqEtvWUG7f1lO5/lOGoK+4iRWAWH9PhxUw4PJ3kAoOTA8n98G3E2DP
 2/qJqqhvov/NZ4+PzMqnvDqufY6GirPTH121T6KNQtt6kNhJtfl4utX3DoMqUoHnvTE+
 RXkw==
X-Gm-Message-State: AOJu0YzWJcasAh8bk3dAIfieMFmZAj8Tv/cv4Lfv+q/jPQF7+av21yhy
 x3DPv2bbU20cttkFWxZz4XMym7e5nVxgpRz25rAQxe7pwMa3d9zT71lc4i2ghmtBdt2OkfguPVz
 1GeI=
X-Gm-Gg: ASbGnctSs9rjmAofsqdlIe6z0FKMlSFuylDK0uRdu78hE1GbLqyQ/z+L5CcP6WmKaJR
 T3/wwnhH8/KQuwPcsRTj4rn0QNayzGY2gEKiPukm3HmLmsXCjC+id6qGNqWB2ojVCdEzpgqEZ2a
 NBNjKqgUeK53Jac6A4V+vdgpbwXvX2K8YUX377c4WmVRxr+jwba5kXhcFw9wd1XNHAVLa/t57vI
 LnRgdcCOt9HWTRoBhBrI+tCslgolPFswcVtxoiWpvdppSjdscrjGTx+P0rDjyPR0UPaeUYarjmi
 vKzzqIvWGneZg2lSHqL/sCc9ZyA=
X-Google-Smtp-Source: AGHT+IFemYW1D9UlVdceDtbSaH3f1u7721R5SiYWC2mopVqDvL6V3JvMTojRrgFfB01lzSNvwhkAhA==
X-Received: by 2002:a05:6a00:2355:b0:71e:52ec:638d with SMTP id
 d2e1a72fcca58-724beca52d3mr9026182b3a.10.1732213500360; 
 Thu, 21 Nov 2024 10:25:00 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-724de454aa1sm70201b3a.4.2024.11.21.10.24.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 21 Nov 2024 10:24:59 -0800 (PST)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, msantana@redhat.com,
 stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Tyler Retzlaff <roretzla@linux.microsoft.com>,
 Michael Santana <maicolgabriel@hotmail.com>,
 Aaron Conole <aconole@redhat.com>,
 David Marchand <david.marchand@redhat.com>
Subject: [PATCH v4 7/9] test/eal: fix core check in c flag test
Date: Thu, 21 Nov 2024 10:23:28 -0800
Message-ID: <20241121182443.68025-8-stephen@networkplumber.org>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20241121182443.68025-1-stephen@networkplumber.org>
References: <20241114001403.147609-1-stephen@networkplumber.org>
 <20241121182443.68025-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

The expression for checking which lcore is enabled for 0-7
was wrong (missing case for 6).

Link: https://pvs-studio.com/en/blog/posts/cpp/1179/

Fixes: b0209034f2bb ("test/eal: check number of cores before running subtests")
Cc: msantana@redhat.com
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test/test_eal_flags.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index d37d6b8627..e32f83d3c8 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -677,8 +677,8 @@ test_missing_c_flag(void)
 
 	if (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) &&
 	    rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) &&
-	    rte_lcore_is_enabled(3) && rte_lcore_is_enabled(5) &&
-	    rte_lcore_is_enabled(4) && rte_lcore_is_enabled(7) &&
+	    rte_lcore_is_enabled(4) && rte_lcore_is_enabled(5) &&
+	    rte_lcore_is_enabled(6) && rte_lcore_is_enabled(7) &&
 	    launch_proc(argv29) != 0) {
 		printf("Error - "
 		       "process did not run ok with valid corelist value\n");
-- 
2.45.2