From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B670245DAF; Wed, 27 Nov 2024 00:12:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C99840EE3; Wed, 27 Nov 2024 00:12:23 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 34C96402A7 for <dev@dpdk.org>; Wed, 27 Nov 2024 00:12:22 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7251ace8bc0so187627b3a.0 for <dev@dpdk.org>; Tue, 26 Nov 2024 15:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732662741; x=1733267541; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jm231pQrOLypBW4hUKmCZtV/44ZgU7pmKTAENCsDcm8=; b=XXcJQ4FtmqOtVnezcCLxbUCbDtkVhfggMxZiRQttgj+OCm6rdOmgUF8okW4egqurhs pg6B/zvKHqmfuDTpliU/YK2WXh5JXzL7MWt64e9BxIKRHTr8LdZLdKmiMT2C/BKrt79+ L8Cnh1SetaTKX2q3ax3ZhO7YdC2XpJE2+K/Rw/0rzbm96pDdQ1NwSvmf/WdrwH0qw8ia fnqy5dUhtFN4+A1/ftccGB5/neZ5yEx9KeGdP9q4Ky0WG1IbZjEs2gZp+TSJfz3kZw+A +1NEs9eucXo1gLR7Om4ZtebMhH1WxVe7kzWbWLFOGskfvnqlWkV5scdpg2vWp24nN07B OggA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732662741; x=1733267541; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jm231pQrOLypBW4hUKmCZtV/44ZgU7pmKTAENCsDcm8=; b=aaz8+MUzt6ae/EO8lv32KqexsN1tIZCQi/AEi2nPOz2Ohma2/9cYONPVBGBkib+d5R oSTxUJ5zHakPnFAFwvHx/BSqr7/s9bwWutvxoyhDuuz7sHGaM51jfgi5/R20bOaZ6lch 1YVKkd522pTaYjwltVUAZx9VF2wXheS1/eDy4e1e9bxf0ZN+xDJjo889yURHXB75pFqe Ap/aOXUrWnPqm/O5woQdzunNAshUyk6Ua5+LD+mSs9JfzRWZjJjgJsdI8oJiMFsIJSjY m0Cs/6md+4EgPdVXgegsfFmVdwvgKa4h3njnbM8313SzumugSPMrMQVSpi9nAmxQUlEU bPog== X-Gm-Message-State: AOJu0YwRshkx3RpvoxzJzI7Y5ymwScDbXGYzGxmSCB+GsvmJGP50K8oO blQe+TAbb73he567+DoNrsMFC1LhRmVfVG04UKy+3my0f2s8qtlvJzLV0gWzZQM= X-Gm-Gg: ASbGncuIQCdC3uwn9r4GDr3MJA3xW3c5C67qayEIh3yaBCTc7WrKtE0BZ5CQqKV1gHM pFBLe9u+sFpCvqYyJuC8NKA53O7UOqGXqEJcb1SzBIQH3dRJ20l1K0CqMwulGHb1d0kz7Yvp4JD YPQ6/U728oKcR3MU7bxIZiHqT6tXkIK2SlP/uVtrXn79bKvGgHqVB60BssGHPgOIzWCGYtqKRjl 0dn5AH94dX0ibtf3U50rG2cQqZdSexkNHAPjJBDU5hSc/ClqgkBTMbs3cdxwbYGXFfb/3hE+TTn kUleYtB1w4Q/qLEHFHQ+uNTXDm0= X-Google-Smtp-Source: AGHT+IGrjfAJz+w3VvGdyoveqCzQk4RH/zreTGnHzgcUfaqK+xGh273FyX7JfcEa6mxOpG6rA/yECw== X-Received: by 2002:a17:90b:3881:b0:2ea:8aac:6ac1 with SMTP id 98e67ed59e1d1-2ee098124a5mr1517608a91.15.1732662741163; Tue, 26 Nov 2024 15:12:21 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ee0fa306c1sm96128a91.1.2024.11.26.15.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 15:12:20 -0800 (PST) Date: Tue, 26 Nov 2024 15:12:18 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Jie Hai <haijie1@huawei.com> Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <mb@smartsharesystems.com>, <andrew.rybchenko@oktetlabs.ru>, <huangdengdui@huawei.com>, <fengchengwen@huawei.com>, <lihuisong@huawei.com> Subject: Re: [PATCH v2 0/3] bugfix about KEEP CRC offload Message-ID: <20241126151218.07d9d1c4@hermes.local> In-Reply-To: <20240718114806.577298-1-haijie1@huawei.com> References: <20240206011030.2007689-1-haijie1@huawei.com> <20240718114806.577298-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, 18 Jul 2024 19:48:02 +0800 Jie Hai <haijie1@huawei.com> wrote: > From: Dengdui Huang <huangdengdui@huawei.com> > > For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is still be stripped in rare scenarios. > Some users of hns3 are already using this feature. So driver has to recaculate packet CRC. > > In addition, in the mbuf, the data that exceeds the length specified by pkt_len is invalid. > Therefore, if the packet contains CRC data, pkt_len should contain the CRC data length. > However, almost of drivers supported KEEP CRC feature didn't add the CRC data length to pkt_len. > This patch adds description for KEEP CRC offload. > > Dengdui Huang (3): > ethdev: add description for KEEP CRC offload > net/hns3: fix packet length do not contain CRC data length > net/hns3: fix Rx packet without CRC data > > drivers/net/hns3/hns3_ethdev.c | 5 + > drivers/net/hns3/hns3_ethdev.h | 23 +++++ > drivers/net/hns3/hns3_rxtx.c | 134 ++++++++++++++++---------- > drivers/net/hns3/hns3_rxtx.h | 3 + > drivers/net/hns3/hns3_rxtx_vec.c | 3 +- > drivers/net/hns3/hns3_rxtx_vec_neon.h | 19 ---- > drivers/net/hns3/hns3_rxtx_vec_sve.c | 3 +- > lib/ethdev/rte_ethdev.h | 6 ++ > 8 files changed, 124 insertions(+), 72 deletions(-) > > -- Reworded some of the commit message to improve readability. Applied to next-net.