From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56DF945E20; Tue, 3 Dec 2024 20:58:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 041B140261; Tue, 3 Dec 2024 20:58:03 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 2DBF44025D for <dev@dpdk.org>; Tue, 3 Dec 2024 20:58:02 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-7fcdbfd8090so1913903a12.2 for <dev@dpdk.org>; Tue, 03 Dec 2024 11:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733255881; x=1733860681; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=pK2UzPOVjIMH1E1ZiM2sJGN5/5MEG1mVKJvlBfpNERo=; b=KpxZ+Nvy3fRhCujAlFv5I9iEVI0rP+QRD7M9giUoUbVVq3nY4ldVjbrSSkNKs18Xtc 2Da/8AzDDXgSz2sCTp+qkZyuRMXfLTyHXlmwv+apS2JvjLhGrOaOqiVXxlSnODLMAx8B fRyIu4YCTmnKMLMZCQEiq4g6MAAjbmWqUElz5ZQqNVYq+Ae4md/rQIV+R1CBaPPGcxnd CDkR5FlY7qsQ861TNZe9zkIE8Mgoos43OCQl3wNyWeMjY65W6Ixp0dvZuvMRz2vArh5B lYUuPkqwHf2DuvBfnAUqMreWbAuasCUE0cyMWf2X37Oa2hhOVydEBIOwjErRzFIzYVRJ iPeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733255881; x=1733860681; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pK2UzPOVjIMH1E1ZiM2sJGN5/5MEG1mVKJvlBfpNERo=; b=izr/23ZVV9agK8ZxlOfNgYvJ8wlNfdZOPkxg+PZkZGges+jvIJ7Qd1su1xJ29voJR7 M3JXznazSZ/nOB4xB0DDql3ZuK2XzNecdmeZ3c+l21fceT3WaS4QUB0KdVmMr6GdbWN4 W2molAp2WKfT82qEbPLC4f8vYUjOTKh9ShqvVwRQdFSfN3Q+LvjUMjgRDN4TeKuymANF qY7D0sL1qbWXm6/uzi3xfxXZJiXduGWNVHWSjmvl+lC4eukZDAC13KjVC98p9iXoemX9 a+5t2nysHbRGsrWGMcwS54wzx+HbyE9Gy3pGKuMAAtwSOdokp4Qb+uE+UiCpdHuit+62 ucZQ== X-Gm-Message-State: AOJu0YyubK7LNBLxFEVGib3luTogfHAlU2uKuvbKo533jbZTDPcrHWXG 68Ap/wb5Dm4ShP7T7gnkto+rg8iL5Gob1WtQxetsQij3f+CmpvKsu+rW2J0iT3s= X-Gm-Gg: ASbGncttodMhEj2yjqxbDCMnIoSTeYTSCMyTxmmpMuuGTcnbTHc9bjjsPKTJOCuYLkx eO6MCnbsg3NIAilq31mlCMrjYv5Hi7QwqAwciGQaBX4ymb8CLECCH/M8g/thmpSS4QEM20axgMw hrs5OMO8N/aefIxOXmmNTh+xGtcgAQBHlwlMfWTogsAvQfPL6i71iCn7E3tTsc5fiSDsNoDfaIk 2G7Hz9eydbBfl1t9lGZk3icgfIhYeXbh001K4OwfmxD9xbwOz6d5gPJstsoBg5T8eW5dC5Vlf2r 9KPqZfVX1d4e8dfzYUqRFDJzv+4= X-Google-Smtp-Source: AGHT+IGlguRq9CpxsXB17S6X00/6le66pu+/flrb8mVTq2Oo9Oy7eWndl0reXMKt4e47LasqxmpW8g== X-Received: by 2002:a05:6a20:4314:b0:1e0:d42f:7242 with SMTP id adf61e73a8af0-1e1653f3225mr6034082637.30.1733255881167; Tue, 03 Dec 2024 11:58:01 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7254176f3d7sm10880333b3a.55.2024.12.03.11.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 11:58:00 -0800 (PST) Date: Tue, 3 Dec 2024 11:57:58 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Chaoyong He <chaoyong.he@corigine.com> Cc: dev@dpdk.org, oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>, Peng Zhang <peng.zhang@corigine.com> Subject: Re: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size Message-ID: <20241203115758.7a74ebcf@hermes.local> In-Reply-To: <20241011032412.3672788-3-chaoyong.he@corigine.com> References: <20240624020355.3712965-1-chaoyong.he@corigine.com> <20241011032412.3672788-1-chaoyong.he@corigine.com> <20241011032412.3672788-3-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, 11 Oct 2024 11:24:12 +0800 Chaoyong He <chaoyong.he@corigine.com> wrote: > From: Long Wu <long.wu@corigine.com> > > The testpmd application can not modify the value of > dedicated hardware Rx/Tx queue size, and hardcoded > them as (128/512). This will cause the bonding port > start fail if some NIC requires more Rx/Tx descriptors > than the hardcoded number. > > Therefore, add a command into testpmd application to > support the modification of the size of the dedicated > hardware Rx/Tx queue. Also export an external interface > to also let other applications can change it. > > Signed-off-by: Long Wu <long.wu@corigine.com> > Reviewed-by: Peng Zhang <peng.zhang@corigine.com> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com> 24.11 is released, this patch if still of interest will need to be rebased. The definition of what a "dedicated queue" is a bit confusing. If it is only for LACP packets, it should never need to be very big. Only under a mis-configuration and DoS kind of flood should there ever be many packets.