From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CC29C45E21;
	Tue,  3 Dec 2024 22:41:15 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B8E8640261;
	Tue,  3 Dec 2024 22:41:15 +0100 (CET)
Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com
 [209.85.215.180])
 by mails.dpdk.org (Postfix) with ESMTP id 807404025D
 for <dev@dpdk.org>; Tue,  3 Dec 2024 22:41:14 +0100 (CET)
Received: by mail-pg1-f180.google.com with SMTP id
 41be03b00d2f7-7fcdb53cca6so1747840a12.0
 for <dev@dpdk.org>; Tue, 03 Dec 2024 13:41:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733262073;
 x=1733866873; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=zeIy32dwdoY4n0AVCXLJpXdq99OvgqO5k9ChySq1hl8=;
 b=iH7NdIJ0FuI1xsztQH3jwTHZ9hn1dBX1ZSqJXzUQtYyWHLmc72FoOitdO9imVa1fPX
 znrT7O5geRRE51793qQrijeAkVSOWeHq8S2AN/eYtTDjicRvjkQ+NVdBmZ0JQGfpzGDS
 VDkrqE0SHOi41EsKCp50UgDxPP+JNWSPIZXFkwAXsIHkbpa6Mz/olcn96yEsbmQmE7M0
 reotQ0rzA2ccF59e94xmu8xzKrKmBjJZPTulu2TNm3oSXA/Xgl706LbO/yxIEW9hrzlE
 ZewNKubgAFdefAVCROhN/vWB2n94/Z9VPaj5YIVwwm4+ktbNyKlGShOa/jcX2CuwO3AM
 g7XA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1733262073; x=1733866873;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=zeIy32dwdoY4n0AVCXLJpXdq99OvgqO5k9ChySq1hl8=;
 b=Mag7GD1Q7rvaaEIliRqaMGCOKhFVHvPdoHPPERvdTwKqvopLIYLftEpQDBhyzKF0UJ
 yOqiWEsQWwi7tTWLqW7jLiwt/2ZkCADWcXVP3djf58sUYaZgIdR1EnFybLxFoAckUONn
 H50rgiiMB366xOOLBTn9uH21ObvZ9PUTugx6yMyexkn+ra5cjn+BmBfJ3POiLpbpfHJs
 4u98FeOQLF/Pl4vnLwdNOZgAfVkY1xhZbxl/nTvzRJUtYPinJC6MHPIJ0KY6c4LUeLmS
 PR2wKUdJsDsQHsdeStk/BLoX/d8sQ1gSqjPNv/hDPzc4zUvm1OMoVLgfVJPgI0mIoAId
 3s1w==
X-Forwarded-Encrypted: i=1;
 AJvYcCUXh1c9pD//42lwYcJnafYO/dqVs1ccmN0wnN6HEiNnynbfgc1f8fUko11Nf2qSXXXEJjg=@dpdk.org
X-Gm-Message-State: AOJu0Ywrv5V/1EgEW3mVPL+EwcAEy7zP1H3+BJFwKRe28hGGZ4TQAASy
 GWlWz+fBrohVNgFFggs9qyoLmdtz8dIu9bEuvsYHykTN4LUerOP0BHN0OqvV5qk=
X-Gm-Gg: ASbGncuqrd48g+hY4Yt/wMiHUDv6EYVxDaF2CwQ5LG5lEpr1AGA/5qi+D++3Xwtt/MV
 kTkrbXvOpiL/vSUd0Bom8xUt/F3d9Plpsy2gJk/Bme2sQ+LIoOgVyFdGzOLUhI95Oq17XQcZLni
 UZhwohXaKis0cVZg8J2sDkAvNdEcKUFscqZd9RzzZaoqtj2hKChi6Z+6/H5n72ziD/I+terQTkI
 nioJMWS7qqyff/KtEzs/9zx3I/5tT2TqJLQLsaql3sF8hV1tHIDQ82TaXcA42PbbDyntFVAYsf6
 KN+XVDWOUKQcsD2VUvgI87kVgLs=
X-Google-Smtp-Source: AGHT+IH90QGdaxclYtxNwwtz5NXI9eo2IPdYDMaKRlEeGd2n568U9tZ7TBVP1ptTfoWvg5W7y+skdg==
X-Received: by 2002:a05:6a20:9144:b0:1db:e536:158e with SMTP id
 adf61e73a8af0-1e1653c82e4mr6394707637.22.1733262073650; 
 Tue, 03 Dec 2024 13:41:13 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-7258c559ae8sm158727b3a.111.2024.12.03.13.41.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 03 Dec 2024 13:41:13 -0800 (PST)
Date: Tue, 3 Dec 2024 13:41:06 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Tomasz Duszynski <tduszynski@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, "Sunil Kumar Kori"
 <skori@marvell.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>,
 <Ruifeng.Wang@arm.com>, <bruce.richardson@intel.com>,
 <david.marchand@redhat.com>, <dev@dpdk.org>,
 <konstantin.v.ananyev@yandex.ru>, <mattias.ronnblom@ericsson.com>,
 <mb@smartsharesystems.com>, <thomas@monjalon.net>, <zhoumin@loongson.cn>
Subject: Re: [PATCH v16 4/4] eal: add PMU support to tracing library
Message-ID: <20241203134106.46a083a9@hermes.local>
In-Reply-To: <20241118073706.3129423-5-tduszynski@marvell.com>
References: <20241025085414.3412068-1-tduszynski@marvell.com>
 <20241118073706.3129423-1-tduszynski@marvell.com>
 <20241118073706.3129423-5-tduszynski@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, 18 Nov 2024 08:37:06 +0100
Tomasz Duszynski <tduszynski@marvell.com> wrote:

> +
> +	/* events are matched against occurrences of e=ev1[,ev2,..] pattern */
> +	ret = regcomp(&reg, "e=([_[:alnum:]-],?)+", REG_EXTENDED);
> +	if (ret) {
> +		PMU_LOG(ERR, "Failed to compile event matching regexp");
> +		return -EINVAL;
> +	}
> +
> +	for (;;) {
> +		if (regexec(&reg, pattern, 1, &rmatch, 0))
> +			break;
> +

As with log parameters. Regex is harder to work with than a glob based syntax.