From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0F9A445E21;
Tue, 3 Dec 2024 22:42:29 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2AEC840261;
Tue, 3 Dec 2024 22:42:28 +0100 (CET)
Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com
[209.85.210.177])
by mails.dpdk.org (Postfix) with ESMTP id CCA1C4025D
for <dev@dpdk.org>; Tue, 3 Dec 2024 22:42:26 +0100 (CET)
Received: by mail-pf1-f177.google.com with SMTP id
d2e1a72fcca58-724f41d550cso3728935b3a.2
for <dev@dpdk.org>; Tue, 03 Dec 2024 13:42:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733262146;
x=1733866946; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=dZAQ1dDgGi2OsUjultKQC/a+6H+0VcyOwSC6kiUVQuA=;
b=nHstWSgxekSlX5P/vLHGtv1WlXXKzTdIY2kBHV2BoIeq6yvm7WjwAg/h4gxaqP14LD
eFZUresp3ElMcH/dziSWwNI5ZNy6NG50Mma/2fvWjpJsSa0J34BbbZ0uob2Un/TPV9Y8
SknKShjH3yMpajJRb5A1dxAyeZQvp/wDn6cmVdHU/+0xBI54VqSBidaJhDJAoRDVFLq4
clCd/g2nZjMHktaJ1HkGhrZntfcRlMr1Vv9Wjp/9e+e2Z6w1GEcbmKc5QZiqHIEsJKZ+
HjCVJviT54yorckvs4KBAPa6N32s/FEXFFuYcKj41i4XQfo+JS/LKS+Xaq9wRUlSwZQq
WeWw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1733262146; x=1733866946;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=dZAQ1dDgGi2OsUjultKQC/a+6H+0VcyOwSC6kiUVQuA=;
b=vzZKyEt0+b1bfja61Kc/zkH1Lwzb8AWy3oEyfNb3czxBWn6eys93FZyzBGRmxT59Sz
AfRqFWzgV5K5ef8B78180BR1AmoqrT/ga/OO6R+/kD0M3UCEfmtZTKIYo11qC87ftvBN
Pe6nENbp6dI7BmTvTyr4sELKqt6upU15FVLtUshXKqaYOGfLSvwmyR1tSV4MAayqousU
9dpI+HGPOyrCVricQYyv45JkDlyuUXx6u02m6sA0NMI5HdrowJw6XoMfa5Y8duhNWyrv
0WglvA92c5ljBV63rCU0HJbj1pGztF1s9syibMA9/50+FUT2OObF5fgKVV+2Hckqs4Nc
bJ2Q==
X-Forwarded-Encrypted: i=1;
AJvYcCW5MoVXPD2SCTSkrYiBjJb/Ur/0DzrzEin593/Be7Ad06tLFPhtKa8OQ7zaYWpcRUJACzE=@dpdk.org
X-Gm-Message-State: AOJu0YwXWEKJg+x4QlrZg2DLJWHKKqr5Q3qzCnuLD+RYMKW8Gv1FwAgR
Z8gbgw7Q1qIdMSWfzl7X0NUu+eNzjlmmX3FTyK3q61pUgclLOULwKe/WAcNSdWA=
X-Gm-Gg: ASbGncubTQT8C50kv9o4cPzXUv9iE2USMeyrTFx10mfl1IDge07yafMviCkPGiruCjU
eN4vHBgzVtfbzFmJAOyUgHqo1ImkJKpdG2tXucM0ohOTs/7CbwJzEkOaNcFvBTWsr5+vxfLSS3C
VaDTcahBdT7RMIQLt33mLtS0TOUiuW0d7kD+psgXse7AAdDyzm1euH/orYqHsA1NffgqFsH+2eM
LmoDa5+TUIOShVR9Nwvj9D824i7VFJyOky4rVsnVWrJOfSiXbb3RZE68IXS9k1DCZ0754661D1s
F5VKIca1QckleG55PkVca5eEivQ=
X-Google-Smtp-Source: AGHT+IG78fhrOiQqnlf8VQwELpbJBiiDJzr6DYtSELaafuNen8k67UWc+6EtpRds6tSVElt6YSvsIg==
X-Received: by 2002:a05:6a00:1496:b0:724:f8d4:2b6e with SMTP id
d2e1a72fcca58-7257fa3f671mr5368517b3a.4.1733262145845;
Tue, 03 Dec 2024 13:42:25 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-725417616ddsm11031728b3a.13.2024.12.03.13.42.25
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 03 Dec 2024 13:42:25 -0800 (PST)
Date: Tue, 3 Dec 2024 13:42:18 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Tomasz Duszynski <tduszynski@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, "Sunil Kumar Kori"
<skori@marvell.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>,
<Ruifeng.Wang@arm.com>, <bruce.richardson@intel.com>,
<david.marchand@redhat.com>, <dev@dpdk.org>,
<konstantin.v.ananyev@yandex.ru>, <mattias.ronnblom@ericsson.com>,
<mb@smartsharesystems.com>, <thomas@monjalon.net>, <zhoumin@loongson.cn>
Subject: Re: [PATCH v16 4/4] eal: add PMU support to tracing library
Message-ID: <20241203134218.0fb84a24@hermes.local>
In-Reply-To: <20241118073706.3129423-5-tduszynski@marvell.com>
References: <20241025085414.3412068-1-tduszynski@marvell.com>
<20241118073706.3129423-1-tduszynski@marvell.com>
<20241118073706.3129423-5-tduszynski@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Mon, 18 Nov 2024 08:37:06 +0100
Tomasz Duszynski <tduszynski@marvell.com> wrote:
> +static int
> +add_events(const char *pattern)
> +{
> + char *token, *copy;
> + int ret = 0;
> +
> + copy = strdup(pattern);
> + if (copy == NULL)
> + return -ENOMEM;
> +
> + token = strtok(copy, ",");
Since strtok is not thread safe, either use strtok_r or another
way to parse comma seperated list.
Maybe rte_strsplit could help?