From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B9F545E33; Wed, 4 Dec 2024 22:51:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CAD440EA5; Wed, 4 Dec 2024 22:51:07 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 60A0240EA5 for ; Wed, 4 Dec 2024 22:51:05 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7242f559a9fso317635b3a.1 for ; Wed, 04 Dec 2024 13:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733349064; x=1733953864; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zWm/crVKAUEA0A0RwuyBXEL1/Ulk2eCdLHYSnTX0uMQ=; b=uqPAK3LzDFZi4UxFbWEZu21sPUAG+CD1jMEP1gueDZomzn7vMK5kCtd4KaVcQWMmRU UGnE8ML2GDYENLY7V72rr9Mp6eCRZCBdhRdgGSzseBLKAenb75nGTxjQ/uml82ZXfLtY kO56SoxOSiEb1wl/jQypAYwpDNOoqGIPO0nqNon+eA+3XPbO05ePCySRpckSAZ1u5r2j 1KYP9W7V5R4nqAEWWF+qmkqyZOYDM+K1g4IguTVf41aHxvivXIDzuaakdVkHq6T/z2y7 RiBvNoBNPRJAAk0g/hOgvQvSrJwdB3t46Gw7O2P7P1brvTKV7T+Oxj7jCyfNALm/sCe2 nSHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733349064; x=1733953864; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zWm/crVKAUEA0A0RwuyBXEL1/Ulk2eCdLHYSnTX0uMQ=; b=vjWzaG+hVQ47LNvkb6YvnTnHc4gMyCjD0I6S8RzalEHDzDnuIfoivJvip2xXJw+A4j reDhIcF/49e9INvciWS9oIs2PSetPKcULweCKF+6Zwy9GmXBco6oXVeOm5GXk2ATy6/d xoaj96PGN0/pWtR5ycO7VewRF06neV1pdOo7YkpcbMDlUh3vKZtdT4bQBLRd5mccodHh XgUB/NWv1p9fLVvnrSs6IdOQXcy2I7tUCGdbB9sfddzjdAotc5IICWcYWICC3P8HT6jb 079C0jX1GkHS536fMOl6VmRBQ5Kb0HrsykUNUV/Jcxz5rl3Ar89lLpeJAHP/vA5VpbqF HTPQ== X-Gm-Message-State: AOJu0YxYWF7v2F7MpX8lO4JFKtuAmdRXKpqHE+mQ+tCYgSJKTuK3IcHD 9OzuCOA/jykPHKXsx8g9Uz9a63aZ/JBQnfDdUndqpf3nJ0j+4Hfw3V+iogQ4DAGTmzsK3WfjL8O u X-Gm-Gg: ASbGncsUlqAkcp48Z9uZtHgoWid0epz9Vg54PXbABc0DywFR3QssAI9cXdDDv2lYMWA UKNJcDVIs1999Ta/Lkw/+FHK60mAORtLVW4SeJ6IqBvduNKM4Irk9apK74UQA2S2HGiJrdDPIhL c8rrdCcAy3bnlwRsSfEGfyCKpm+ybClg8QMmOvUa5FkQBMHz8cBzhTiHiur+qsu2s7Mw3Rg4vqZ FJYkv1CboELsRNrbChNEyg+1XNkGpuGMKvBeE7+zP8dl7FTk9XraQNgEFav8ZxrbTMFXuinoCGT lvcUYEXtW6V/TNPh33iGIrZ9WCA= X-Google-Smtp-Source: AGHT+IEk14pUE2u6+K4xYMuqdgPhUNfZX7YGAAMw5k0NwDQ/vieeI+bs5BAonJbpFuyQIp2ak+aj2g== X-Received: by 2002:a05:6a00:1703:b0:71e:b4ee:960d with SMTP id d2e1a72fcca58-7257fa5908emr8540459b3a.10.1733349064572; Wed, 04 Dec 2024 13:51:04 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7254176f47asm12854328b3a.43.2024.12.04.13.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2024 13:51:04 -0800 (PST) Date: Wed, 4 Dec 2024 13:50:58 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: dev@dpdk.org Subject: Re: [PATCH 0/6] eliminate dependency on non-portable __SIZEOF_LONG__ Message-ID: <20241204135058.2dfc6164@hermes.local> In-Reply-To: <1733342995-3722-1-git-send-email-andremue@linux.microsoft.com> References: <1733342995-3722-1-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 4 Dec 2024 12:09:49 -0800 Andre Muezerie wrote: > Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. > Therefore the errors below are seen with MSVC: > > ../lib/mldev/mldev_utils_scalar.c(465): error C2065: > '__SIZEOF_LONG__': undeclared identifier > ../lib/mldev/mldev_utils_scalar.c(478): error C2051: > case expression not constant > > ../lib/mldev/mldev_utils_scalar_bfloat16.c(33): error C2065: > '__SIZEOF_LONG__': undeclared identifier > ../lib/mldev/mldev_utils_scalar_bfloat16.c(49): error C2051: > case expression not constant > > Turns out that the places where __SIZEOF_LONG__ is currently > being used can equaly well use sizeof(long) instead. > > Andre Muezerie (6): > drivers/bus: eliminate dependency on non-portable __SIZEOF_LONG__ > drivers/common: eliminate dependency on non-portable __SIZEOF_LONG__ > drivers/dma: eliminate dependency on non-portable __SIZEOF_LONG__ > drivers/net: eliminate dependency on non-portable __SIZEOF_LONG__ > drivers/raw: eliminate dependency on non-portable __SIZEOF_LONG__ > lib/mldev: eliminate dependency on non-portable __SIZEOF_LONG__ > > drivers/bus/fslmc/mc/fsl_mc_cmd.h | 2 +- > drivers/common/cnxk/roc_bits.h | 4 ++-- > drivers/common/nfp/nfp_platform.h | 4 ++-- > drivers/dma/dpaa/dpaa_qdma.h | 2 +- > drivers/dma/hisilicon/hisi_dmadev.h | 2 +- > drivers/net/ena/base/ena_plat_dpdk.h | 4 ++-- > drivers/net/hns3/hns3_ethdev.h | 2 +- > drivers/raw/ifpga/base/opae_osdep.h | 4 ++-- > lib/mldev/mldev_utils_scalar.h | 2 +- > 9 files changed, 13 insertions(+), 13 deletions(-) > > -- BITS_PER_LONG etc should be in rte_common.h not scattered all over these drivers.