From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 309A445E71; Wed, 11 Dec 2024 04:13:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9AE7402E2; Wed, 11 Dec 2024 04:13:26 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 6DFB6402DE for ; Wed, 11 Dec 2024 04:13:25 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-725dbdf380aso2932746b3a.3 for ; Tue, 10 Dec 2024 19:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733886804; x=1734491604; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Gwne8Iw4fJngC8ngOJrLRcM0DvSUUYETF6SiHt9Nbkg=; b=SvQrFHY60+E+p5GM5fF+Lh8Q2gl5gcAE6wWfYkvdD3yZa03b0psjZZ/nvjbTTefyUj 6DffYthaPSuAgyrNsmby1BtAlZ7gOgaODvRzGNQNFCnGQcm51114GotiNYsNOVeubgWG E3eH2Q6H4m9QyB08sqdBoYwzxM0Bm7FsvA8yiWatnmAOcr1iM1VtBahUMfAsGbR72w1e u+wlcy6SsCcEu/aWrbcIdc4drnwHDmaB4ZD0N5TFFYKXvyaxeqKO/czPCDiRQRTbgtqM xpVObbp0MA3NngSkRNGjG0oSLSGzylg76LIkuMq1lWaElZ53Y64/LDjG1wiObnOPbeJT dzIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733886804; x=1734491604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gwne8Iw4fJngC8ngOJrLRcM0DvSUUYETF6SiHt9Nbkg=; b=Bd1UBhaxAmLEzZz3aHE6dxjruaC7wTRj050V3D6FLJ+8EACbLmnZh2nF/fLdORD1Kg yj6DQcN6YNTl3Epc+5Nszqf2tNNjSrjgjTtVNtsVB/TIddJk4NbSr1jM1g3J8W7/gP8L vd8XwG1DA0o7I57ll+QV1vKVcaRoiLJ55Ce29apWMJw/e3E9gwRHyH2NDhpjzeXK8fLH ci5G9Thc8D/09lg7jR27OkJfk1tUlVbU5C0V7Q04rYSpv0vMU10UIA2w1pdagtKwxcZG i4sDrBoj/CFYSAkkWgK2bnMZBFyaDrTcwLVk1Rvjw8jaUV425/nd3pvHaJXJxh4SUC6R TRDQ== X-Gm-Message-State: AOJu0Yyk/9cWGr7sTR2GeK4o0JCvWPLQKkDERXLm3zf+a4+0r6DAMl13 wIHp3kSCUE3HMkbSnS/zOhzT5QzLtN4z8NXSpYBFP87FFjzcHO4CZS9TuJp5RmY= X-Gm-Gg: ASbGncs4k1CdphaX+3y2zEeHKbrHPwrq7ILfVQ1xylM2ZZaojnphxI8tqPWvwF2eo9l M38yY9S3iEuTKDnt5Fa7n78CJcvmf1/YEUyTGXEXvSz5CGLvc/DGnPQgRnOtQnIjbYOoVOXshBz OPCbGD8ou/XfR+7iE626bGCNVzaGqyNVXMxp8+m3lrlj04c/ORjw/qysgVFy5K9zWsc9Qx51BEZ TR6UAv5weZVeuA0onpro/RW4zPcJX511vQ05LaAD4Rfjsm5HPbKfO8IFicglGUFwNf83GHM3+Xd /8qsdH2wlx1GLkC1GsYSkCNfxh3+fOs= X-Google-Smtp-Source: AGHT+IHc745cXpqivlQghztbRIbtijEiXbWJyy3NypIJC63/BGk80r+QceESbO4qWNnM/RYDksD4NA== X-Received: by 2002:a05:6a20:a120:b0:1e1:a9dd:5a68 with SMTP id adf61e73a8af0-1e1c12ab5c6mr2158438637.1.1733886804030; Tue, 10 Dec 2024 19:13:24 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-725ea44c362sm5083734b3a.102.2024.12.10.19.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 19:13:23 -0800 (PST) Date: Tue, 10 Dec 2024 19:13:21 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: dev@dpdk.org Subject: Re: [PATCH 16/21] lib/log: ensure code structure does not change Message-ID: <20241210191321.32919f26@hermes.local> In-Reply-To: <1733882751-29598-17-git-send-email-andremue@linux.microsoft.com> References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> <1733882751-29598-17-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 10 Dec 2024 18:05:46 -0800 Andre Muezerie wrote: > Add "do { } while (0)" to macros used to remove logging calls, to > ensure there's no code structure change when enabling/disabling > logging. > > Signed-off-by: Andre Muezerie > --- > lib/log/rte_log.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h > index 3735137150..6b00caab88 100644 > --- a/lib/log/rte_log.h > +++ b/lib/log/rte_log.h > @@ -364,7 +364,7 @@ int rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap) > static_assert(!__builtin_strchr(fmt, '\n'), \ > "This log format string contains a \\n") > #else > -#define RTE_LOG_CHECK_NO_NEWLINE(...) > +#define RTE_LOG_CHECK_NO_NEWLINE(...) do { } while (0) > #endif > > /** NAK this is a change since static_assert() can be put anywhere like outside of code blocks. This patch is not needed.